Patchwork shiboken: Add `apiextrator-native` to `DEPENDS`

login
register
mail settings
Submitter Paul Menzel
Date June 19, 2011, 9:56 a.m.
Message ID <1308477368.18748.7.camel@mattotaupa>
Download mbox | patch
Permalink /patch/6125/
State Accepted
Commit 1b9260e7a6c756d6938821f013a41c371065980a
Headers show

Comments

Paul Menzel - June 19, 2011, 9:56 a.m.
Date: Sun, 19 Jun 2011 11:45:37 +0200

Task configure fails with the following error message using `minimal{,-uclibc}` for `MACHINE = "beagleboard"`.

	+ cmake . -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_INSTALL_SO_NO_EXE=0 -DCMAKE_TOOLCHAIN_FILE=/oe/build-minimal-uclibc/minimal-uclibc-dev/work/armv7a-oe-linux-uclibceabi/libshiboken-1.0.2-r1.1/toolchain.cmake -DCMAKE_VERBOSE_MAKEFILE=1 -Wno-dev
	CMake Warning at cmake/Modules/FindQt4.cmake:351 (message):
		QT_LIBRARY_DIR:
	Call Stack (most recent call first):
		CMakeLists.txt:9 (find_package)

	CMake Warning at cmake/Modules/FindQt4.cmake:352 (message):
		QT_LIBINFIX:
	Call Stack (most recent call first):
		CMakeLists.txt:9 (find_package)

	CMake Warning at cmake/Modules/FindQt4.cmake:353 (message):
		QT_DIR_NAME:
	Call Stack (most recent call first):
		CMakeLists.txt:9 (find_package)

	CMake Error at CMakeLists.txt:10 (find_package):
		Could not find module FindApiExtractor.cmake or a configuration file for
		package ApiExtractor.

		Adjust CMAKE_MODULE_PATH to find FindApiExtractor.cmake or set
		ApiExtractor_DIR to the directory containing a CMake configuration file for
		ApiExtractor.  The file will have one of the following names:

		  ApiExtractorConfig.cmake
		  apiextractor-config.cmake

	CMake Error at CMakeLists.txt:11 (find_package):
		Could not find module FindGeneratorRunner.cmake or a configuration file for
		package GeneratorRunner.

		Adjust CMAKE_MODULE_PATH to find FindGeneratorRunner.cmake or set
		GeneratorRunner_DIR to the directory containing a CMake configuration file
		for GeneratorRunner.  The file will have one of the following names:

		  GeneratorRunnerConfig.cmake
		  generatorrunner-config.cmake

Adding `apiextrator-native` to `DEPENDS` fixes the error.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
CC: Simon Busch <morphis@gravedo.de>
---
Dear Simon,


unfortunately I am not able to test this, because of Qt4 build problems [1]. Could you please test this.


Thanks,

Paul


[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032978.html
---
 recipes/pyside/shiboken.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Simon Busch - June 19, 2011, 7:08 p.m.
On 19.06.2011 11:56, Paul Menzel wrote:
> unfortunately I am not able to test this, because of Qt4 build problems [1]. 
> Could you please test this.

I gave this a quick run an I am fine with it. You can put my

Acked-by: Simon Busch <morphis@gravedo.de>

below the commit.

regards,
Simon
Paul Menzel - June 19, 2011, 8:08 p.m.
Am Sonntag, den 19.06.2011, 21:08 +0200 schrieb Simon Busch:
> On 19.06.2011 11:56, Paul Menzel wrote:
> > unfortunately I am not able to test this, because of Qt4 build problems [1]. 
> > Could you please test this.
> 
> I gave this a quick run an I am fine with it. You can put my
> 
> Acked-by: Simon Busch <morphis@gravedo.de>
> 
> below the commit.

Thank you. I pushed it in 1b9260e7 [1] and updated the state in the
patch queue.

	$ ~/src/patchwork/apps/patchwork/bin/pwclient update -s Accepted -c 1b9260e7a6c756d6938821f013a41c371065980a 6125


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=1b9260e7a6c756d6938821f013a41c371065980a

Patch

diff --git a/recipes/pyside/shiboken.inc b/recipes/pyside/shiboken.inc
index d09953d..56901ab 100644
--- a/recipes/pyside/shiboken.inc
+++ b/recipes/pyside/shiboken.inc
@@ -4,7 +4,7 @@  HOMEPAGE = "http://www.pyside.org"
 LICENSE = "LGPL"
 INC_PR = "r1"
 
-DEPENDS = "generatorrunner-native"
+DEPENDS = "apiextractor-native generatorrunner-native"
 
 SRC_URI = "http://www.pyside.org/files/shiboken-${PV}.tar.bz2"
 S = "${WORKDIR}/shiboken-${PV}"