Patchwork [3/3] binutils: remove embedsp

login
register
mail settings
Submitter Saul Wold
Date Nov. 6, 2013, 10:02 p.m.
Message ID <1383775339-4220-3-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/61215/
State New
Headers show

Comments

Saul Wold - Nov. 6, 2013, 10:02 p.m.
This is only built for PPC and not needed, so remove it to fix the QA Issue

ERROR: QA Issue: binutils: Files/directories were installed but not shipped
  /usr/bin/embedspu

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-devtools/binutils/binutils_2.23.2.bb | 6 ++++++
 1 file changed, 6 insertions(+)
Phil Blundell - Nov. 7, 2013, 7:27 a.m.
On Wed, 2013-11-06 at 14:02 -0800, Saul Wold wrote:
> This is only built for PPC and not needed, so remove it to fix the QA Issue
> 
> ERROR: QA Issue: binutils: Files/directories were installed but not shipped
>   /usr/bin/embedspu

The QA error above talks about "embedspu", but both the subject line of
your message and the patch itself say that they are removing "embedsp".
Is that correct?

Also, please add some commentary to the patch explaining why simply
adding embedsp{u} to FILES isn't the right thing to do.

> +do_install_append_class-target () {
> +        # we dont really care about embedsp for ppc so remove it
> +        rm -f ${D}/${bindir}/embedsp || :
> +}
> +

"rm -f" already ignores nonexistent files so I don't think that the
"|| :" construct is buying anything.

p.

Patch

diff --git a/meta/recipes-devtools/binutils/binutils_2.23.2.bb b/meta/recipes-devtools/binutils/binutils_2.23.2.bb
index 1523e87..faeba20 100644
--- a/meta/recipes-devtools/binutils/binutils_2.23.2.bb
+++ b/meta/recipes-devtools/binutils/binutils_2.23.2.bb
@@ -10,6 +10,12 @@  EXTRA_OECONF += "--with-sysroot=/ \
 
 EXTRA_OECONF_class-native = "--enable-targets=all --enable-64-bit-bfd --enable-install-libbfd"
 
+do_install_append_class-target () {
+        # we dont really care about embedsp for ppc so remove it
+        rm -f ${D}/${bindir}/embedsp || :
+}
+
+
 do_install_class-native () {
 	autotools_do_install