Patchwork [meta-networking] crda: correct QA issues with sbindir

login
register
mail settings
Submitter Joe MacDonald
Date Nov. 6, 2013, 3:42 p.m.
Message ID <1383752555-25620-1-git-send-email-joe@deserted.net>
Download mbox | patch
Permalink /patch/61201/
State Accepted, archived
Headers show

Comments

Joe MacDonald - Nov. 6, 2013, 3:42 p.m.
regdbdump and crda are installed in /sbin/ and still link against stuff in
/usr/lib, causing QA warnings / errors:

   WARNING: QA Issue: crda: /sbin/regdbdump, installed in the base_prefix, requires a shared library under exec_prefix (/usr): libgcrypt.so.11 => /usr/lib64/libgcrypt.so.11 (0x00000000dead1000)
   WARNING: QA Issue: crda: /sbin/regdbdump, installed in the base_prefix, requires a shared library under exec_prefix (/usr): libgpg-error.so.0 => /usr/lib64/libgpg-error.so.0 (0x00000000dead3000)
   WARNING: QA Issue: crda: /sbin/crda, installed in the base_prefix, requires a shared library under exec_prefix (/usr): libgcrypt.so.11 => /usr/lib64/libgcrypt.so.11 (0x00000000dead1000)
   WARNING: QA Issue: crda: /sbin/crda, installed in the base_prefix, requires a shared library under exec_prefix (/usr): libnl-genl-3.so.200 => /usr/lib64/libnl-genl-3.so.200 (0x00000000dead2000)
   WARNING: QA Issue: crda: /sbin/crda, installed in the base_prefix, requires a shared library under exec_prefix (/usr): libnl-3.so.200 => /usr/lib64/libnl-3.so.200 (0x00000000dead3000)
   WARNING: QA Issue: crda: /sbin/crda, installed in the base_prefix, requires a shared library under exec_prefix (/usr): libnl-nf-3.so.200 => /usr/lib64/libnl-nf-3.so.200 (0x00000000dead4000)
   WARNING: QA Issue: crda: /sbin/crda, installed in the base_prefix, requires a shared library under exec_prefix (/usr): libnl-route-3.so.200 => /usr/lib64/libnl-route-3.so.200 (0x00000000dead5000)
   WARNING: QA Issue: crda: /sbin/crda, installed in the base_prefix, requires a shared library under exec_prefix (/usr): libgpg-error.so.0 => /usr/lib64/libgpg-error.so.0 (0x00000000dead7000)

relocate them to /usr/sbin to squelch the warning.

Signed-off-by: Joe MacDonald <joe@deserted.net>
---

The other obvious solution would be to mve these libraries into ${base_libdir}
but that really doesn't seem appropriate in this case.

 meta-networking/recipes-connectivity/crda/crda_1.1.3.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb b/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
index 3ef9210..8339893 100644
--- a/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
+++ b/meta-networking/recipes-connectivity/crda/crda_1.1.3.bb
@@ -24,7 +24,7 @@  do_compile() {
 }
 
 do_install() {
-    oe_runmake install
+    oe_runmake SBINDIR=${sbindir} install
 
     install -d ${D}${libdir}/crda/