Patchwork [0/1] linux-yocto/3.10: fix qemuarm boot and spurious mips build warning

login
register
mail settings
Submitter Bruce Ashfield
Date Nov. 5, 2013, 6:47 p.m.
Message ID <cover.1383677174.git.bruce.ashfield@windriver.com>
Download mbox
Permalink /patch/61167/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib zedd/kernel

Comments

Bruce Ashfield - Nov. 5, 2013, 6:47 p.m.
Richard/Saul,

I don't have anything extra to add outside of what I put in the
patch commit log .. so here it is:

-------------------------------------------

This update fixes two issues:

a) qemuarm boot failure

v3.10.13 picked up a patch for arm versatile interrupt mappings that fixes
the emulator boot out of the box. But it interacts badly with our previous
fix for the issue. Reverting the existing patch and going with the mainline
solution fixes the boot.

b) qemumips build warning and failure

Depending on the build host and compiler, the build of menuconfig throws
an potentially uninitialized variable warning. That warning causes an
error on archs with -Werror. We can do a trivial change to avoid the
warning all together (initilize it to null), and keep everyone happy.

[YOCTO #5460]

-------------------------------------------

Cheers,

Bruce

The following changes since commit 57498cede4696526c121e0112b5dea3e6e8365ac:

  bitbake: toaster: fix target package information (2013-11-05 12:50:44 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib zedd/kernel
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel

Bruce Ashfield (1):
  linux-yocto/3.10: fix qemuarm boot and spurious mips build warning

 meta/recipes-kernel/linux/linux-yocto-rt_3.10.bb   |  4 ++--
 meta/recipes-kernel/linux/linux-yocto-tiny_3.10.bb |  2 +-
 meta/recipes-kernel/linux/linux-yocto_3.10.bb      | 14 +++++++-------
 3 files changed, 10 insertions(+), 10 deletions(-)
Phil Blundell - Nov. 5, 2013, 8:56 p.m.
On Tue, 2013-11-05 at 13:47 -0500, Bruce Ashfield wrote:
> I don't have anything extra to add outside of what I put in the
> patch commit log ..

That's certainly a good thing and to be applauded, but in this situation
maybe you could consider just sending the patch without a cover letter.

p.
Bruce Ashfield - Nov. 6, 2013, 3:21 a.m.
On Tue, Nov 5, 2013 at 3:56 PM, Phil Blundell <pb@pbcl.net> wrote:
> On Tue, 2013-11-05 at 13:47 -0500, Bruce Ashfield wrote:
>> I don't have anything extra to add outside of what I put in the
>> patch commit log ..
>
> That's certainly a good thing and to be applauded, but in this situation
> maybe you could consider just sending the patch without a cover letter.
>

I honestly dislike lone patches in nearly every situation. So let's
just say that
opinions differ and leave it at that.

Cheers,

Bruce

> p.
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Darren Hart - Nov. 7, 2013, 6:39 p.m.
On Tue, 2013-11-05 at 22:21 -0500, Bruce Ashfield wrote:
> On Tue, Nov 5, 2013 at 3:56 PM, Phil Blundell <pb@pbcl.net> wrote:
> > On Tue, 2013-11-05 at 13:47 -0500, Bruce Ashfield wrote:
> >> I don't have anything extra to add outside of what I put in the
> >> patch commit log ..
> >
> > That's certainly a good thing and to be applauded, but in this situation
> > maybe you could consider just sending the patch without a cover letter.
> >
> 
> I honestly dislike lone patches in nearly every situation. So let's
> just say that
> opinions differ and leave it at that.

For anything other than single patches (which I understand this is)
there is a preference for using the create-pull-request and
send-pull-request tools which ensure the patches are available via a git
pull from a public repository and also apply a cover letter. Often times
I leave the cover letter blank for the same reason Bruce has stated
here, and I think that's a reasonable approach, especially for a short
or an eclectic set of changes.