Patchwork [v2] package.bbclass: Fix split_and_strip_files when file has single quote (')

login
register
mail settings
Submitter eu@felipetonello.com
Date Nov. 1, 2013, 3:51 a.m.
Message ID <1383277911-8416-1-git-send-email-eu@felipetonello.com>
Download mbox | patch
Permalink /patch/60925/
State Accepted
Commit 8f84cc99bd1ea946317c87f00ea343b80d9c9a4d
Headers show

Comments

eu@felipetonello.com - Nov. 1, 2013, 3:51 a.m.
From: "Felipe F. Tonello" <eu@felipetonello.com>

Fix false error report when a file that has a single quote by escaping
the single quote. Some packages might install files with quotes, such
as music files and other types, that will cause the problem.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 meta/classes/package.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index b0f44c7..48bb982 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -747,7 +747,7 @@  python split_and_strip_files () {
     # 16 - kernel module
     def isELF(path):
         type = 0
-        ret, result = oe.utils.getstatusoutput("file '%s'" % path)
+        ret, result = oe.utils.getstatusoutput("file \"%s\"" % path.replace("\"", "\\\""))
 
         if ret:
             msg = "split_and_strip_files: 'file %s' failed" % path