Patchwork runtime package management: ipk/opk

login
register
mail settings
Submitter Trevor Woerner
Date Oct. 31, 2013, 4:45 p.m.
Message ID <1383237932-13177-1-git-send-email-trevor.woerner@linaro.org>
Download mbox | patch
Permalink /patch/60909/
State New
Headers show

Comments

Trevor Woerner - Oct. 31, 2013, 4:45 p.m.
Place the on-target feed configuration into the "base-feeds.conf" file instead
of the "opkg.conf" file.

Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org>
---
 meta/classes/rootfs_ipk.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - Nov. 1, 2013, 7:35 p.m.
On 10/31/2013 09:45 AM, Trevor Woerner wrote:
> Place the on-target feed configuration into the "base-feeds.conf" file instead
> of the "opkg.conf" file.
>
This says what you are doing, but the question is why is the change 
needed?  It might be obvious to you, but not to others.  The 
base-feeds.conf file is provided via the a distro configuration, so it's 
not guarenteed to be there for every distro, so I am not sure this 
change is correct.

Also for future referece the commit message should follow the commit 
guidelines:

http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Thanks

Sau!

> Signed-off-by: Trevor Woerner <trevor.woerner@linaro.org>
> ---
>   meta/classes/rootfs_ipk.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
> index b0805dc..1537af4 100644
> --- a/meta/classes/rootfs_ipk.bbclass
> +++ b/meta/classes/rootfs_ipk.bbclass
> @@ -159,7 +159,7 @@ ipk_insert_feed_uris () {
>   		echo "Added $feed_name feed with URL $feed_uri"
>
>   		# insert new feed-sources
> -		echo "src/gz $feed_name $feed_uri" >> ${IPKGCONF_TARGET}
> +		echo "src/gz $feed_name $feed_uri" >> ${IMAGE_ROOTFS}/${sysconfdir}/opkg/base-feeds.conf
>   	done
>
>   	# Allow to use package deploy directory contents as quick devel-testing
>
Trevor Woerner - Nov. 2, 2013, 5:38 p.m.
Hi Saul,

On 1 November 2013 12:35, Saul Wold <sgw@linux.intel.com> wrote:
> This says what you are doing, but the question is why is the change needed?
> It might be obvious to you, but not to others.  The base-feeds.conf file is
> provided via the a distro configuration, so it's not guarenteed to be there
> for every distro, so I am not sure this change is correct.
>
> Also for future referece the commit message should follow the commit
> guidelines:

You're right, this patch is messed up.

Thank you for the feedback :-)

Patch

diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
index b0805dc..1537af4 100644
--- a/meta/classes/rootfs_ipk.bbclass
+++ b/meta/classes/rootfs_ipk.bbclass
@@ -159,7 +159,7 @@  ipk_insert_feed_uris () {
 		echo "Added $feed_name feed with URL $feed_uri"
 
 		# insert new feed-sources
-		echo "src/gz $feed_name $feed_uri" >> ${IPKGCONF_TARGET}
+		echo "src/gz $feed_name $feed_uri" >> ${IMAGE_ROOTFS}/${sysconfdir}/opkg/base-feeds.conf
 	done
 
 	# Allow to use package deploy directory contents as quick devel-testing