Patchwork [meta-networking,1/5] cyrus-sasl: remove the unnecessary pkg_postinst

login
register
mail settings
Submitter Qi.Chen@windriver.com
Date Oct. 31, 2013, 6:29 a.m.
Message ID <1383200986-18674-1-git-send-email-Qi.Chen@windriver.com>
Download mbox | patch
Permalink /patch/60855/
State Accepted, archived
Commit d65d7bd079601033b97dc31a1a7710f9bf2f2b25
Headers show

Comments

Qi.Chen@windriver.com - Oct. 31, 2013, 6:29 a.m.
From: Chen Qi <Qi.Chen@windriver.com>

saslpasswd2 is used by an administrator to set a user's sasl password,
setting a default one in pkg_postinst in not only unnecessary but also
inappropriate.

Besides, running saslpasswd2 takes a significant amount of time to finish,
so this pkg_postinst will make the first boot take longer time.

According to the above two reasons, the patch remove the pkg_postint.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 .../cyrus-sasl/cyrus-sasl_2.1.26.bb                |    5 -----
 1 file changed, 5 deletions(-)
Joe MacDonald - Nov. 1, 2013, 2:27 p.m.
Merged this set.  Thanks.
-J.

[[oe][meta-networking][PATCH 1/5] cyrus-sasl: remove the unnecessary pkg_postinst] On 13.10.31 (Thu 14:29) Qi.Chen@windriver.com wrote:

> From: Chen Qi <Qi.Chen@windriver.com>
> 
> saslpasswd2 is used by an administrator to set a user's sasl password,
> setting a default one in pkg_postinst in not only unnecessary but also
> inappropriate.
> 
> Besides, running saslpasswd2 takes a significant amount of time to finish,
> so this pkg_postinst will make the first boot take longer time.
> 
> According to the above two reasons, the patch remove the pkg_postint.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  .../cyrus-sasl/cyrus-sasl_2.1.26.bb                |    5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/meta-networking/recipes-daemons/cyrus-sasl/cyrus-sasl_2.1.26.bb b/meta-networking/recipes-daemons/cyrus-sasl/cyrus-sasl_2.1.26.bb
> index f05ab85..b4e9190 100644
> --- a/meta-networking/recipes-daemons/cyrus-sasl/cyrus-sasl_2.1.26.bb
> +++ b/meta-networking/recipes-daemons/cyrus-sasl/cyrus-sasl_2.1.26.bb
> @@ -54,11 +54,6 @@ USERADD_PACKAGES = "${PN}-bin"
>  GROUPADD_PARAM_${PN}-bin = "--system mail"
>  USERADD_PARAM_${PN}-bin = "--system --home=/var/spool/mail -g mail cyrus"
>  
> -pkg_postinst_${PN}-bin () {
> -    echo "cyrus" | saslpasswd2 -p -c cyrus
> -    chgrp mail /etc/sasldb2
> -}
> -
>  SRC_URI[md5sum] = "a7f4e5e559a0e37b3ffc438c9456e425"
>  SRC_URI[sha256sum] = "8fbc5136512b59bb793657f36fadda6359cae3b08f01fd16b3d406f1345b7bc3"
>

Patch

diff --git a/meta-networking/recipes-daemons/cyrus-sasl/cyrus-sasl_2.1.26.bb b/meta-networking/recipes-daemons/cyrus-sasl/cyrus-sasl_2.1.26.bb
index f05ab85..b4e9190 100644
--- a/meta-networking/recipes-daemons/cyrus-sasl/cyrus-sasl_2.1.26.bb
+++ b/meta-networking/recipes-daemons/cyrus-sasl/cyrus-sasl_2.1.26.bb
@@ -54,11 +54,6 @@  USERADD_PACKAGES = "${PN}-bin"
 GROUPADD_PARAM_${PN}-bin = "--system mail"
 USERADD_PARAM_${PN}-bin = "--system --home=/var/spool/mail -g mail cyrus"
 
-pkg_postinst_${PN}-bin () {
-    echo "cyrus" | saslpasswd2 -p -c cyrus
-    chgrp mail /etc/sasldb2
-}
-
 SRC_URI[md5sum] = "a7f4e5e559a0e37b3ffc438c9456e425"
 SRC_URI[sha256sum] = "8fbc5136512b59bb793657f36fadda6359cae3b08f01fd16b3d406f1345b7bc3"