Patchwork udev: fix typo in local.rules

login
register
mail settings
Submitter Saul Wold
Date Oct. 30, 2013, 10:39 p.m.
Message ID <1383172767-11006-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/60835/
State New
Headers show

Comments

Saul Wold - Oct. 30, 2013, 10:39 p.m.
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/udev/udev/local.rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Khem Raj - Oct. 30, 2013, 11:53 p.m.
On Wed, Oct 30, 2013 at 3:39 PM, Saul Wold <sgw@linux.intel.com> wrote:
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/recipes-core/udev/udev/local.rules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/udev/udev/local.rules b/meta/recipes-core/udev/udev/local.rules
> index f06002c..59836a4 100644
> --- a/meta/recipes-core/udev/udev/local.rules
> +++ b/meta/recipes-core/udev/udev/local.rules
> @@ -19,4 +19,4 @@ ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe
>  # Create a symlink to any touchscreen input device
>  # Trigger based on input type, that the evbit (-e) has EV_SYN and EV_ABS,
>  # has an EV_ABS value (-a) which is used for touchscreen type devices.
> -+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"
> ++SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK=="input/touchscreen0"

+= is perfectly fine for SYMLINK contruct. Why is it a typo ?

> --
> 1.8.3.1
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Saul Wold - Oct. 31, 2013, midnight
On 10/30/2013 04:53 PM, Khem Raj wrote:
> On Wed, Oct 30, 2013 at 3:39 PM, Saul Wold <sgw@linux.intel.com> wrote:
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>>   meta/recipes-core/udev/udev/local.rules | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/udev/udev/local.rules b/meta/recipes-core/udev/udev/local.rules
>> index f06002c..59836a4 100644
>> --- a/meta/recipes-core/udev/udev/local.rules
>> +++ b/meta/recipes-core/udev/udev/local.rules
>> @@ -19,4 +19,4 @@ ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe
>>   # Create a symlink to any touchscreen input device
>>   # Trigger based on input type, that the evbit (-e) has EV_SYN and EV_ABS,
>>   # has an EV_ABS value (-a) which is used for touchscreen type devices.
>> -+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"
>> ++SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK=="input/touchscreen0"
>
^^^^ and extra + there was my real typo!

> += is perfectly fine for SYMLINK contruct. Why is it a typo ?
>
Gah, I fixed the wrong typo

Sau!
>> --
>> 1.8.3.1
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

Patch

diff --git a/meta/recipes-core/udev/udev/local.rules b/meta/recipes-core/udev/udev/local.rules
index f06002c..59836a4 100644
--- a/meta/recipes-core/udev/udev/local.rules
+++ b/meta/recipes-core/udev/udev/local.rules
@@ -19,4 +19,4 @@  ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe
 # Create a symlink to any touchscreen input device
 # Trigger based on input type, that the evbit (-e) has EV_SYN and EV_ABS,
 # has an EV_ABS value (-a) which is used for touchscreen type devices.
-+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"
++SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK=="input/touchscreen0"