Patchwork [v2] core-image-basic.bb: Allow user extensions

login
register
mail settings
Submitter Gary Thomas
Date Oct. 30, 2013, 4:09 p.m.
Message ID <1383149365-30556-1-git-send-email-gary@mlbassoc.com>
Download mbox | patch
Permalink /patch/60797/
State New
Headers show

Comments

Gary Thomas - Oct. 30, 2013, 4:09 p.m.
Allow the user to provide additional packages to this image.
This lets core-image-basic behave like all other core-image*
recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
as match the documentation which suggests this as the mode to
extend any core-image* image.

v2 - drop redundant setting of CORE_IMAGE_EXTRA_INSTALL

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 meta/recipes-extended/images/core-image-basic.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Gary Thomas - Dec. 4, 2013, 12:29 p.m.
On 2013-10-30 10:09, Gary Thomas wrote:
> Allow the user to provide additional packages to this image.
> This lets core-image-basic behave like all other core-image*
> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
> as match the documentation which suggests this as the mode to
> extend any core-image* image.
>
> v2 - drop redundant setting of CORE_IMAGE_EXTRA_INSTALL
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
>   meta/recipes-extended/images/core-image-basic.bb |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-extended/images/core-image-basic.bb b/meta/recipes-extended/images/core-image-basic.bb
> index 091f57d..d599e72 100644
> --- a/meta/recipes-extended/images/core-image-basic.bb
> +++ b/meta/recipes-extended/images/core-image-basic.bb
> @@ -6,6 +6,7 @@ IMAGE_FEATURES += "splash ssh-server-openssh"
>   IMAGE_INSTALL = "\
>       packagegroup-core-boot \
>       packagegroup-core-basic \
> +    ${CORE_IMAGE_EXTRA_INSTALL} \
>       "
>
>   inherit core-image
>

Ping?  I know this message made it to the list, just no action.
Paul Eggleton - Dec. 4, 2013, 12:42 p.m.
Hi Gary,

On Wednesday 04 December 2013 05:29:28 Gary Thomas wrote:
> On 2013-10-30 10:09, Gary Thomas wrote:
> > Allow the user to provide additional packages to this image.
> > This lets core-image-basic behave like all other core-image*
> > recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
> > as match the documentation which suggests this as the mode to
> > extend any core-image* image.
>...
> 
> Ping?  I know this message made it to the list, just no action.

It was merged some time ago:

http://cgit.openembedded.org/openembedded-core/commit/?id=5faabf398819d40b55c46bc83ae03942d115024b

Cheers,
Paul

Patch

diff --git a/meta/recipes-extended/images/core-image-basic.bb b/meta/recipes-extended/images/core-image-basic.bb
index 091f57d..d599e72 100644
--- a/meta/recipes-extended/images/core-image-basic.bb
+++ b/meta/recipes-extended/images/core-image-basic.bb
@@ -6,6 +6,7 @@  IMAGE_FEATURES += "splash ssh-server-openssh"
 IMAGE_INSTALL = "\
     packagegroup-core-boot \
     packagegroup-core-basic \
+    ${CORE_IMAGE_EXTRA_INSTALL} \
     "
 
 inherit core-image