Patchwork core-image-basic.bb: Allow user extensions

login
register
mail settings
Submitter Gary Thomas
Date Oct. 30, 2013, 2:22 p.m.
Message ID <5271162B.6020008@mlbassoc.com>
Download mbox | patch
Permalink /patch/60771/
State New
Headers show

Comments

Gary Thomas - Oct. 30, 2013, 2:22 p.m.
Allow the user to provide additional packages to this image.
This lets core-image-basic behave like all other core-image*
recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
as match the documentation which suggests this as the mode to
extend any core-image* image.

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
  meta/recipes-extended/images/core-image-basic.bb |    3 +++
  1 file changed, 3 insertions(+)

Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Paul Eggleton - Oct. 30, 2013, 2:47 p.m.
Hi Gary,

On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
> Allow the user to provide additional packages to this image.
> This lets core-image-basic behave like all other core-image*
> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
> as match the documentation which suggests this as the mode to
> extend any core-image* image.
> 
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
>   meta/recipes-extended/images/core-image-basic.bb |    3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-extended/images/core-image-basic.bb
> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
> 100644
> --- a/meta/recipes-extended/images/core-image-basic.bb
> +++ b/meta/recipes-extended/images/core-image-basic.bb
> @@ -3,9 +3,12 @@ functionality installed."
>    IMAGE_FEATURES += "splash ssh-server-openssh"
>   +CORE_IMAGE_EXTRA_INSTALL ?= ""
> +

Not sure if it's my mail client but the above looks slightly mangled; in any 
case the above addition shouldn't be needed because core-image.bbclass already 
does this.

>   IMAGE_INSTALL = "\
>       packagegroup-core-boot \
>       packagegroup-core-basic \
> +    ${CORE_IMAGE_EXTRA_INSTALL} \
>       "
>    inherit core-image

Good catch on this one though.

Cheers,
Paul
Gary Thomas - Oct. 30, 2013, 2:55 p.m.
On 2013-10-30 08:47, Paul Eggleton wrote:
> Hi Gary,
>
> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
>> Allow the user to provide additional packages to this image.
>> This lets core-image-basic behave like all other core-image*
>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
>> as match the documentation which suggests this as the mode to
>> extend any core-image* image.
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>> ---
>>    meta/recipes-extended/images/core-image-basic.bb |    3 +++
>>    1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/recipes-extended/images/core-image-basic.bb
>> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
>> 100644
>> --- a/meta/recipes-extended/images/core-image-basic.bb
>> +++ b/meta/recipes-extended/images/core-image-basic.bb
>> @@ -3,9 +3,12 @@ functionality installed."
>>     IMAGE_FEATURES += "splash ssh-server-openssh"
>>    +CORE_IMAGE_EXTRA_INSTALL ?= ""
>> +
>
> Not sure if it's my mail client but the above looks slightly mangled; in any
> case the above addition shouldn't be needed because core-image.bbclass already
> does this.

Are you sure it counts?  core-image.bbclass is included after this would be evaluated,
or does that not matter?

>
>>    IMAGE_INSTALL = "\
>>        packagegroup-core-boot \
>>        packagegroup-core-basic \
>> +    ${CORE_IMAGE_EXTRA_INSTALL} \
>>        "
>>     inherit core-image
>
> Good catch on this one though.
>
> Cheers,
> Paul
>
Paul Eggleton - Oct. 30, 2013, 3:33 p.m.
On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
> On 2013-10-30 08:47, Paul Eggleton wrote:
> > On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
> >> Allow the user to provide additional packages to this image.
> >> This lets core-image-basic behave like all other core-image*
> >> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
> >> as match the documentation which suggests this as the mode to
> >> extend any core-image* image.
> >> 
> >> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> >> ---
> >> 
> >>    meta/recipes-extended/images/core-image-basic.bb |    3 +++
> >>    1 file changed, 3 insertions(+)
> >> 
> >> diff --git a/meta/recipes-extended/images/core-image-basic.bb
> >> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
> >> 100644
> >> --- a/meta/recipes-extended/images/core-image-basic.bb
> >> +++ b/meta/recipes-extended/images/core-image-basic.bb
> >> @@ -3,9 +3,12 @@ functionality installed."
> >> 
> >>     IMAGE_FEATURES += "splash ssh-server-openssh"
> >>    
> >>    +CORE_IMAGE_EXTRA_INSTALL ?= ""
> >> 
> >> +
> > 
> > Not sure if it's my mail client but the above looks slightly mangled; in
> > any case the above addition shouldn't be needed because
> > core-image.bbclass already does this.
> 
> Are you sure it counts?  core-image.bbclass is included after this would be
> evaluated, or does that not matter?

It doesn't matter in most cases, because the value won't actually be expanded 
until later. Values aren't expanded unless you use immediate expansion (the := 
operator) or you d.getVar("SOMEVAR", True) is called from python code to 
return the expanded value.

Cheers,
Paul
Gary Thomas - Oct. 30, 2013, 3:40 p.m.
On 2013-10-30 09:33, Paul Eggleton wrote:
> On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
>> On 2013-10-30 08:47, Paul Eggleton wrote:
>>> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
>>>> Allow the user to provide additional packages to this image.
>>>> This lets core-image-basic behave like all other core-image*
>>>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
>>>> as match the documentation which suggests this as the mode to
>>>> extend any core-image* image.
>>>>
>>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>>>> ---
>>>>
>>>>     meta/recipes-extended/images/core-image-basic.bb |    3 +++
>>>>     1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/meta/recipes-extended/images/core-image-basic.bb
>>>> b/meta/recipes-extended/images/core-image-basic.bb index 091f57d..e393a28
>>>> 100644
>>>> --- a/meta/recipes-extended/images/core-image-basic.bb
>>>> +++ b/meta/recipes-extended/images/core-image-basic.bb
>>>> @@ -3,9 +3,12 @@ functionality installed."
>>>>
>>>>      IMAGE_FEATURES += "splash ssh-server-openssh"
>>>>
>>>>     +CORE_IMAGE_EXTRA_INSTALL ?= ""
>>>>
>>>> +
>>>
>>> Not sure if it's my mail client but the above looks slightly mangled; in
>>> any case the above addition shouldn't be needed because
>>> core-image.bbclass already does this.
>>
>> Are you sure it counts?  core-image.bbclass is included after this would be
>> evaluated, or does that not matter?
>
> It doesn't matter in most cases, because the value won't actually be expanded
> until later. Values aren't expanded unless you use immediate expansion (the :=
> operator) or you d.getVar("SOMEVAR", True) is called from python code to
> return the expanded value.

Understood, thanks.

Should I send another patch with that line removed?
Paul Eggleton - Oct. 30, 2013, 3:42 p.m.
On Wednesday 30 October 2013 09:40:09 Gary Thomas wrote:
> On 2013-10-30 09:33, Paul Eggleton wrote:
> > On Wednesday 30 October 2013 08:55:09 Gary Thomas wrote:
> >> On 2013-10-30 08:47, Paul Eggleton wrote:
> >>> On Wednesday 30 October 2013 08:22:35 Gary Thomas wrote:
> >>>> Allow the user to provide additional packages to this image.
> >>>> This lets core-image-basic behave like all other core-image*
> >>>> recipes (which do support CORE_IMAGE_EXTRA_INSTALL), as well
> >>>> as match the documentation which suggests this as the mode to
> >>>> extend any core-image* image.
> >>>> 
> >>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> >>>> ---
> >>>> 
> >>>>     meta/recipes-extended/images/core-image-basic.bb |    3 +++
> >>>>     1 file changed, 3 insertions(+)
> >>>> 
> >>>> diff --git a/meta/recipes-extended/images/core-image-basic.bb
> >>>> b/meta/recipes-extended/images/core-image-basic.bb index
> >>>> 091f57d..e393a28
> >>>> 100644
> >>>> --- a/meta/recipes-extended/images/core-image-basic.bb
> >>>> +++ b/meta/recipes-extended/images/core-image-basic.bb
> >>>> @@ -3,9 +3,12 @@ functionality installed."
> >>>> 
> >>>>      IMAGE_FEATURES += "splash ssh-server-openssh"
> >>>>     
> >>>>     +CORE_IMAGE_EXTRA_INSTALL ?= ""
> >>>> 
> >>>> +
> >>> 
> >>> Not sure if it's my mail client but the above looks slightly mangled; in
> >>> any case the above addition shouldn't be needed because
> >>> core-image.bbclass already does this.
> >> 
> >> Are you sure it counts?  core-image.bbclass is included after this would
> >> be evaluated, or does that not matter?
> > 
> > It doesn't matter in most cases, because the value won't actually be
> > expanded until later. Values aren't expanded unless you use immediate
> > expansion (the := operator) or you d.getVar("SOMEVAR", True) is called
> > from python code to return the expanded value.
> 
> Understood, thanks.
> 
> Should I send another patch with that line removed?

Yes please.

Cheers,
Paul

Patch

diff --git a/meta/recipes-extended/images/core-image-basic.bb b/meta/recipes-extended/images/core-image-basic.bb
index 091f57d..e393a28 100644
--- a/meta/recipes-extended/images/core-image-basic.bb
+++ b/meta/recipes-extended/images/core-image-basic.bb
@@ -3,9 +3,12 @@  functionality installed."
   IMAGE_FEATURES += "splash ssh-server-openssh"
  +CORE_IMAGE_EXTRA_INSTALL ?= ""
+
  IMAGE_INSTALL = "\
      packagegroup-core-boot \
      packagegroup-core-basic \
+    ${CORE_IMAGE_EXTRA_INSTALL} \
      "
   inherit core-image
-- 
1.7.9.5

_______________________________________________