Patchwork [5/5] libgcrypt: remove --without-pth

login
register
mail settings
Submitter Ross Burton
Date Oct. 28, 2013, 2:33 p.m.
Message ID <1382970798-13574-5-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/60567/
State Accepted
Commit 97dd981fca455ef784c51fa040049b7910a7d890
Headers show

Comments

Ross Burton - Oct. 28, 2013, 2:33 p.m.
This isn't recognised by configure, and the random number daemon that requires
Pth isn't enabled.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-support/libgcrypt/libgcrypt.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Khem Raj - Oct. 31, 2013, 3:44 a.m.
On Mon, Oct 28, 2013 at 7:33 AM, Ross Burton <ross.burton@intel.com> wrote:
> This isn't recognised by configure, and the random number daemon that requires
> Pth isn't enabled.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-support/libgcrypt/libgcrypt.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/libgcrypt/libgcrypt.inc b/meta/recipes-support/libgcrypt/libgcrypt.inc
> index 6a0e0cf..e0dfec2 100644
> --- a/meta/recipes-support/libgcrypt/libgcrypt.inc
> +++ b/meta/recipes-support/libgcrypt/libgcrypt.inc
> @@ -15,7 +15,7 @@ SRC_URI = "ftp://ftp.gnupg.org/gcrypt/libgcrypt/libgcrypt-${PV}.tar.gz \
>
>  inherit autotools binconfig pkgconfig
>
> -EXTRA_OECONF = "--without-pth --disable-asm --with-capabilities"
> +EXTRA_OECONF = "--disable-asm --with-capabilities"

should it now depend on pth as well for deterministic builds.

>
>  # libgcrypt.pc is added locally and thus installed here
>  do_install_append() {
> --
> 1.7.10.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton - Nov. 5, 2013, 1:29 p.m.
On 31 October 2013 03:44, Khem Raj <raj.khem@gmail.com> wrote:
> should it now depend on pth as well for deterministic builds.

No, because the random daemon (the only piece that needs Pth) is
disabled by default.

Ross

Patch

diff --git a/meta/recipes-support/libgcrypt/libgcrypt.inc b/meta/recipes-support/libgcrypt/libgcrypt.inc
index 6a0e0cf..e0dfec2 100644
--- a/meta/recipes-support/libgcrypt/libgcrypt.inc
+++ b/meta/recipes-support/libgcrypt/libgcrypt.inc
@@ -15,7 +15,7 @@  SRC_URI = "ftp://ftp.gnupg.org/gcrypt/libgcrypt/libgcrypt-${PV}.tar.gz \
 
 inherit autotools binconfig pkgconfig
 
-EXTRA_OECONF = "--without-pth --disable-asm --with-capabilities"
+EXTRA_OECONF = "--disable-asm --with-capabilities"
 
 # libgcrypt.pc is added locally and thus installed here
 do_install_append() {