Patchwork [1/5] gnome: set UNKNOWN_CONFIGURE_WHITELIST

login
register
mail settings
Submitter Ross Burton
Date Oct. 28, 2013, 2:33 p.m.
Message ID <1382970798-13574-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/60559/
State Accepted
Commit 3ccc65f6ee50029bcac709527f5eec18229c7a98
Headers show

Comments

Ross Burton - Oct. 28, 2013, 2:33 p.m.
This class passes --disable-introspection to everything that inherits it but not
all GNOME modules support introspection, so add that option to the
unknown-configure-options sanity test whitelist.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/classes/gnome.bbclass |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Otavio Salvador - Oct. 28, 2013, 3:59 p.m.
On Mon, Oct 28, 2013 at 12:33 PM, Ross Burton <ross.burton@intel.com> wrote:
> This class passes --disable-introspection to everything that inherits it but not
> all GNOME modules support introspection, so add that option to the
> unknown-configure-options sanity test whitelist.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>

I understand the change but it does not match with the commit log.
Ross Burton - Oct. 28, 2013, 5:08 p.m.
On 28 October 2013 15:59, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Mon, Oct 28, 2013 at 12:33 PM, Ross Burton <ross.burton@intel.com> wrote:
>> This class passes --disable-introspection to everything that inherits it but not
>> all GNOME modules support introspection, so add that option to the
>> unknown-configure-options sanity test whitelist.
>>
>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>
> I understand the change but it does not match with the commit log.

How so?

-EXTRA_OECONF += "--enable-introspection=no"
+EXTRA_OECONF += "--disable-introspection"

This is a semantically identical change as far as autoconf is
concerned, that makes the whitelist clearer.

+UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"

This is the unknown configure options whitelist.

Ross
Otavio Salvador - Oct. 28, 2013, 5:12 p.m.
On Mon, Oct 28, 2013 at 3:08 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 28 October 2013 15:59, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> On Mon, Oct 28, 2013 at 12:33 PM, Ross Burton <ross.burton@intel.com> wrote:
>>> This class passes --disable-introspection to everything that inherits it but not
>>> all GNOME modules support introspection, so add that option to the
>>> unknown-configure-options sanity test whitelist.
>>>
>>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>>
>> I understand the change but it does not match with the commit log.
>
> How so?
>
> -EXTRA_OECONF += "--enable-introspection=no"
> +EXTRA_OECONF += "--disable-introspection"
>
> This is a semantically identical change as far as autoconf is
> concerned, that makes the whitelist clearer.

For autoconf it is but for a human it is not. Please add this to the commit log.

> +UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"
>
> This is the unknown configure options whitelist.
>
> Ross

Patch

diff --git a/meta/classes/gnome.bbclass b/meta/classes/gnome.bbclass
index a19dd17..0de22dd 100644
--- a/meta/classes/gnome.bbclass
+++ b/meta/classes/gnome.bbclass
@@ -1,3 +1,5 @@ 
 inherit gnomebase gtk-icon-cache gconf mime
 
-EXTRA_OECONF += "--enable-introspection=no"
+EXTRA_OECONF += "--disable-introspection"
+
+UNKNOWN_CONFIGURE_WHITELIST += "--disable-introspection"