Patchwork [meta-fsl-demos] packagegroup-fsl: Make v4l-utils conditional on X11

login
register
mail settings
Submitter Eric Nelson
Date Oct. 27, 2013, 4:36 p.m.
Message ID <1382891764-25102-1-git-send-email-eric.nelson@boundarydevices.com>
Download mbox | patch
Permalink /patch/60531/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Eric Nelson - Oct. 27, 2013, 4:36 p.m.
v4l-utils will pull in X11 if included, and this patch
allows it to be skipped.

Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 recipes-fsl/packagegroup/packagegroup-fsl.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Philip Craig - Oct. 28, 2013, 12:14 a.m.
On Mon, Oct 28, 2013 at 2:36 AM, Eric Nelson
<eric.nelson@boundarydevices.com> wrote:
> v4l-utils will pull in X11 if included, and this patch
> allows it to be skipped.

While this is okay as a temporary fix, it would be better if we
patched v4l-utils to not depend on X11 instead. The difficulty with
that approach is that I don't think the v4l-utils configure script has
an option to disable X11.

>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>  recipes-fsl/packagegroup/packagegroup-fsl.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-fsl/packagegroup/packagegroup-fsl.bb b/recipes-fsl/packagegroup/packagegroup-fsl.bb
> index da931d6..80ce5a4 100644
> --- a/recipes-fsl/packagegroup/packagegroup-fsl.bb
> +++ b/recipes-fsl/packagegroup/packagegroup-fsl.bb
> @@ -62,7 +62,7 @@ RDEPENDS_${PN}-tools-testapps = " \
>      python-subprocess \
>      python-datetime \
>      python-json \
> -    v4l-utils \
> +    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
>      ethtool \
>      mtd-utils \
>      mtd-utils-ubifs \
> --
> 1.8.1.2
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
Eric Nelson - Oct. 28, 2013, 2:57 a.m.
Hi Philip,

On 10/27/2013 05:14 PM, Philip Craig wrote:
> On Mon, Oct 28, 2013 at 2:36 AM, Eric Nelson
> <eric.nelson@boundarydevices.com> wrote:
>> v4l-utils will pull in X11 if included, and this patch
>> allows it to be skipped.
>
> While this is okay as a temporary fix, it would be better if we
> patched v4l-utils to not depend on X11 instead. The difficulty with
> that approach is that I don't think the v4l-utils configure script has
> an option to disable X11.
>
Yep. So says commit fa4d5d1f in meta-openembedded.

Having never used alsa-utils, I'm kinda trusting Martin that
it's non-trivial.

>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
>>   recipes-fsl/packagegroup/packagegroup-fsl.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-fsl/packagegroup/packagegroup-fsl.bb b/recipes-fsl/packagegroup/packagegroup-fsl.bb
>> index da931d6..80ce5a4 100644
>> --- a/recipes-fsl/packagegroup/packagegroup-fsl.bb
>> +++ b/recipes-fsl/packagegroup/packagegroup-fsl.bb
>> @@ -62,7 +62,7 @@ RDEPENDS_${PN}-tools-testapps = " \
>>       python-subprocess \
>>       python-datetime \
>>       python-json \
>> -    v4l-utils \
>> +    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
>>       ethtool \
>>       mtd-utils \
>>       mtd-utils-ubifs \
>> --
>> 1.8.1.2

Patch

diff --git a/recipes-fsl/packagegroup/packagegroup-fsl.bb b/recipes-fsl/packagegroup/packagegroup-fsl.bb
index da931d6..80ce5a4 100644
--- a/recipes-fsl/packagegroup/packagegroup-fsl.bb
+++ b/recipes-fsl/packagegroup/packagegroup-fsl.bb
@@ -62,7 +62,7 @@  RDEPENDS_${PN}-tools-testapps = " \
     python-subprocess \
     python-datetime \
     python-json \
-    v4l-utils \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
     ethtool \
     mtd-utils \
     mtd-utils-ubifs \