Patchwork [4/4] libfm: allow build with automake-1.14

login
register
mail settings
Submitter Marko Lindqvist
Date Oct. 25, 2013, 7:39 a.m.
Message ID <6ea9e9fe207b9c3b84a4450268ea289246b83055.1382686685.git.cazfi74@gmail.com>
Download mbox | patch
Permalink /patch/60511/
State Accepted
Commit f7281ebf1fd593805f2cc10828ecb9723e1554d0
Headers show

Comments

Marko Lindqvist - Oct. 25, 2013, 7:39 a.m.
Do not consider automake warnings about future incompatibility
errors.

Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
---
 .../libfm/libfm-1.1.2.2/ignore_automake_warnings.patch     | 14 ++++++++++++++
 meta/recipes-support/libfm/libfm_1.1.2.2.bb                |  1 +
 2 files changed, 15 insertions(+)
 create mode 100644 meta/recipes-support/libfm/libfm-1.1.2.2/ignore_automake_warnings.patch
Khem Raj - Oct. 29, 2013, 12:35 a.m.
Marko

On Fri, Oct 25, 2013 at 12:39 AM, Marko Lindqvist <cazfi74@gmail.com> wrote:
> Do not consider automake warnings about future incompatibility
> errors.

hmmm so disabling Werror is working around and I consider it degradation
in code quality, is there any alternative ? may be fix the code itself to not
generate the warning at all ?

>
> Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
> ---
>  .../libfm/libfm-1.1.2.2/ignore_automake_warnings.patch     | 14 ++++++++++++++
>  meta/recipes-support/libfm/libfm_1.1.2.2.bb                |  1 +
>  2 files changed, 15 insertions(+)
>  create mode 100644 meta/recipes-support/libfm/libfm-1.1.2.2/ignore_automake_warnings.patch
>
> diff --git a/meta/recipes-support/libfm/libfm-1.1.2.2/ignore_automake_warnings.patch b/meta/recipes-support/libfm/libfm-1.1.2.2/ignore_automake_warnings.patch
> new file mode 100644
> index 0000000..58a2f09
> --- /dev/null
> +++ b/meta/recipes-support/libfm/libfm-1.1.2.2/ignore_automake_warnings.patch
> @@ -0,0 +1,14 @@
> +Upstream-Status: Inappropriate [configuration]
> +
> +Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
> +diff -Nurd libfm-1.1.2.2/configure.ac libfm-1.1.2.2/configure.ac
> +--- libfm-1.1.2.2/configure.ac 2013-08-22 23:16:09.000000000 +0300
> ++++ libfm-1.1.2.2/configure.ac 2013-10-25 01:35:18.110323079 +0300
> +@@ -3,7 +3,7 @@
> +
> + AC_PREREQ([2.63])
> + AC_INIT([libfm], [1.1.2.2], [http://pcmanfm.sourceforge.net/])
> +-AM_INIT_AUTOMAKE([-Wall -Werror foreign])
> ++AM_INIT_AUTOMAKE([-Wall foreign])
> + AC_CONFIG_MACRO_DIR(m4)
> + AC_CONFIG_HEADERS([config.h])
> diff --git a/meta/recipes-support/libfm/libfm_1.1.2.2.bb b/meta/recipes-support/libfm/libfm_1.1.2.2.bb
> index 1146d16..8460223 100644
> --- a/meta/recipes-support/libfm/libfm_1.1.2.2.bb
> +++ b/meta/recipes-support/libfm/libfm_1.1.2.2.bb
> @@ -12,6 +12,7 @@ DEPENDS = "glib-2.0 pango gtk+ menu-cache intltool-native libexif"
>
>  SRC_URI = "${SOURCEFORGE_MIRROR}/pcmanfm/libfm-${PV}.tar.gz \
>             file://fix-make-parallelism-issue.patch \
> +           file://ignore_automake_warnings.patch \
>             "
>
>  SRC_URI[md5sum] = "ea3d09b23ef4c37cb84ae57ea16b8f08"
> --
> 1.8.4.rc3
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Marko Lindqvist - Oct. 29, 2013, 1:43 a.m.
On 29 October 2013 02:35, Khem Raj <raj.khem@gmail.com> wrote:
> Marko
>
> On Fri, Oct 25, 2013 at 12:39 AM, Marko Lindqvist <cazfi74@gmail.com> wrote:
>> Do not consider automake warnings about future incompatibility
>> errors.
>
> hmmm so disabling Werror is working around and I consider it degradation
> in code quality, is there any alternative ?

 I agree on principle. That's why I wouldn't even consider submitting
this to upstream, as future versions should handle this correctly. I
think it's ok for us to patch the current version this way, as the
warnings are about the future only.

> may be fix the code itself to not
> generate the warning at all ?

 That's something that (upstream) must do anyway before automake-2.0
comes out and turns these warnings in to errors. I'm not going to
figure these out for every upstream that has such a problem. When we
were preparing for automake-1.13, I submitted fixes to nearly 100
upstreams. While I usually am happy to fix the problems I encounter,
I'm not ready to make anything like that again. I'll leave proper
fixes for these problems for upstreams to make.


 - ML

Patch

diff --git a/meta/recipes-support/libfm/libfm-1.1.2.2/ignore_automake_warnings.patch b/meta/recipes-support/libfm/libfm-1.1.2.2/ignore_automake_warnings.patch
new file mode 100644
index 0000000..58a2f09
--- /dev/null
+++ b/meta/recipes-support/libfm/libfm-1.1.2.2/ignore_automake_warnings.patch
@@ -0,0 +1,14 @@ 
+Upstream-Status: Inappropriate [configuration]
+
+Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
+diff -Nurd libfm-1.1.2.2/configure.ac libfm-1.1.2.2/configure.ac
+--- libfm-1.1.2.2/configure.ac	2013-08-22 23:16:09.000000000 +0300
++++ libfm-1.1.2.2/configure.ac	2013-10-25 01:35:18.110323079 +0300
+@@ -3,7 +3,7 @@
+
+ AC_PREREQ([2.63])
+ AC_INIT([libfm], [1.1.2.2], [http://pcmanfm.sourceforge.net/])
+-AM_INIT_AUTOMAKE([-Wall -Werror foreign])
++AM_INIT_AUTOMAKE([-Wall foreign])
+ AC_CONFIG_MACRO_DIR(m4)
+ AC_CONFIG_HEADERS([config.h])
diff --git a/meta/recipes-support/libfm/libfm_1.1.2.2.bb b/meta/recipes-support/libfm/libfm_1.1.2.2.bb
index 1146d16..8460223 100644
--- a/meta/recipes-support/libfm/libfm_1.1.2.2.bb
+++ b/meta/recipes-support/libfm/libfm_1.1.2.2.bb
@@ -12,6 +12,7 @@  DEPENDS = "glib-2.0 pango gtk+ menu-cache intltool-native libexif"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/pcmanfm/libfm-${PV}.tar.gz \
            file://fix-make-parallelism-issue.patch \
+           file://ignore_automake_warnings.patch \
            "
 
 SRC_URI[md5sum] = "ea3d09b23ef4c37cb84ae57ea16b8f08"