Patchwork udev: Update touchscreen rule for ID_INPUT_TOUCHSCREEN

login
register
mail settings
Submitter Tom Rini
Date Oct. 22, 2013, 4:37 p.m.
Message ID <1382459830-15683-1-git-send-email-trini@ti.com>
Download mbox | patch
Permalink /patch/60387/
State New
Headers show

Comments

Tom Rini - Oct. 22, 2013, 4:37 p.m.
Since udev 174 udev has been running input_id as a built-in command and
setting this value in the environment for touchscreens.  Use this logic
to detect when to make a touchscreen0 symlink.

Signed-off-by: Tom Rini <trini@ti.com>
---
 meta/recipes-core/udev/udev/local.rules |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Tom Rini - Oct. 31, 2013, 11:27 a.m.
On Tue, Oct 22, 2013 at 12:37:10PM -0400, Tom Rini wrote:

> Since udev 174 udev has been running input_id as a built-in command and
> setting this value in the environment for touchscreens.  Use this logic
> to detect when to make a touchscreen0 symlink.
> 
> Signed-off-by: Tom Rini <trini@ti.com>
> ---
>  meta/recipes-core/udev/udev/local.rules |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/udev/udev/local.rules b/meta/recipes-core/udev/udev/local.rules
> index 72d92ef..d0b0216 100644
> --- a/meta/recipes-core/udev/udev/local.rules
> +++ b/meta/recipes-core/udev/udev/local.rules
> @@ -17,5 +17,5 @@
>  ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe $env{MODALIAS}"
>  
>  # Create a symlink to any touchscreen input device
> -SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*", SYMLINK+="input/touchscreen0"
> +SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"

Ping
Denys Dmytriyenko - April 23, 2014, 11:41 p.m.
On Thu, Oct 31, 2013 at 07:27:30AM -0400, Tom Rini wrote:
> On Tue, Oct 22, 2013 at 12:37:10PM -0400, Tom Rini wrote:
> 
> > Since udev 174 udev has been running input_id as a built-in command and
> > setting this value in the environment for touchscreens.  Use this logic
> > to detect when to make a touchscreen0 symlink.
> > 
> > Signed-off-by: Tom Rini <trini@ti.com>
> > ---
> >  meta/recipes-core/udev/udev/local.rules |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-core/udev/udev/local.rules b/meta/recipes-core/udev/udev/local.rules
> > index 72d92ef..d0b0216 100644
> > --- a/meta/recipes-core/udev/udev/local.rules
> > +++ b/meta/recipes-core/udev/udev/local.rules
> > @@ -17,5 +17,5 @@
> >  ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe $env{MODALIAS}"
> >  
> >  # Create a symlink to any touchscreen input device
> > -SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*", SYMLINK+="input/touchscreen0"
> > +SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"
> 
> Ping

Was it ever reviewed? Ping^2
Paul Eggleton - April 24, 2014, 8:56 a.m.
On Wednesday 23 April 2014 19:41:56 Denys Dmytriyenko wrote:
> On Thu, Oct 31, 2013 at 07:27:30AM -0400, Tom Rini wrote:
> > On Tue, Oct 22, 2013 at 12:37:10PM -0400, Tom Rini wrote:
> > > Since udev 174 udev has been running input_id as a built-in command and
> > > setting this value in the environment for touchscreens.  Use this logic
> > > to detect when to make a touchscreen0 symlink.
> > > 
> > > Signed-off-by: Tom Rini <trini@ti.com>
> > > ---
> > > 
> > >  meta/recipes-core/udev/udev/local.rules |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/meta/recipes-core/udev/udev/local.rules
> > > b/meta/recipes-core/udev/udev/local.rules index 72d92ef..d0b0216 100644
> > > --- a/meta/recipes-core/udev/udev/local.rules
> > > +++ b/meta/recipes-core/udev/udev/local.rules
> > > @@ -17,5 +17,5 @@
> > > 
> > >  ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*",
> > >  RUN+="/sbin/modprobe $env{MODALIAS}"
> > >  
> > >  # Create a symlink to any touchscreen input device
> > > 
> > > -SUBSYSTEM=="input", KERNEL=="event[0-9]*",
> > > ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*",
> > > SYMLINK+="input/touchscreen0" +SUBSYSTEM=="input",
> > > KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1",
> > > SYMLINK+="input/touchscreen0"> 
> > Ping
> 
> Was it ever reviewed? Ping^2

Sorry, what do you mean? It was reviewed and merged:

http://cgit.openembedded.org/openembedded-core/commit/?id=5abcfcd4380aacafc45d776f557738fb18089113

Cheers,
Paul
Denys Dmytriyenko - April 24, 2014, 6:01 p.m.
On Thu, Apr 24, 2014 at 09:56:20AM +0100, Paul Eggleton wrote:
> On Wednesday 23 April 2014 19:41:56 Denys Dmytriyenko wrote:
> > On Thu, Oct 31, 2013 at 07:27:30AM -0400, Tom Rini wrote:
> > > On Tue, Oct 22, 2013 at 12:37:10PM -0400, Tom Rini wrote:
> > > > Since udev 174 udev has been running input_id as a built-in command and
> > > > setting this value in the environment for touchscreens.  Use this logic
> > > > to detect when to make a touchscreen0 symlink.
> > > > 
> > > > Signed-off-by: Tom Rini <trini@ti.com>
> > > > ---
> > > > 
> > > >  meta/recipes-core/udev/udev/local.rules |    2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/meta/recipes-core/udev/udev/local.rules
> > > > b/meta/recipes-core/udev/udev/local.rules index 72d92ef..d0b0216 100644
> > > > --- a/meta/recipes-core/udev/udev/local.rules
> > > > +++ b/meta/recipes-core/udev/udev/local.rules
> > > > @@ -17,5 +17,5 @@
> > > > 
> > > >  ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*",
> > > >  RUN+="/sbin/modprobe $env{MODALIAS}"
> > > >  
> > > >  # Create a symlink to any touchscreen input device
> > > > 
> > > > -SUBSYSTEM=="input", KERNEL=="event[0-9]*",
> > > > ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*",
> > > > SYMLINK+="input/touchscreen0" +SUBSYSTEM=="input",
> > > > KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1",
> > > > SYMLINK+="input/touchscreen0"> 
> > > Ping
> > 
> > Was it ever reviewed? Ping^2
> 
> Sorry, what do you mean? It was reviewed and merged:
> 
> http://cgit.openembedded.org/openembedded-core/commit/?id=5abcfcd4380aacafc45d776f557738fb18089113

Oops, I guess I looked in Dora and it was merged after the release. Sorry for 
the noise.

Patch

diff --git a/meta/recipes-core/udev/udev/local.rules b/meta/recipes-core/udev/udev/local.rules
index 72d92ef..d0b0216 100644
--- a/meta/recipes-core/udev/udev/local.rules
+++ b/meta/recipes-core/udev/udev/local.rules
@@ -17,5 +17,5 @@ 
 ACTION=="add", DEVPATH=="/devices/*", ENV{MODALIAS}=="?*", RUN+="/sbin/modprobe $env{MODALIAS}"
 
 # Create a symlink to any touchscreen input device
-SUBSYSTEM=="input", KERNEL=="event[0-9]*", ATTRS{modalias}=="input:*-e0*,3,*a0,1,*18,*", SYMLINK+="input/touchscreen0"
+SUBSYSTEM=="input", KERNEL=="event[0-9]*", ENV{ID_INPUT_TOUCHSCREEN}=="1", SYMLINK+="input/touchscreen0"