Patchwork [1/1] midori: exclude from self-hosted for mips64

login
register
mail settings
Submitter jackie huang
Date Oct. 22, 2013, 6:04 a.m.
Message ID <58deef15f737352489f007488ec2e24bd76be058.1382421718.git.jackie.huang@windriver.com>
Download mbox | patch
Permalink /patch/60347/
State Accepted
Commit ffb440c37c3491fa5d9a1408341f7c15eacdc9ce
Headers show

Comments

jackie huang - Oct. 22, 2013, 6:04 a.m.
From: Jackie Huang <jackie.huang@windriver.com>

midori depends on webkit-gtk which could not build for mips64.

[YOCTO #5141]

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 .../packagegroups/packagegroup-self-hosted.bb      |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Khem Raj - Oct. 25, 2013, 12:32 p.m.
On Mon, Oct 21, 2013 at 11:04 PM,  <jackie.huang@windriver.com> wrote:
> midori depends on webkit-gtk which could not build for mips64.

what issues do you see building webkit-gtk for mips64, IIRC I fixed it
some time ago
jackie huang - Oct. 26, 2013, 1:40 a.m.
On 10/25/2013 8:32 PM, Khem Raj wrote:
> On Mon, Oct 21, 2013 at 11:04 PM,  <jackie.huang@windriver.com> wrote:
>> midori depends on webkit-gtk which could not build for mips64.
>
> what issues do you see building webkit-gtk for mips64, IIRC I fixed it
> some time ago

I didn't see the webkit-gtk issue, but I saw:
commit 0d2ed6bca55319195b5efd74eac83a459bf58ee8
Author: Kang Kai <kai.kang@windriver.com>
Date:   Fri Jul 5 10:18:10 2013 +0000

     webkit: set COMPATIBLE_HOST for mips64

     webkit packages can NOT be built for mips64 with 64 bit userspace. Set
     COMPATIBLE_HOST to to block them build for such platform.

     Signed-off-by: Kai Kang <kai.kang@windriver.com>
     Signed-off-by: Saul Wold <sgw@linux.intel.com>


and midori depends ot webkit-gtk so it's not buildable for mips64.
If it's fixed, I think you should reset the COMPATIBLE_HOST back for 
both webkitgtk and midori, thanks!

Thanks,
Jackie


>
Khem Raj - Oct. 26, 2013, 4:30 a.m.
On Saturday, October 26, 2013, jhuang0 wrote:

>
>
> On 10/25/2013 8:32 PM, Khem Raj wrote:
>
>> On Mon, Oct 21, 2013 at 11:04 PM,  <jackie.huang@windriver.com> wrote:
>>
>>> midori depends on webkit-gtk which could not build for mips64.
>>>
>>
>> what issues do you see building webkit-gtk for mips64, IIRC I fixed it
>> some time ago
>>
>
> I didn't see the webkit-gtk issue, but I saw:
> commit 0d2ed6bca55319195b5efd74eac83a**459bf58ee8
> Author: Kang Kai <kai.kang@windriver.com>
> Date:   Fri Jul 5 10:18:10 2013 +0000
>
>     webkit: set COMPATIBLE_HOST for mips64
>
>     webkit packages can NOT be built for mips64 with 64 bit userspace. Set
>     COMPATIBLE_HOST to to block them build for such platform.
>
>     Signed-off-by: Kai Kang <kai.kang@windriver.com>
>     Signed-off-by: Saul Wold <sgw@linux.intel.com>
>
>
> and midori depends ot webkit-gtk so it's not buildable for mips64.



hmm it passed my notice
it would be nice to know the errors



> If it's fixed, I think you should reset the COMPATIBLE_HOST back for both
> webkitgtk and midori, thanks!
>
> Thanks,
> Jackie
>
>
>
>>
> --
> Jackie Huang
> WIND RIVER | China Development Center
> MSN:jackielily@hotmail.com
> Tel: +86 8477 8594
> Mobile: +86 138 1027 4745
>

Patch

diff --git a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
index 61c99bc..108e678 100644
--- a/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-self-hosted.bb
@@ -26,6 +26,10 @@  RDEPENDS_packagegroup-self-hosted = "\
     packagegroup-self-hosted-host-tools \
     "
 
+# midori depends on webkit-gtk which could not build for mips64
+MIDORI = "midori"
+MIDORI_mips64 = ""
+
 RDEPENDS_packagegroup-self-hosted-host-tools = "\
     connman \
     connman-plugin-ethernet \
@@ -45,7 +49,7 @@  RDEPENDS_packagegroup-self-hosted-host-tools = "\
     mc-helpers-perl \
     mc-helpers-python \
     leafpad \
-    midori \
+    ${MIDORI} \
     pcmanfm \
     parted \
     pseudo \