Patchwork Add tune for Cortex-A5 chips

login
register
mail settings
Submitter ulf@emagii.com
Date Oct. 21, 2013, 8:59 a.m.
Message ID <1382345997-28170-1-git-send-email-ulf@emagii.com>
Download mbox | patch
Permalink /patch/60303/
State New
Headers show

Comments

ulf@emagii.com - Oct. 21, 2013, 8:59 a.m.
Signed-off-by: Ulf Samuelsson <ulf@emagii.com>
---
 meta/conf/machine/include/tune-cortexa5.inc |   24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa5.inc
Martin Jansa - Oct. 21, 2013, 11:17 a.m.
On Mon, Oct 21, 2013 at 10:59:57AM +0200, Ulf Samuelsson wrote:
> Signed-off-by: Ulf Samuelsson <ulf@emagii.com>
> ---
>  meta/conf/machine/include/tune-cortexa5.inc |   24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 meta/conf/machine/include/tune-cortexa5.inc
> 
> diff --git a/meta/conf/machine/include/tune-cortexa5.inc b/meta/conf/machine/include/tune-cortexa5.inc
> new file mode 100644
> index 0000000..69c945e
> --- /dev/null
> +++ b/meta/conf/machine/include/tune-cortexa5.inc
> @@ -0,0 +1,24 @@
> +DEFAULTTUNE ?= "cortexa5thf"

wasn't cortexa5 added already in:

commit 50bc63c5c377d9fbb87b3efefc8c6f5473ba642a
Author: Andy Voltz <andy.voltz@timesys.com>
Date:   Wed Jun 5 11:52:30 2013 -0400

    tune-cortexa5.inc: Add tune file for cortex-a5

I think that one was better, because it had optional neon support and
default DEFAULTTUNE should be something more generic (at least to stay
consistent with other tunes) it's DISTRO decision to select common
denominator (or more specific tunes for each MACHINE) for binary feeds
they want to manage.

see
commit a11bdc36a1be18cc5aa14682b2a2c9ee83141f51
Author: Martin Jansa <Martin.Jansa@gmail.com>
Date:   Tue Oct 2 13:21:08 2012 +0000

    tune-*: define more generic DEFAULTTUNE to share feed between
machines

> +# TUNE_FEATU4RES     = "armv7a vfp callconvention-hard"
> +# TARGET_FPU        = "vfp"
> +
> +require conf/machine/include/arm/arch-armv7a.inc
> +
> +TUNEVALID[cortexa5] = "Enable Cortex-A5 specific processor optimizations"
> +TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "cortexa5", "-mtune=cortex-a5", "", d)}"
> +
> +# Little Endian base configs
> +AVAILTUNES += "cortexa5 cortexa5t"
> +TUNE_FEATURES_tune-cortexa5 = "${TUNE_FEATURES_tune-armv7a} cortexa5"
> +TUNE_FEATURES_tune-cortexa5t = "${TUNE_FEATURES_tune-armv7at} cortexa5"
> +
> +PACKAGE_EXTRA_ARCHS_tune-cortexa5 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa5t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
> +
> +# VFP Tunes
> +AVAILTUNES += "cortexa5hf cortexa5thf"
> +TUNE_FEATURES_tune-cortexa5hf ?= "${TUNE_FEATURES_tune-armv7ahf} cortexa5"
> +TUNE_FEATURES_tune-cortexa5thf ?= "${TUNE_FEATURES_tune-armv7athf} cortexa5"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa5hf = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf}"
> +PACKAGE_EXTRA_ARCHS_tune-cortexa5thf = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf}"
> +
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
ulf@emagii.com - Oct. 21, 2013, 12:55 p.m.
On 2013-10-21 13:17, Martin Jansa wrote:
> On Mon, Oct 21, 2013 at 10:59:57AM +0200, Ulf Samuelsson wrote:
>> Signed-off-by: Ulf Samuelsson <ulf@emagii.com>
>> ---
>>   meta/conf/machine/include/tune-cortexa5.inc |   24 ++++++++++++++++++++++++
>>   1 file changed, 24 insertions(+)
>>   create mode 100644 meta/conf/machine/include/tune-cortexa5.inc
>>
>> diff --git a/meta/conf/machine/include/tune-cortexa5.inc b/meta/conf/machine/include/tune-cortexa5.inc
>> new file mode 100644
>> index 0000000..69c945e
>> --- /dev/null
>> +++ b/meta/conf/machine/include/tune-cortexa5.inc
>> @@ -0,0 +1,24 @@
>> +DEFAULTTUNE ?= "cortexa5thf"
> wasn't cortexa5 added already in:
>
> commit 50bc63c5c377d9fbb87b3efefc8c6f5473ba642a
> Author: Andy Voltz <andy.voltz@timesys.com>
> Date:   Wed Jun 5 11:52:30 2013 -0400
>
>      tune-cortexa5.inc: Add tune file for cortex-a5
>
> I think that one was better, because it had optional neon support and
> default DEFAULTTUNE should be something more generic (at least to stay
> consistent with other tunes) it's DISTRO decision to select common
> denominator (or more specific tunes for each MACHINE) for binary feeds
> they want to manage.
Looks like you are right.
I looked at the openembedded-core in Angstrom master, and it wasn't there.
(
     because Angstrom master checks out
     "openembedded-core/remotes/origin/angstrom-staging-yocto1.3"
)

Sorry.

/Ulf

>
> see
> commit a11bdc36a1be18cc5aa14682b2a2c9ee83141f51
> Author: Martin Jansa <Martin.Jansa@gmail.com>
> Date:   Tue Oct 2 13:21:08 2012 +0000
>
>      tune-*: define more generic DEFAULTTUNE to share feed between
> machines
>
>> +# TUNE_FEATU4RES     = "armv7a vfp callconvention-hard"
>> +# TARGET_FPU        = "vfp"
>> +
>> +require conf/machine/include/arm/arch-armv7a.inc
>> +
>> +TUNEVALID[cortexa5] = "Enable Cortex-A5 specific processor optimizations"
>> +TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "cortexa5", "-mtune=cortex-a5", "", d)}"
>> +
>> +# Little Endian base configs
>> +AVAILTUNES += "cortexa5 cortexa5t"
>> +TUNE_FEATURES_tune-cortexa5 = "${TUNE_FEATURES_tune-armv7a} cortexa5"
>> +TUNE_FEATURES_tune-cortexa5t = "${TUNE_FEATURES_tune-armv7at} cortexa5"
>> +
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
>> +
>> +# VFP Tunes
>> +AVAILTUNES += "cortexa5hf cortexa5thf"
>> +TUNE_FEATURES_tune-cortexa5hf ?= "${TUNE_FEATURES_tune-armv7ahf} cortexa5"
>> +TUNE_FEATURES_tune-cortexa5thf ?= "${TUNE_FEATURES_tune-armv7athf} cortexa5"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5hf = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf}"
>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5thf = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf}"
>> +
>> -- 
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj - Oct. 21, 2013, 9:46 p.m.
On Monday, October 21, 2013, Ulf Samuelsson <ulf@emagii.com> wrote:
> On 2013-10-21 13:17, Martin Jansa wrote:
>>
>> On Mon, Oct 21, 2013 at 10:59:57AM +0200, Ulf Samuelsson wrote:
>>>
>>> Signed-off-by: Ulf Samuelsson <ulf@emagii.com>
>>> ---
>>>   meta/conf/machine/include/tune-cortexa5.inc |   24
++++++++++++++++++++++++
>>>   1 file changed, 24 insertions(+)
>>>   create mode 100644 meta/conf/machine/include/tune-cortexa5.inc
>>>
>>> diff --git a/meta/conf/machine/include/tune-cortexa5.inc
b/meta/conf/machine/include/tune-cortexa5.inc
>>> new file mode 100644
>>> index 0000000..69c945e
>>> --- /dev/null
>>> +++ b/meta/conf/machine/include/tune-cortexa5.inc
>>> @@ -0,0 +1,24 @@
>>> +DEFAULTTUNE ?= "cortexa5thf"
>>
>> wasn't cortexa5 added already in:
>>
>> commit 50bc63c5c377d9fbb87b3efefc8c6f5473ba642a
>> Author: Andy Voltz <andy.voltz@timesys.com>
>> Date:   Wed Jun 5 11:52:30 2013 -0400
>>
>>      tune-cortexa5.inc: Add tune file for cortex-a5
>>
>> I think that one was better, because it had optional neon support and
>> default DEFAULTTUNE should be something more generic (at least to stay
>> consistent with other tunes) it's DISTRO decision to select common
>> denominator (or more specific tunes for each MACHINE) for binary feeds
>> they want to manage.
>
> Looks like you are right.
> I looked at the openembedded-core in Angstrom master, and it wasn't there.
> (
>     because Angstrom master checks out
>     "openembedded-core/remotes/origin/angstrom-staging-yocto1.3"
> )
>

thats default checkout of setup hopefully will change to 2013.12 release
soon which will be based on dora release
> Sorry.
>
> /Ulf
>
>>
>> see
>> commit a11bdc36a1be18cc5aa14682b2a2c9ee83141f51
>> Author: Martin Jansa <Martin.Jansa@gmail.com>
>> Date:   Tue Oct 2 13:21:08 2012 +0000
>>
>>      tune-*: define more generic DEFAULTTUNE to share feed between
>> machines
>>
>>> +# TUNE_FEATU4RES     = "armv7a vfp callconvention-hard"
>>> +# TARGET_FPU        = "vfp"
>>> +
>>> +require conf/machine/include/arm/arch-armv7a.inc
>>> +
>>> +TUNEVALID[cortexa5] = "Enable Cortex-A5 specific processor
optimizations"
>>> +TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "cortexa5",
"-mtune=cortex-a5", "", d)}"
>>> +
>>> +# Little Endian base configs
>>> +AVAILTUNES += "cortexa5 cortexa5t"
>>> +TUNE_FEATURES_tune-cortexa5 = "${TUNE_FEATURES_tune-armv7a} cortexa5"
>>> +TUNE_FEATURES_tune-cortexa5t = "${TUNE_FEATURES_tune-armv7at} cortexa5"
>>> +
>>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5 =
"${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
>>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5t =
"${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
>>> +
>>> +# VFP Tunes
>>> +AVAILTUNES += "cortexa5hf cortexa5thf"
>>> +TUNE_FEATURES_tune-cortexa5hf ?= "${TUNE_FEATURES_tune-armv7ahf}
cortexa5"
>>> +TUNE_FEATURES_tune-cortexa5thf ?= "${TUNE_FEATURES_tune-armv7athf}
cortexa5"
>>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5hf =
"${PACKAGE_EXTRA_ARCHS_tune-armv7ahf}"
>>> +PACKAGE_EXTRA_ARCHS_tune-cortexa5thf =
"${PACKAGE_EXTRA_ARCHS_tune-armv7athf}"
>>> +
>>> --
>>> 1.7.9.5
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
> --
> Best Regards
> Ulf Samuelsson
> ulf@emagii.com
> +46 722 427437
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/conf/machine/include/tune-cortexa5.inc b/meta/conf/machine/include/tune-cortexa5.inc
new file mode 100644
index 0000000..69c945e
--- /dev/null
+++ b/meta/conf/machine/include/tune-cortexa5.inc
@@ -0,0 +1,24 @@ 
+DEFAULTTUNE ?= "cortexa5thf"
+# TUNE_FEATURES     = "armv7a vfp callconvention-hard"
+# TARGET_FPU        = "vfp"
+
+require conf/machine/include/arm/arch-armv7a.inc
+
+TUNEVALID[cortexa5] = "Enable Cortex-A5 specific processor optimizations"
+TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "cortexa5", "-mtune=cortex-a5", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa5 cortexa5t"
+TUNE_FEATURES_tune-cortexa5 = "${TUNE_FEATURES_tune-armv7a} cortexa5"
+TUNE_FEATURES_tune-cortexa5t = "${TUNE_FEATURES_tune-armv7at} cortexa5"
+
+PACKAGE_EXTRA_ARCHS_tune-cortexa5 = "${PACKAGE_EXTRA_ARCHS_tune-armv7a}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa5t = "${PACKAGE_EXTRA_ARCHS_tune-armv7at}"
+
+# VFP Tunes
+AVAILTUNES += "cortexa5hf cortexa5thf"
+TUNE_FEATURES_tune-cortexa5hf ?= "${TUNE_FEATURES_tune-armv7ahf} cortexa5"
+TUNE_FEATURES_tune-cortexa5thf ?= "${TUNE_FEATURES_tune-armv7athf} cortexa5"
+PACKAGE_EXTRA_ARCHS_tune-cortexa5hf = "${PACKAGE_EXTRA_ARCHS_tune-armv7ahf}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa5thf = "${PACKAGE_EXTRA_ARCHS_tune-armv7athf}"
+