Patchwork [6/6] initscript: Change some order of init scripts

login
register
mail settings
Submitter Dongxiao Xu
Date June 16, 2011, 9:20 a.m.
Message ID <24c31ebbed038d3dda2e9a0a97bcd9fe4fe89a8d.1308215406.git.dongxiao.xu@intel.com>
Download mbox | patch
Permalink /patch/6017/
State New, archived
Headers show

Comments

Dongxiao Xu - June 16, 2011, 9:20 a.m.
Move udev script to execute ealier since module autoload needs it to
create device nodes.

Also move sysfs before udev which has dependency on it.

Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
---
 meta/recipes-core/initscripts/initscripts_1.0.bb   |    6 +++---
 meta/recipes-core/udev/udev-new.inc                |    2 +-
 meta/recipes-core/udev/udev_164.bb                 |    2 +-
 .../modutils/modutils-initscripts.bb               |    4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)
Andrea Adami - June 16, 2011, 9:38 a.m.
On Thu, Jun 16, 2011 at 11:20 AM, Dongxiao Xu <dongxiao.xu@intel.com> wrote:
> Move udev script to execute ealier since module autoload needs it to
> create device nodes.
>
> Also move sysfs before udev which has dependency on it.
>
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
<snip>

There was a drawback doing that: kernel modules loaded in unpredictable order:

http://patches.openembedded.org/patch/1917/

Is that still an issue?

Regards

Andrea
Phil Blundell - June 16, 2011, 9:41 a.m.
On Thu, 2011-06-16 at 11:38 +0200, Andrea Adami wrote:
> There was a drawback doing that: kernel modules loaded in unpredictable order:
> 
> http://patches.openembedded.org/patch/1917/
> 
> Is that still an issue?

I tend to think that anything which relies on the order of module
loading is probably broken.  Was it just this rtc thing that was
affected or were there other problems?

p.
Dongxiao Xu - June 17, 2011, 1:39 a.m.
Hi Andrea,

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Andrea Adami
> Sent: Thursday, June 16, 2011 5:38 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 6/6] initscript: Change some order of init scripts
> 
> On Thu, Jun 16, 2011 at 11:20 AM, Dongxiao Xu <dongxiao.xu@intel.com>
> wrote:
> > Move udev script to execute ealier since module autoload needs it to
> > create device nodes.
> >
> > Also move sysfs before udev which has dependency on it.
> >
> > Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> > ---
> <snip>
> 
> There was a drawback doing that: kernel modules loaded in unpredictable
> order:
> 
> http://patches.openembedded.org/patch/1917/
> 
> Is that still an issue?

Thanks for the reference.

In the above patch, modutils.sh is run before udevd. In such case, if an autoload module in modutils.sh needs to create a node under /dev/, this operation will fail since udevd is still not launched.
Therefore I move udevd before modutils.sh.

Thanks,
Dongxiao

> 
> Regards
> 
> Andrea
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
index 48b65b9..9e535af 100644
--- a/meta/recipes-core/initscripts/initscripts_1.0.bb
+++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
@@ -4,7 +4,7 @@  SECTION = "base"
 PRIORITY = "required"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
-PR = "r126"
+PR = "r127"
 
 INHIBIT_DEFAULT_DEPS = "1"
 
@@ -119,8 +119,8 @@  do_install () {
 	ln -sf		../init.d/bootmisc.sh	${D}${sysconfdir}/rcS.d/S55bootmisc.sh
 #	ln -sf		../init.d/urandom	${D}${sysconfdir}/rcS.d/S55urandom
 #	ln -sf		../init.d/finish.sh	${D}${sysconfdir}/rcS.d/S99finish.sh
-	# udev will run at S04 if installed
-	ln -sf		../init.d/sysfs.sh	${D}${sysconfdir}/rcS.d/S03sysfs.sh
+	ln -sf		../init.d/sysfs.sh	${D}${sysconfdir}/rcS.d/S02sysfs.sh
+	# udev will run at S03 if installed
 	ln -sf		../init.d/populate-volatile.sh	${D}${sysconfdir}/rcS.d/S37populate-volatile.sh
 	ln -sf		../init.d/devpts.sh	${D}${sysconfdir}/rcS.d/S38devpts.sh
 	if [ "${TARGET_ARCH}" = "arm" ]; then
diff --git a/meta/recipes-core/udev/udev-new.inc b/meta/recipes-core/udev/udev-new.inc
index 1b94f1b..4c4451f 100644
--- a/meta/recipes-core/udev/udev-new.inc
+++ b/meta/recipes-core/udev/udev-new.inc
@@ -40,7 +40,7 @@  PACKAGES =+ "libgudev libgudev-dev libgudev-dbg"
 
 INITSCRIPT_PACKAGES = "udev udev-cache"
 INITSCRIPT_NAME_udev = "udev"
-INITSCRIPT_PARAMS_udev = "start 04 S ."
+INITSCRIPT_PARAMS_udev = "start 03 S ."
 INITSCRIPT_NAME_udev-cache = "udev-cache"
 INITSCRIPT_PARAMS_udev-cache = "start 36 S ."
 
diff --git a/meta/recipes-core/udev/udev_164.bb b/meta/recipes-core/udev/udev_164.bb
index 76fd907..567e62e 100644
--- a/meta/recipes-core/udev/udev_164.bb
+++ b/meta/recipes-core/udev/udev_164.bb
@@ -1,6 +1,6 @@ 
 include udev-new.inc
 
-PR = "r2"
+PR = "r3"
 
 SRC_URI[md5sum] = "fddac2d54761ea34865af9467377ca9f"
 SRC_URI[sha256sum] = "c12e66280b5e1465f6587a8cfa47d7405c4caa7e52ce5dd13478d04f6ec05e5c"
diff --git a/meta/recipes-kernel/modutils/modutils-initscripts.bb b/meta/recipes-kernel/modutils/modutils-initscripts.bb
index 5ae34b4..89d38cf 100644
--- a/meta/recipes-kernel/modutils/modutils-initscripts.bb
+++ b/meta/recipes-kernel/modutils/modutils-initscripts.bb
@@ -4,10 +4,10 @@  LICENSE = "PD"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=7bf87fc37976e93ec66ad84fac58c098"
 SRC_URI = "file://modutils.sh \
 	   file://PD.patch"
-PR = "r5"
+PR = "r6"
 
 INITSCRIPT_NAME = "modutils.sh"
-INITSCRIPT_PARAMS = "start 2 S ."
+INITSCRIPT_PARAMS = "start 4 S ."
 
 inherit update-rc.d