Patchwork [10/11] nativesdk-packagegroup-sdk-host: Add new DISTRO_FEATURE, sdk-pms

login
register
mail settings
Submitter David Nyström
Date Oct. 17, 2013, 1:59 p.m.
Message ID <1382018386-25389-11-git-send-email-david.nystrom@enea.com>
Download mbox | patch
Permalink /patch/60129/
State New
Headers show

Comments

David Nyström - Oct. 17, 2013, 1:59 p.m.
Added a new distro feature called sdk-pms, since smartpm rdepends
on the python runtime.
This to avoid bloating the SDK tarball for those who does not
want it.

Signed-off-by: David Nyström <david.nystrom@enea.com>
---
 meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Richard Purdie - Oct. 18, 2013, 2:54 p.m.
On Thu, 2013-10-17 at 15:59 +0200, David Nyström wrote:
> Added a new distro feature called sdk-pms, since smartpm rdepends
> on the python runtime.
> This to avoid bloating the SDK tarball for those who does not
> want it.
> 
> Signed-off-by: David Nyström <david.nystrom@enea.com>
> ---
>  meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> index e298ff4..1f45c4c 100644
> --- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> +++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> @@ -16,7 +16,8 @@ RDEPENDS_${PN} = "\
>      nativesdk-qemu-helper \
>      nativesdk-pseudo \
>      nativesdk-unfs-server \
> -    nativesdk-opkg \
> +    ${@base_contains('DISTRO_FEATURES', 'sdk-pms', 'nativesdk-opkg','', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'sdk-pms', 'nativesdk-smartpm','', d)} \
>      nativesdk-libtool \
>      nativesdk-autoconf \
>      nativesdk-automake \

I think we need to keep a list of DISTRO_FEATURES somewhere along with a
definition about what the feature is supposed to do. For example this is
clearly about power management, right? :)

Along with this addition could you start a list somewhere documenting
this?

Cheers,

Richard
David Nyström - Oct. 18, 2013, 6:53 p.m.
On 18 Oct 2013 16:54, "Richard Purdie" <richard.purdie@linuxfoundation.org>
wrote:
>
> On Thu, 2013-10-17 at 15:59 +0200, David Nyström wrote:
> > Added a new distro feature called sdk-pms, since smartpm rdepends
> > on the python runtime.
> > This to avoid bloating the SDK tarball for those who does not
> > want it.
> >
> > Signed-off-by: David Nyström <david.nystrom@enea.com>
> > ---
> >  meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb | 3
++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/packagegroups/
nativesdk-packagegroup-sdk-host.bb b/meta/recipes-core/packagegroups/
nativesdk-packagegroup-sdk-host.bb
> > index e298ff4..1f45c4c 100644
> > --- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> > +++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> > @@ -16,7 +16,8 @@ RDEPENDS_${PN} = "\
> >      nativesdk-qemu-helper \
> >      nativesdk-pseudo \
> >      nativesdk-unfs-server \
> > -    nativesdk-opkg \
> > +    ${@base_contains('DISTRO_FEATURES', 'sdk-pms',
'nativesdk-opkg','', d)} \
> > +    ${@base_contains('DISTRO_FEATURES', 'sdk-pms',
'nativesdk-smartpm','', d)} \
> >      nativesdk-libtool \
> >      nativesdk-autoconf \
> >      nativesdk-automake \
>
> I think we need to keep a list of DISTRO_FEATURES somewhere along with a
> definition about what the feature is supposed to do. For example this is
> clearly about power management, right? :)
>
> Along with this addition could you start a list somewhere documenting
> this?

Sure, where would be a good place to start this ?
In the Reference manual ?

Br,
David

>
> Cheers,
>
> Richard
>
>

Patch

diff --git a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
index e298ff4..1f45c4c 100644
--- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
+++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
@@ -16,7 +16,8 @@  RDEPENDS_${PN} = "\
     nativesdk-qemu-helper \
     nativesdk-pseudo \
     nativesdk-unfs-server \
-    nativesdk-opkg \
+    ${@base_contains('DISTRO_FEATURES', 'sdk-pms', 'nativesdk-opkg','', d)} \
+    ${@base_contains('DISTRO_FEATURES', 'sdk-pms', 'nativesdk-smartpm','', d)} \
     nativesdk-libtool \
     nativesdk-autoconf \
     nativesdk-automake \