Patchwork [meta-fsl-arm] machines: Let u-boot be PREFERRED_PROVIDER for virtual/bootloader

login
register
mail settings
Submitter Khem Raj
Date Oct. 17, 2013, 12:08 a.m.
Message ID <1381968510-5489-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/60049/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Khem Raj - Oct. 17, 2013, 12:08 a.m.
Lets play the layer with other BSP layers in distro

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 conf/machine/include/imx-base.inc | 3 +++
 conf/machine/include/mxs-base.inc | 3 +++
 2 files changed, 6 insertions(+)
Daiane Angolini - Oct. 17, 2013, 1:16 p.m.
On 10/16/2013 09:08 PM, Khem Raj wrote:
> Lets play the layer with other BSP layers in distro

I think I like your patch, but i don't like your commit log, sorry :(

Would you mind to add 1)Why are you making the patch 2)What error it did 
cause to you?


I don't mind if you keep your sentence as is, but i think something else 
is needed.

Daiane

>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   conf/machine/include/imx-base.inc | 3 +++
>   conf/machine/include/mxs-base.inc | 3 +++

Please, grep the source in order to double check if there is any other 
machine file that set the PREFERRED_PROVIDER_u-boot. I almost remember, 
but I'm not sure.

>   2 files changed, 6 insertions(+)
>
> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
> index beeee5f..ff5e96b 100644
> --- a/conf/machine/include/imx-base.inc
> +++ b/conf/machine/include/imx-base.inc
> @@ -88,6 +88,9 @@ PREFERRED_PROVIDER_virtual/libgl_mx6 ?= "gpu-viv-bin-mx6q"
>   PREFERRED_PROVIDER_virtual/libgles1_mx6 ?= "gpu-viv-bin-mx6q"
>   PREFERRED_PROVIDER_virtual/libgles2_mx6 ?= "gpu-viv-bin-mx6q"
>
> +# u-boot
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
> +
>   PREFERRED_PROVIDER_virtual/kernel_mx3 = "linux-fslc"
>
>   EXTRA_IMAGEDEPENDS = "u-boot"
> diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
> index a048f9c..ef3130d 100644
> --- a/conf/machine/include/mxs-base.inc
> +++ b/conf/machine/include/mxs-base.inc
> @@ -11,6 +11,9 @@ SOC_FAMILY = "mxs"
>
>   PREFERRED_PROVIDER_virtual/kernel_mx23 = "linux-fslc"
>
> +# u-boot
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
> +
>   UBOOT_ENTRYPOINT = "0x40008000"
>   UBOOT_MAKE_TARGET = "u-boot.sb"
>   UBOOT_SUFFIX = "sb"
>
Khem Raj - Oct. 17, 2013, 2:56 p.m.
On Thursday, October 17, 2013, Daiane Angolini wrote:

> On 10/16/2013 09:08 PM, Khem Raj wrote:
>
>> Lets play the layer with other BSP layers in distro
>>
>
> I think I like your patch, but i don't like your commit log, sorry :(


Yes there is missing bits, it must have been "lets it ..."
nevertheless you can change it to "lets it coexist with other bsp layers in
a multimachine distribution setup"

>
> Would you mind to add 1)Why are you making the patch 2)What error it did
> cause to you?


 Bit bake virtual/bootloader would build wrong u-boot thats why the patch

>
>
> I don't mind if you keep your sentence as is, but i think something else
> is needed.
>
> Daiane
>
>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>   conf/machine/include/imx-base.**inc | 3 +++
>>   conf/machine/include/mxs-base.**inc | 3 +++
>>
>
> Please, grep the source in order to double check if there is any other
> machine file that set the PREFERRED_PROVIDER_u-boot. I almost remember, but
> I'm not sure.
>
>    2 files changed, 6 insertions(+)
>>
>> diff --git a/conf/machine/include/imx-**base.inc
>> b/conf/machine/include/imx-**base.inc
>> index beeee5f..ff5e96b 100644
>> --- a/conf/machine/include/imx-**base.inc
>> +++ b/conf/machine/include/imx-**base.inc
>> @@ -88,6 +88,9 @@ PREFERRED_PROVIDER_virtual/**libgl_mx6 ?=
>> "gpu-viv-bin-mx6q"
>>   PREFERRED_PROVIDER_virtual/**libgles1_mx6 ?= "gpu-viv-bin-mx6q"
>>   PREFERRED_PROVIDER_virtual/**libgles2_mx6 ?= "gpu-viv-bin-mx6q"
>>
>> +# u-boot
>> +PREFERRED_PROVIDER_virtual/**bootloader ?= "u-boot-fslc"
>> +
>>   PREFERRED_PROVIDER_virtual/**kernel_mx3 = "linux-fslc"
>>
>>   EXTRA_IMAGEDEPENDS = "u-boot"
>> diff --git a/conf/machine/include/mxs-**base.inc
>> b/conf/machine/include/mxs-**base.inc
>> index a048f9c..ef3130d 100644
>> --- a/conf/machine/include/mxs-**base.inc
>> +++ b/conf/machine/include/mxs-**base.inc
>> @@ -11,6 +11,9 @@ SOC_FAMILY = "mxs"
>>
>>   PREFERRED_PROVIDER_virtual/**kernel_mx23 = "linux-fslc"
>>
>> +# u-boot
>> +PREFERRED_PROVIDER_virtual/**bootloader ?= "u-boot-fslc"
>> +
>>   UBOOT_ENTRYPOINT = "0x40008000"
>>   UBOOT_MAKE_TARGET = "u-boot.sb"
>>   UBOOT_SUFFIX = "sb"
>>
>>
>
> --
> Daiane
>
>
Otavio Salvador - Oct. 17, 2013, 3:05 p.m.
On Thu, Oct 17, 2013 at 11:56 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Thursday, October 17, 2013, Daiane Angolini wrote:
>>
>> On 10/16/2013 09:08 PM, Khem Raj wrote:
>>>
>>> Lets play the layer with other BSP layers in distro
>>
>>
>> I think I like your patch, but i don't like your commit log, sorry :(
>
>
> Yes there is missing bits, it must have been "lets it ..."
> nevertheless you can change it to "lets it coexist with other bsp layers in
> a multimachine distribution setup"
>
>> Would you mind to add 1)Why are you making the patch 2)What error it did
>> cause to you?
>
>
>  Bit bake virtual/bootloader would build wrong u-boot thats why the patch
>>
>>
>>
>> I don't mind if you keep your sentence as is, but i think something else
>> is needed.

Please Khem please a v2 with a more extended commitlog and please
check of other boards setting the U-Boot preference; as Daiane said we
have other references for it and it'd be better to fix this in same
patch.

Patch

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index beeee5f..ff5e96b 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -88,6 +88,9 @@  PREFERRED_PROVIDER_virtual/libgl_mx6 ?= "gpu-viv-bin-mx6q"
 PREFERRED_PROVIDER_virtual/libgles1_mx6 ?= "gpu-viv-bin-mx6q"
 PREFERRED_PROVIDER_virtual/libgles2_mx6 ?= "gpu-viv-bin-mx6q"
 
+# u-boot
+PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
+
 PREFERRED_PROVIDER_virtual/kernel_mx3 = "linux-fslc"
 
 EXTRA_IMAGEDEPENDS = "u-boot"
diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
index a048f9c..ef3130d 100644
--- a/conf/machine/include/mxs-base.inc
+++ b/conf/machine/include/mxs-base.inc
@@ -11,6 +11,9 @@  SOC_FAMILY = "mxs"
 
 PREFERRED_PROVIDER_virtual/kernel_mx23 = "linux-fslc"
 
+# u-boot
+PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-fslc"
+
 UBOOT_ENTRYPOINT = "0x40008000"
 UBOOT_MAKE_TARGET = "u-boot.sb"
 UBOOT_SUFFIX = "sb"