Patchwork [3/4] xserver-xorg-conf: add iphone3g support

login
register
mail settings
Submitter Denis Carikli
Date Dec. 7, 2010, 2:32 p.m.
Message ID <1291732373-17953-4-git-send-email-GNUtoo@no-log.org>
Download mbox | patch
Permalink /patch/6/
State Rejected
Headers show

Comments

Denis Carikli - Dec. 7, 2010, 2:32 p.m.
Signed-off-by: Chris 'Lopi' Spehn <chris.spehn@gmail.com>
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
---
 .../xserver-xorg-conf/iphone3g/xorg.conf           |   31 ++++++++++++++++++++
 recipes/xorg-xserver/xserver-xorg-conf_0.1.bb      |    2 +-
 2 files changed, 32 insertions(+), 1 deletions(-)
 create mode 100644 recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf
Stefan Schmidt - Dec. 9, 2010, 2:35 p.m.
Hello.

On Tue, 2010-12-07 at 15:32, Denis 'GNUtoo' Carikli wrote:
> Signed-off-by: Chris 'Lopi' Spehn <chris.spehn@gmail.com>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
> ---
>  .../xserver-xorg-conf/iphone3g/xorg.conf           |   31 ++++++++++++++++++++
>  recipes/xorg-xserver/xserver-xorg-conf_0.1.bb      |    2 +-
>  2 files changed, 32 insertions(+), 1 deletions(-)
>  create mode 100644 recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf
> 
> diff --git a/recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf b/recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf
> new file mode 100644
> index 0000000..19f02e9
> --- /dev/null
> +++ b/recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf
> @@ -0,0 +1,31 @@
> +Section "Device"
> +	Identifier "Builtin Default fbdev Device 0"
> +	Driver  "fbdev"
> +	Option "ShadowFB" "on"
> +	#Option "Rotate" "CW" # comment for disabling rotation
> +EndSection
> +
> +Section "Screen"
> +	Identifier "Builtin Default fbdev Screen 0"
> +	Device "Builtin Default fbdev Device 0"
> +EndSection
> +
> +
> +Section "InputDevice"
> +	Identifier "touchscreen"
> +	Driver "evdev"
> +	Option "Device" "/dev/input/event2"

Are you sure that it always is event2? The nodes are assigned dynamically
normally and we have /dev/touchscreen to work around this

> +	Option "Calibration" "0 4602 0 7306"

Why here? We happen to use the pointercal file for this.

regards
Stefan Schmidt
Chris Spehn - Dec. 9, 2010, 7:05 p.m.
I think Jama mentioned this to me on irc in #openmoko-cdevel, but I
simply forgot about it. I can make a pointercal file instead of using
the xorg.conf option.

On Thu, Dec 9, 2010 at 8:35 AM, Stefan Schmidt
<stefan@datenfreihafen.org> wrote:
> Hello.
>
> On Tue, 2010-12-07 at 15:32, Denis 'GNUtoo' Carikli wrote:
>> Signed-off-by: Chris 'Lopi' Spehn <chris.spehn@gmail.com>
>> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@no-log.org>
>> ---
>>  .../xserver-xorg-conf/iphone3g/xorg.conf           |   31 ++++++++++++++++++++
>>  recipes/xorg-xserver/xserver-xorg-conf_0.1.bb      |    2 +-
>>  2 files changed, 32 insertions(+), 1 deletions(-)
>>  create mode 100644 recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf
>>
>> diff --git a/recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf b/recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf
>> new file mode 100644
>> index 0000000..19f02e9
>> --- /dev/null
>> +++ b/recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf
>> @@ -0,0 +1,31 @@
>> +Section "Device"
>> +     Identifier "Builtin Default fbdev Device 0"
>> +     Driver  "fbdev"
>> +     Option "ShadowFB" "on"
>> +     #Option "Rotate" "CW" # comment for disabling rotation
>> +EndSection
>> +
>> +Section "Screen"
>> +     Identifier "Builtin Default fbdev Screen 0"
>> +     Device "Builtin Default fbdev Device 0"
>> +EndSection
>> +
>> +
>> +Section "InputDevice"
>> +     Identifier "touchscreen"
>> +     Driver "evdev"
>> +     Option "Device" "/dev/input/event2"
>
> Are you sure that it always is event2? The nodes are assigned dynamically
> normally and we have /dev/touchscreen to work around this
>
>> +     Option "Calibration" "0 4602 0 7306"
>
> Why here? We happen to use the pointercal file for this.
>
> regards
> Stefan Schmidt
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Stefan Schmidt - Dec. 10, 2010, 5:36 p.m.
Hello.

On Thu, 2010-12-09 at 13:05, Chris Spehn wrote:
> I think Jama mentioned this to me on irc in #openmoko-cdevel, but I
> simply forgot about it. I can make a pointercal file instead of using
> the xorg.conf option.

The hardcoded input device worries me a bit more then the ts calibration. :)

The other three pathces are fine to go in via GNUtoo. And if you can tell my why
it always will be the same device this one is fine, too. :)

regards
Stefan Schmidt
Chris Spehn - Dec. 11, 2010, 1:23 a.m.
When I was using Ubuntu and other distributions, the touch screen was
always located under /dev/input/event1. For some reason, SHR places it
under /dev/input/event2. I can't tell you why either because I have no
idea. I can tell you that every time I have booted SHR the touchscreen
has been located under event2.

On Fri, Dec 10, 2010 at 11:36 AM, Stefan Schmidt
<stefan@datenfreihafen.org> wrote:
> Hello.
>
> On Thu, 2010-12-09 at 13:05, Chris Spehn wrote:
>> I think Jama mentioned this to me on irc in #openmoko-cdevel, but I
>> simply forgot about it. I can make a pointercal file instead of using
>> the xorg.conf option.
>
> The hardcoded input device worries me a bit more then the ts calibration. :)
>
> The other three pathces are fine to go in via GNUtoo. And if you can tell my why
> it always will be the same device this one is fine, too. :)
>
> regards
> Stefan Schmidt
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf b/recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf
new file mode 100644
index 0000000..19f02e9
--- /dev/null
+++ b/recipes/xorg-xserver/xserver-xorg-conf/iphone3g/xorg.conf
@@ -0,0 +1,31 @@ 
+Section "Device"
+	Identifier "Builtin Default fbdev Device 0"
+	Driver  "fbdev"
+	Option "ShadowFB" "on"
+	#Option "Rotate" "CW" # comment for disabling rotation
+EndSection
+
+Section "Screen"
+	Identifier "Builtin Default fbdev Screen 0"
+	Device "Builtin Default fbdev Device 0"
+EndSection
+
+
+Section "InputDevice"
+	Identifier "touchscreen"
+	Driver "evdev"
+	Option "Device" "/dev/input/event2"
+	Option "Calibration" "0 4602 0 7306"
+	Option "ReportingMode" "Raw"
+	Option "SendCoreEvents" "On"
+	Option "GrabDevices" "True"
+	Option "InvertY" "0"
+	Option "SwapAxes" "0"
+EndSection
+
+
+Section "ServerLayout"
+	Identifier      "Builtin Default Layout"
+	Screen  "Builtin Default fbdev Screen 0"
+	InputDevice "touchscreen" "CorePointer" "AlwaysCore"
+EndSection
diff --git a/recipes/xorg-xserver/xserver-xorg-conf_0.1.bb b/recipes/xorg-xserver/xserver-xorg-conf_0.1.bb
index 25a3867..71d3be3 100644
--- a/recipes/xorg-xserver/xserver-xorg-conf_0.1.bb
+++ b/recipes/xorg-xserver/xserver-xorg-conf_0.1.bb
@@ -1,5 +1,5 @@ 
 DESCRIPTION = "Machine specific xorg.conf files"
-PR = "r37"
+PR = "r38"
 
 SRC_URI = "file://xorg.conf"