Patchwork packagegroup-core-basic: libuser has a hard depenency on libpam

login
register
mail settings
Submitter Saul Wold
Date Oct. 15, 2013, 10:22 p.m.
Message ID <1381875766-20689-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/59959/
State Accepted
Commit 5b3c2aac48dd060f20a3c65f15560996c35695fd
Headers show

Comments

Saul Wold - Oct. 15, 2013, 10:22 p.m.
Since libpam is only built when DISTRO_FEATURES pam is enabled we should
not be trying to build libuser also.

[YOCTO #4949]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-extended/packagegroups/packagegroup-core-basic.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Paul Eggleton - Oct. 16, 2013, 10:25 a.m.
On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
> not be trying to build libuser also.

Should this packagegroup be bringing in libraries such as this at all, given 
that libraries are generally pulled in as dependencies of applications that 
link to them?

Cheers,
Paul
Koen Kooi - Oct. 16, 2013, 11:23 a.m.
Op 16 okt. 2013, om 12:25 heeft Paul Eggleton <paul.eggleton@linux.intel.com> het volgende geschreven:

> On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
>> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
>> not be trying to build libuser also.
> 
> Should this packagegroup be bringing in libraries such as this at all, given 
> that libraries are generally pulled in as dependencies of applications that 
> link to them?

If it is a pure library, no. But libuser doesn't seem to be a pure library package:

[koen@rrMBP libuser]$ cat libuser/latest
PV = 0.58
PR = r0
PKGR = r0.0
RPROVIDES = 
RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam (>= 1.1.6) popt (>= 1.16)
RRECOMMENDS = 
PKGSIZE = 283679
FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/* /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf /usr/share/sounds /usr/lib/bonobo/servers
FILELIST = /etc/libuser.conf /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1 /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod

regards,

Koen
Paul Eggleton - Oct. 16, 2013, 11:47 a.m.
On Wednesday 16 October 2013 13:23:08 Koen Kooi wrote:
> Op 16 okt. 2013, om 12:25 heeft Paul Eggleton
> <paul.eggleton@linux.intel.com> het volgende geschreven:
> > On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
> >> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
> >> not be trying to build libuser also.
> > 
> > Should this packagegroup be bringing in libraries such as this at all,
> > given that libraries are generally pulled in as dependencies of
> > applications that link to them?
> 
> If it is a pure library, no. But libuser doesn't seem to be a pure library
> package:
> 
> [koen@rrMBP libuser]$ cat libuser/latest
> PV = 0.58
> PR = r0
> PKGR = r0.0
> RPROVIDES =
> RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam
> (>= 1.1.6) popt (>= 1.16) RRECOMMENDS =
> PKGSIZE = 283679
> FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc
> /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d
> /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/*
> /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf
> /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf
> /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1
> /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so
> /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd
> /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers
> /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod

Right, in that case, ignore me :)

Cheers,
Paul
Koen Kooi - Oct. 16, 2013, 12:21 p.m.
Op 16 okt. 2013, om 13:47 heeft Paul Eggleton <paul.eggleton@linux.intel.com> het volgende geschreven:

> On Wednesday 16 October 2013 13:23:08 Koen Kooi wrote:
>> Op 16 okt. 2013, om 12:25 heeft Paul Eggleton
>> <paul.eggleton@linux.intel.com> het volgende geschreven:
>>> On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
>>>> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
>>>> not be trying to build libuser also.
>>> 
>>> Should this packagegroup be bringing in libraries such as this at all,
>>> given that libraries are generally pulled in as dependencies of
>>> applications that link to them?
>> 
>> If it is a pure library, no. But libuser doesn't seem to be a pure library
>> package:
>> 
>> [koen@rrMBP libuser]$ cat libuser/latest
>> PV = 0.58
>> PR = r0
>> PKGR = r0.0
>> RPROVIDES =
>> RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam
>> (>= 1.1.6) popt (>= 1.16) RRECOMMENDS =
>> PKGSIZE = 283679
>> FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc
>> /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d
>> /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/*
>> /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf
>> /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf
>> /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1
>> /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so
>> /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd
>> /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers
>> /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod
> 
> Right, in that case, ignore me :)

But I still don't know what it does and why it needs to be in packagegroup-core-basic, though.

regards,

Koen
Richard Purdie - Oct. 16, 2013, 12:24 p.m.
On Wed, 2013-10-16 at 14:21 +0200, Koen Kooi wrote:
> Op 16 okt. 2013, om 13:47 heeft Paul Eggleton <paul.eggleton@linux.intel.com> het volgende geschreven:
> 
> > On Wednesday 16 October 2013 13:23:08 Koen Kooi wrote:
> >> Op 16 okt. 2013, om 12:25 heeft Paul Eggleton
> >> <paul.eggleton@linux.intel.com> het volgende geschreven:
> >>> On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
> >>>> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
> >>>> not be trying to build libuser also.
> >>> 
> >>> Should this packagegroup be bringing in libraries such as this at all,
> >>> given that libraries are generally pulled in as dependencies of
> >>> applications that link to them?
> >> 
> >> If it is a pure library, no. But libuser doesn't seem to be a pure library
> >> package:
> >> 
> >> [koen@rrMBP libuser]$ cat libuser/latest
> >> PV = 0.58
> >> PR = r0
> >> PKGR = r0.0
> >> RPROVIDES =
> >> RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam
> >> (>= 1.1.6) popt (>= 1.16) RRECOMMENDS =
> >> PKGSIZE = 283679
> >> FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc
> >> /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d
> >> /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/*
> >> /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf
> >> /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf
> >> /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1
> >> /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so
> >> /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd
> >> /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers
> >> /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod
> > 
> > Right, in that case, ignore me :)
> 
> But I still don't know what it does and why it needs to be in packagegroup-core-basic, though.

Looks like it has a number of pam user tools (groupadd, useradd and so
on) and this goes with the other contents of
packagegroup-core-multiuser...

Cheers,

Richard

Patch

diff --git a/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb b/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb
index 2e6f576..596fede 100644
--- a/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb
+++ b/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb
@@ -107,7 +107,7 @@  RDEPENDS_packagegroup-core-initscripts = "\
 RDEPENDS_packagegroup-core-multiuser = "\
     cracklib \
     gzip \
-    libuser \
+    ${@base_contains('DISTRO_FEATURES', 'pam', 'libuser', '', d)} \
     shadow \
     sudo \
     "