Patchwork [1/2] wic: Force lba off for FAT16 partitions

login
register
mail settings
Submitter Darren Hart
Date Oct. 15, 2013, 9:46 p.m.
Message ID <1381f3f71df0a605f65231cfced4fdbaaf5c76d2.1381869082.git.dvhart@linux.intel.com>
Download mbox | patch
Permalink /patch/59957/
State Accepted
Commit 30442d432e203e655b7d40b93f7307f475de1614
Headers show

Comments

Darren Hart - Oct. 15, 2013, 9:46 p.m.
If fat16 is specified to the mkpart parted command, parted will
default to setting the lba flag which causes certain EFI firmware
to fail to detect the filesystem. lba shouldn't be necessary for
FAT16 filesystems anyway, explicitly disable it.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Cc: Tom Zanussi <tom.zanussi@intel.com>
---
 scripts/lib/mic/utils/partitionedfs.py |   10 ++++++++++
 1 file changed, 10 insertions(+)

Patch

diff --git a/scripts/lib/mic/utils/partitionedfs.py b/scripts/lib/mic/utils/partitionedfs.py
index e8cded2..59263ba 100644
--- a/scripts/lib/mic/utils/partitionedfs.py
+++ b/scripts/lib/mic/utils/partitionedfs.py
@@ -352,6 +352,16 @@  class PartitionedMount(Mount):
                 self.__run_parted(["-s", d['disk'].device, "set",
                                    "%d" % p['num'], flag_name, "on"])
 
+            # Parted defaults to enabling the lba flag for fat16 partitions,
+            # which causes compatibility issues with some firmware (and really
+            # isn't necessary).
+            if parted_fs_type == "fat16":
+                if d['ptable_format'] == 'msdos':
+                    msger.debug("Disable 'lba' flag for partition '%s' on disk '%s'" % \
+                                (p['num'], d['disk'].device))
+                    self.__run_parted(["-s", d['disk'].device, "set",
+                                       "%d" % p['num'], "lba", "off"])
+
         # If the partition table format is "gpt", find out PARTUUIDs for all
         # the partitions. And if users specified custom parition type UUIDs,
         # set them.