Patchwork crond: remove UID check in init script

login
register
mail settings
Submitter ml@communistcode.co.uk
Date Oct. 15, 2013, 9:06 a.m.
Message ID <1381827974-19501-1-git-send-email-ml@communistcode.co.uk>
Download mbox | patch
Permalink /patch/59877/
State Accepted
Commit 89b569bca7b270e83f305bdc16ddc066ff406e95
Headers show

Comments

ml@communistcode.co.uk - Oct. 15, 2013, 9:06 a.m.
From: Jack Mitchell <jmitchell@cbnl.com>

this init script fails when the default shell is busybox sh. This
is because busybox sh doesn't set the UID. No other init scripts
in oecore feel the need to check the UID so just remove the check.

Signed-off-by: Jack Mitchell <jmitchell@cbnl.com>
---
 meta/recipes-extended/cronie/cronie/crond.init | 8 --------
 1 file changed, 8 deletions(-)

Patch

diff --git a/meta/recipes-extended/cronie/cronie/crond.init b/meta/recipes-extended/cronie/cronie/crond.init
index 08f34be..c8dffef 100755
--- a/meta/recipes-extended/cronie/cronie/crond.init
+++ b/meta/recipes-extended/cronie/cronie/crond.init
@@ -23,10 +23,6 @@  CONFIG=/etc/sysconfig/crond
 
 case "$1" in
   start)
-    if [ $UID -ne 0 ] ; then
-        echo "User has insufficient privilege."
-        exit 1
-    fi
     echo -n "Starting crond: "
     start-stop-daemon --start --quiet --exec $CROND -- $CRONDARGS
     RETVAL=$?
@@ -37,10 +33,6 @@  case "$1" in
     fi
     ;;
   stop)
-    if [ $UID -ne 0 ] ; then
-        echo "User has insufficient privilege."
-        exit 1
-    fi
     echo -n "Stopping crond: "
     start-stop-daemon --stop --quiet --pidfile /var/run/crond.pid
     RETVAL=$?