Patchwork [PATCHv2] openssh: allow login with empty password

login
register
mail settings
Submitter Koen Kooi
Date Oct. 14, 2013, 10:09 a.m.
Message ID <1381745377-6129-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/59815/
State New
Headers show

Comments

Koen Kooi - Oct. 14, 2013, 10:09 a.m.
Currently both PAM and dropbear allow logins with empty passwords, but
openssh doesn't. This commit changes the default in openssh to allow
empty password logins.

This should be changed to be a global config option in the long run.

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Paul Eggleton - Oct. 14, 2013, 10:37 a.m.
On Monday 14 October 2013 12:09:37 Koen Kooi wrote:
> Currently both PAM and dropbear allow logins with empty passwords, but
> openssh doesn't. This commit changes the default in openssh to allow
> empty password logins.
> 
> This should be changed to be a global config option in the long run.
> 
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
> b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config index
> 4f9b626..175e8f3 100644
> --- a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
> +++ b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
> @@ -59,7 +59,7 @@ Protocol 2
> 
>  # To disable tunneled clear text passwords, change to no here!
>  #PasswordAuthentication yes
> -#PermitEmptyPasswords no
> +PermitEmptyPasswords yes
> 
>  # Change to no to disable s/key passwords
>  #ChallengeResponseAuthentication yes

We do already have logic in image.bbclass to set this based upon debug-tweaks 
being in IMAGE_FEATURES; is that not working for you?

Cheers,
Paul
Koen Kooi - Oct. 14, 2013, 11:09 a.m.
Op 14 okt. 2013, om 12:37 heeft Paul Eggleton <paul.eggleton@linux.intel.com> het volgende geschreven:

> On Monday 14 October 2013 12:09:37 Koen Kooi wrote:
>> Currently both PAM and dropbear allow logins with empty passwords, but
>> openssh doesn't. This commit changes the default in openssh to allow
>> empty password logins.
>> 
>> This should be changed to be a global config option in the long run.
>> 
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
>> b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config index
>> 4f9b626..175e8f3 100644
>> --- a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
>> +++ b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
>> @@ -59,7 +59,7 @@ Protocol 2
>> 
>> # To disable tunneled clear text passwords, change to no here!
>> #PasswordAuthentication yes
>> -#PermitEmptyPasswords no
>> +PermitEmptyPasswords yes
>> 
>> # Change to no to disable s/key passwords
>> #ChallengeResponseAuthentication yes
> 
> We do already have logic in image.bbclass to set this based upon debug-tweaks 
> being in IMAGE_FEATURES; is that not working for you?

I haven't tried that, but that still doesn't fix the inconsistency issues and presents problems during package upgrades. 

regards,

Koen
Paul Eggleton - Oct. 14, 2013, 11:27 a.m.
On Monday 14 October 2013 13:09:55 Koen Kooi wrote:
> Op 14 okt. 2013, om 12:37 heeft Paul Eggleton
> <paul.eggleton@linux.intel.com> het volgende geschreven:
> > On Monday 14 October 2013 12:09:37 Koen Kooi wrote:
> >> Currently both PAM and dropbear allow logins with empty passwords, but
> >> openssh doesn't. This commit changes the default in openssh to allow
> >> empty password logins.
> >> 
> >> This should be changed to be a global config option in the long run.
> >> 
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >> ---
> >> meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
> >> b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config index
> >> 4f9b626..175e8f3 100644
> >> --- a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
> >> +++ b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
> >> @@ -59,7 +59,7 @@ Protocol 2
> >> 
> >> # To disable tunneled clear text passwords, change to no here!
> >> #PasswordAuthentication yes
> >> -#PermitEmptyPasswords no
> >> +PermitEmptyPasswords yes
> >> 
> >> # Change to no to disable s/key passwords
> >> #ChallengeResponseAuthentication yes
> > 
> > We do already have logic in image.bbclass to set this based upon
> > debug-tweaks being in IMAGE_FEATURES; is that not working for you?
> 
> I haven't tried that, but that still doesn't fix the inconsistency issues
> and presents problems during package upgrades.

It shouldn't be an issue for package upgrades - ${sysconfdir}/ssh/sshd_config 
is included in CONFFILES for openssh-sshd.

Cheers,
Paul
Mark Hatle - Oct. 14, 2013, 1:46 p.m.
On 10/14/13 6:09 AM, Koen Kooi wrote:
>
> Op 14 okt. 2013, om 12:37 heeft Paul Eggleton <paul.eggleton@linux.intel.com> het volgende geschreven:
>
>> On Monday 14 October 2013 12:09:37 Koen Kooi wrote:
>>> Currently both PAM and dropbear allow logins with empty passwords, but
>>> openssh doesn't. This commit changes the default in openssh to allow
>>> empty password logins.
>>>
>>> This should be changed to be a global config option in the long run.
>>>
>>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>>> ---
>>> meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
>>> b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config index
>>> 4f9b626..175e8f3 100644
>>> --- a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
>>> +++ b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
>>> @@ -59,7 +59,7 @@ Protocol 2
>>>
>>> # To disable tunneled clear text passwords, change to no here!
>>> #PasswordAuthentication yes
>>> -#PermitEmptyPasswords no
>>> +PermitEmptyPasswords yes
>>>
>>> # Change to no to disable s/key passwords
>>> #ChallengeResponseAuthentication yes
>>
>> We do already have logic in image.bbclass to set this based upon debug-tweaks
>> being in IMAGE_FEATURES; is that not working for you?
>
> I haven't tried that, but that still doesn't fix the inconsistency issues and presents problems during package upgrades.

If the behavior is inconsistent, then the fix should be to PAM, dropbear and the 
debug-tweaks.  (I'm really wondering if this behavior should be able to be run 
w/o the rest of the debug-tweaks.)

But the default, for security purposes, should be no root login.

--Mark

> regards,
>
> Koen
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
index 4f9b626..175e8f3 100644
--- a/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
+++ b/meta/recipes-connectivity/openssh/openssh-6.2p2/sshd_config
@@ -59,7 +59,7 @@  Protocol 2
 
 # To disable tunneled clear text passwords, change to no here!
 #PasswordAuthentication yes
-#PermitEmptyPasswords no
+PermitEmptyPasswords yes
 
 # Change to no to disable s/key passwords
 #ChallengeResponseAuthentication yes