Patchwork [1/1] openssl: add Aarch64 bie-endian support

login
register
mail settings
Submitter Fathi Boudra
Date Oct. 12, 2013, 10:17 a.m.
Message ID <1381573062-29065-1-git-send-email-fathi.boudra@linaro.org>
Download mbox | patch
Permalink /patch/59733/
State New
Headers show

Comments

Fathi Boudra - Oct. 12, 2013, 10:17 a.m.
Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org>
Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
---
 .../openssl/openssl-1.0.1e/configure-targets.patch         | 14 ++++++--------
 meta/recipes-connectivity/openssl/openssl_1.0.1e.bb        |  2 +-
 2 files changed, 7 insertions(+), 9 deletions(-)
Otavio Salvador - Oct. 12, 2013, 5:59 p.m.
On Sat, Oct 12, 2013 at 7:17 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
...
> --- a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> +++ b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> @@ -6,7 +6,7 @@ DEPENDS += "ocf-linux"
>
>  CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
>
> -PR = "${INC_PR}.0"
> +PR = "${INC_PR}.1"
>
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=f9a8f968107345e0b75aa8c2ecaa7ec8"

Please don't change PR here; this is not need anymore for general use
(but exceptions).
Denys Dmytriyenko - Oct. 14, 2013, 4:24 p.m.
On Sat, Oct 12, 2013 at 02:59:19PM -0300, Otavio Salvador wrote:
> On Sat, Oct 12, 2013 at 7:17 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> > Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org>
> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ...
> > --- a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> > +++ b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
> > @@ -6,7 +6,7 @@ DEPENDS += "ocf-linux"
> >
> >  CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
> >
> > -PR = "${INC_PR}.0"
> > +PR = "${INC_PR}.1"
> >
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=f9a8f968107345e0b75aa8c2ecaa7ec8"
> 
> Please don't change PR here; this is not need anymore for general use
> (but exceptions).

And please correct the typo in the subject - it's big-endian, not bie-endian. 
Or did you mean bi-endian?
Fathi Boudra - Oct. 14, 2013, 5:41 p.m.
On 14 October 2013 19:24, Denys Dmytriyenko <denis@denix.org> wrote:
> On Sat, Oct 12, 2013 at 02:59:19PM -0300, Otavio Salvador wrote:
>> On Sat, Oct 12, 2013 at 7:17 AM, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> > Signed-off-by: Victor Kamensky <victor.kamensky@linaro.org>
>> > Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>> ...
>> > --- a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
>> > +++ b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
>> > @@ -6,7 +6,7 @@ DEPENDS += "ocf-linux"
>> >
>> >  CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
>> >
>> > -PR = "${INC_PR}.0"
>> > +PR = "${INC_PR}.1"
>> >
>> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=f9a8f968107345e0b75aa8c2ecaa7ec8"
>>
>> Please don't change PR here; this is not need anymore for general use
>> (but exceptions).
>
> And please correct the typo in the subject - it's big-endian, not bie-endian.
> Or did you mean bi-endian?

no, it's a typo (read the patch). I have a better fix to propose. this
one could go in the trash.

Patch

diff --git a/meta/recipes-connectivity/openssl/openssl-1.0.1e/configure-targets.patch b/meta/recipes-connectivity/openssl/openssl-1.0.1e/configure-targets.patch
index 8c638b4..d73b60d 100644
--- a/meta/recipes-connectivity/openssl/openssl-1.0.1e/configure-targets.patch
+++ b/meta/recipes-connectivity/openssl/openssl-1.0.1e/configure-targets.patch
@@ -2,16 +2,13 @@  Upstream-Status: Inappropriate [embedded specific]
 
 The number of colons are important :)
 
-
 ---
- Configure |   17 +++++++++++++++++
- 1 file changed, 17 insertions(+)
+ Configure |   18 ++++++++++++++++++
+ 1 file changed, 18 insertions(+)
 
-Index: openssl-1.0.1e/Configure
-===================================================================
---- openssl-1.0.1e.orig/Configure
-+++ openssl-1.0.1e/Configure
-@@ -403,6 +403,23 @@ my %table=(
+--- a/Configure
++++ b/Configure
+@@ -403,6 +403,24 @@ my %table=(
  "linux-alpha-ccc","ccc:-fast -readonly_strings -DL_ENDIAN -DTERMIO::-D_REENTRANT:::SIXTY_FOUR_BIT_LONG RC4_CHUNK DES_INT DES_PTR DES_RISC1 DES_UNROLL:${alpha_asm}",
  "linux-alpha+bwx-ccc","ccc:-fast -readonly_strings -DL_ENDIAN -DTERMIO::-D_REENTRANT:::SIXTY_FOUR_BIT_LONG RC4_CHAR RC4_CHUNK DES_INT DES_PTR DES_RISC1 DES_UNROLL:${alpha_asm}",
  
@@ -23,6 +20,7 @@  Index: openssl-1.0.1e/Configure
 +"linux-uclibceabi-arm","$ENV{'CC'}:-DL_ENDIAN -DTERMIO -O3 -fomit-frame-pointer -Wall::-D_REENTRANT::-ldl:BN_LLONG DES_RISC1:${no_asm}:dlfcn:linux-shared:-fPIC::.so.\$(SHLIB_MAJOR).\$(SHLIB_MINOR)",
 +"linux-uclibceabi-armeb","$ENV{'CC'}:-DB_ENDIAN -DTERMIO -O3 -fomit-frame-pointer -Wall::-D_REENTRANT::-ldl:BN_LLONG DES_RISC1:${no_asm}:dlfcn:linux-shared:-fPIC::.so.\$(SHLIB_MAJOR).\$(SHLIB_MINOR)",
 +"linux-aarch64","$ENV{'CC'}:-DL_ENDIAN -DTERMIO -O2 -pipe -g -feliminate-unused-debug-types -Wall -DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS::-D_REENTRANT::-ldl:SIXTY_FOUR_BIT_LONG RC4_CHAR RC4_CHUNK DES_INT DES_UNROLL BF_PTR:${no_asm}:dlfcn:linux-shared:-fPIC::.so.\$(SHLIB_MAJOR).\$(SHLIB_MINOR)",
++"linux-aarch64_be","$ENV{'CC'}:-DB_ENDIAN -DTERMIO -O2 -pipe -g -feliminate-unused-debug-types -Wall -Wa,--noexecstack -DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS::-D_REENTRANT::-ldl:SIXTY_FOUR_BIT_LONG RC4_CHAR RC4_CHUNK DES_INT DES_UNROLL BF_PTR:${no_asm}:dlfcn:linux-shared:-fPIC::.so.\$(SHLIB_MAJOR).\$(SHLIB_MINOR)",
 +
 +"linux-avr32","$ENV{'CC'}:-DTERMIO -O3 -fomit-frame-pointer -Wall::-D_REENTRANT::-ldl:BN_LLONG DES_RISC1:${no_asm}:dlfcn:linux-shared:-fPIC::.so.\$(SHLIB_MAJOR).",
 +
diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
index ac27dba..3494847 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.0.1e.bb
@@ -6,7 +6,7 @@  DEPENDS += "ocf-linux"
 
 CFLAG += "-DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS"
 
-PR = "${INC_PR}.0"
+PR = "${INC_PR}.1"
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=f9a8f968107345e0b75aa8c2ecaa7ec8"