Patchwork [v2] uboot-config.bbclass: Raise an error for unknown configs

login
register
mail settings
Submitter Otavio Salvador
Date Oct. 11, 2013, 3:59 p.m.
Message ID <1381507175-5904-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/59707/
State Accepted
Commit 5110dc988e3b8a1ce8b2309e4ddf17abb3f1cb0c
Headers show

Comments

Otavio Salvador - Oct. 11, 2013, 3:59 p.m.
When passing the wrong value for UBOOT_CONFIG it ought to raise an
error otherwise it is quite difficult for user to notice it didn't
behave as expected.

Reported-by: Lauren Post <lauren.post@freescale.com>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v2:
- Use ValueError as exception

 meta/classes/uboot-config.bbclass | 5 +++++
 1 file changed, 5 insertions(+)

Patch

diff --git a/meta/classes/uboot-config.bbclass b/meta/classes/uboot-config.bbclass
index ba01bff..5068f49 100644
--- a/meta/classes/uboot-config.bbclass
+++ b/meta/classes/uboot-config.bbclass
@@ -51,4 +51,9 @@  python () {
             if len(items) > 1 and items[1]:
                 bb.debug(1, "Appending '%s' to IMAGE_FSTYPES." % items[1])
                 d.appendVar('IMAGE_FSTYPES', ' ' + items[1])
+
+            # Go out as we found a match!
+            break
+    else:
+        raise ValueError("UBOOT_CONFIG %s is not supported" % ubootconfig)
 }