Patchwork [[meta-oe,1/3] xf86-video-geode: add 2.11.12 version recipe

login
register
mail settings
Submitter Otavio Salvador
Date June 14, 2011, 4:49 p.m.
Message ID <c8746f02a08b8529448e09e7d2e2f28b2ae05bf2.1308070134.git.otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/5937/
State New, archived
Headers show

Comments

Otavio Salvador - June 14, 2011, 4:49 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../xorg-driver/xf86-video-geode_2.11.12.bb        |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
Paul Menzel - June 15, 2011, 9:57 a.m.
Dear Otavio,


Am Dienstag, den 14.06.2011, 16:49 +0000 schrieb Otavio Salvador:

1. You could leave out recipe from the commit summary.

»Add version 2.11.12« should suffice.

2. Please add the necessary information to the commit message as
recommended in the commit message guidelines [1].

As far as I can see you imported this recipe from oe.dev.

> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  .../xorg-driver/xf86-video-geode_2.11.12.bb        |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
> 
> diff --git a/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb b/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
> new file mode 100644
> index 0000000..d14d63e
> --- /dev/null
> +++ b/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
> @@ -0,0 +1,11 @@
> +require xorg-driver-video.inc
> +LIC_FILES_CHKSUM = "file://COPYING;md5=f8ad89d9d9a024f19d7dcc5acb044a42"
> +
> +DESCRIPTION = "X.org server -- Geode GX2/LX display driver"
> +PE = "1"

Why is that needed? There are not colons in the version nor did the
versioning mess up [2] since it is an import.

> +PR = "${INC_PR}.0"
> +
> +SRC_URI[md5sum] = "a99c521db731c2f1df309057a8465e4c"
> +SRC_URI[sha256sum] = "28d845d727d99bfa4d4b93c5486ec01b72eb222e0910a766089db1103b1c2d92"
> +
> +COMPATIBLE_HOST = "i.86.*-linux"


Thanks,

Paul


[1] http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines
[2] http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version
Otavio Salvador - June 15, 2011, 12:22 p.m.
On Wed, Jun 15, 2011 at 09:57, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> 2. Please add the necessary information to the commit message as
> recommended in the commit message guidelines [1].
>
> As far as I can see you imported this recipe from oe.dev.

In fact no ... it is based on an old version from OE that I changes to
look like we're using today.

But AFAIK it is on Koen queue already so too late to change.
Paul Menzel - June 15, 2011, 12:34 p.m.
Am Mittwoch, den 15.06.2011, 12:22 +0000 schrieb Otavio Salvador:
> On Wed, Jun 15, 2011 at 09:57, Paul Menzel wrote:
> > 2. Please add the necessary information to the commit message as
> > recommended in the commit message guidelines [1].
> >
> > As far as I can see you imported this recipe from oe.dev.
> 
> In fact no ... it is based on an old version from OE that I changes to
> look like we're using today.

So you just changed the checksums and added the `LICENSE` field?

Could also please answer why setting `PE` is needed.

> But AFAIK it is on Koen queue already so too late to change.

Koen has not pushed them yet so it is not too late in my opinion.


Thanks,

Paul
Otavio Salvador - June 15, 2011, 12:59 p.m.
On Wed, Jun 15, 2011 at 12:34, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
>> In fact no ... it is based on an old version from OE that I changes to
>> look like we're using today.
>
> So you just changed the checksums and added the `LICENSE` field?

I don't recall exactly what I did but I guess so.

> Could also please answer why setting `PE` is needed.

It had it already IIRC.

>> But AFAIK it is on Koen queue already so too late to change.
>
> Koen has not pushed them yet so it is not too late in my opinion.

I asked him to drop it and wait for a new version.
Koen Kooi - June 15, 2011, 1:09 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 15-06-11 14:59, Otavio Salvador wrote:
> On Wed, Jun 15, 2011 at 12:34, Paul Menzel
> <paulepanter@users.sourceforge.net> wrote:
>>> In fact no ... it is based on an old version from OE that I changes to
>>> look like we're using today.
>>
>> So you just changed the checksums and added the `LICENSE` field?
> 
> I don't recall exactly what I did but I guess so.
> 
>> Could also please answer why setting `PE` is needed.
> 
> It had it already IIRC.

Historical reasons, it's from the x11r6 -> x11r7 -> 1.0 transitions.
I've been silently dropping them when adding X recipes to meta-oe

>>> But AFAIK it is on Koen queue already so too late to change.
>>
>> Koen has not pushed them yet so it is not too late in my opinion.
> 
> I asked him to drop it and wait for a new version.

Done

regards,

Koen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN+K8SMkyGM64RGpERAhvUAJ9X3VZqVqEEScWwS9Z0QfStYDWWZQCfel3u
KGvvI5FMR58T1O1jm/NGqag=
=klWr
-----END PGP SIGNATURE-----
Otavio Salvador - June 15, 2011, 1:35 p.m.
On Wed, Jun 15, 2011 at 13:09, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>> Could also please answer why setting `PE` is needed.
>>
>> It had it already IIRC.
>
> Historical reasons, it's from the x11r6 -> x11r7 -> 1.0 transitions.
> I've been silently dropping them when adding X recipes to meta-oe

Ok; I will drop it here then.

Patch

diff --git a/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb b/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
new file mode 100644
index 0000000..d14d63e
--- /dev/null
+++ b/meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.12.bb
@@ -0,0 +1,11 @@ 
+require xorg-driver-video.inc
+LIC_FILES_CHKSUM = "file://COPYING;md5=f8ad89d9d9a024f19d7dcc5acb044a42"
+
+DESCRIPTION = "X.org server -- Geode GX2/LX display driver"
+PE = "1"
+PR = "${INC_PR}.0"
+
+SRC_URI[md5sum] = "a99c521db731c2f1df309057a8465e4c"
+SRC_URI[sha256sum] = "28d845d727d99bfa4d4b93c5486ec01b72eb222e0910a766089db1103b1c2d92"
+
+COMPATIBLE_HOST = "i.86.*-linux"