Patchwork [1/5] gnome-desktop-testing: add

login
register
mail settings
Submitter Ross Burton
Date Oct. 7, 2013, 5:49 p.m.
Message ID <1381168150-25518-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/59351/
State Accepted
Commit 4657b9a35e276b0891729d43f33db49ee5e3ae7d
Headers show

Comments

Ross Burton - Oct. 7, 2013, 5:49 p.m.
gnome-desktop-testing is a test runner for GNOME-style Installed Tests, and will
be used by run-ptest to execute these unit test suites.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 .../files/no-introspection.patch                    |   19 +++++++++++++++++++
 .../gnome-desktop-testing_2013.1.bb                 |   18 ++++++++++++++++++
 2 files changed, 37 insertions(+)
 create mode 100644 meta/recipes-support/gnome-desktop-testing/files/no-introspection.patch
 create mode 100644 meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing_2013.1.bb
Fathi Boudra - Oct. 15, 2013, 8:37 a.m.
On 15 October 2013 09:31, Iorga, Cristian <cristian.iorga@intel.com> wrote:
> Hello,
>
> This patch has been merged with incorrect version in commit description.
> Upgraded to version 2.38.0, not version 2.28.0, as in description.
> Regards,
> Cristian
>
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Ross Burton
> Sent: Monday, October 07, 2013 8:49 PM
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 2/5] glib-2.0: upgrade to 2.28.0
>
> Drop the ptest patches and instead use --enable-installed-tests, updating run-ptest to invoke gnome-desktop-testing-runner.
>
> Drop the x32 build patch, upstream has integrated a similar fix.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>

it fails to build on Aarch64:
| gdbusprivate.c: In function 'write_message_print_transport_debug':
| gdbusprivate.c:2164:12: error: format '%lu' expects argument of type
'long unsigned int', but argument 2 has type 'gssize'
[-Werror=format=]
|             g_type_name (G_TYPE_FROM_INSTANCE
(g_io_stream_get_output_stream (data->worker->stream))));
|             ^
Ross Burton - Oct. 15, 2013, 9:43 a.m.
On 15 October 2013 09:37, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> it fails to build on Aarch64:
> | gdbusprivate.c: In function 'write_message_print_transport_debug':
> | gdbusprivate.c:2164:12: error: format '%lu' expects argument of type
> 'long unsigned int', but argument 2 has type 'gssize'
> [-Werror=format=]
> |             g_type_name (G_TYPE_FROM_INSTANCE
> (g_io_stream_get_output_stream (data->worker->stream))));
> |             ^

I don't have any aarch64 hardware to test on, can you work with
upstream to get a fix and submit it here?

Ross
Riku Voipio - Oct. 15, 2013, 11:05 a.m.
On 15 October 2013 12:43, Burton, Ross <ross.burton@intel.com> wrote:
> On 15 October 2013 09:37, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> it fails to build on Aarch64:
>> | gdbusprivate.c: In function 'write_message_print_transport_debug':
>> | gdbusprivate.c:2164:12: error: format '%lu' expects argument of type
>> 'long unsigned int', but argument 2 has type 'gssize'
>> [-Werror=format=]
>> |             g_type_name (G_TYPE_FROM_INSTANCE
>> (g_io_stream_get_output_stream (data->worker->stream))));
>> |             ^
>
> I don't have any aarch64 hardware to test on, can you work with
> upstream to get a fix and submit it here?

This is fixed upstream in:

https://git.gnome.org/browse/glib/commit/?id=0167c3340d8201dca8e9031b61703bbc5ed6ce33

I'll submit a patch in a moment.

Riku

Patch

diff --git a/meta/recipes-support/gnome-desktop-testing/files/no-introspection.patch b/meta/recipes-support/gnome-desktop-testing/files/no-introspection.patch
new file mode 100644
index 0000000..67b64f2
--- /dev/null
+++ b/meta/recipes-support/gnome-desktop-testing/files/no-introspection.patch
@@ -0,0 +1,19 @@ 
+Introspection is a hard requirement to build gnome-desktop-testing upstream, but
+it isn't needed anymore.
+
+Upstream-Status: Submitted
+Signed-off-by: Ross Burton <ross.burton@intel.com>
+
+diff --git a/configure.ac b/configure.ac
+index 7460c69..6249caf 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -27,8 +27,6 @@ AC_SUBST(WARN_CFLAGS)
+ LT_PREREQ([2.2.4])
+ LT_INIT([disable-static])
+ 
+-GOBJECT_INTROSPECTION_REQUIRE([1.34.0])
+-
+ PKG_CHECK_MODULES(GIO_UNIX, [gio-unix-2.0 >= 2.34.0])
+ GIO_UNIX_CFLAGS="$GIO_UNIX_CFLAGS -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_36 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_36"
+ 
diff --git a/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing_2013.1.bb b/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing_2013.1.bb
new file mode 100644
index 0000000..36e13b1
--- /dev/null
+++ b/meta/recipes-support/gnome-desktop-testing/gnome-desktop-testing_2013.1.bb
@@ -0,0 +1,18 @@ 
+SUMMARY = "Test runner for GNOME-style installed tests"
+HOMEPAGE = "https://wiki.gnome.org/GnomeGoals/InstalledTests"
+LICENSE = "LGPLv2+"
+
+SRC_URI = "${GNOME_MIRROR}/${BPN}/${PV}/${BPN}-${PV}.tar.xz \
+           file://no-introspection.patch"
+SRC_URI[md5sum] = "c6824f7bfac95bf0fcf6ed0c255979c1"
+SRC_URI[sha256sum] = "632e7224de8614a8e4b7cdf87fc32551531efa9290fba0da4dae56234c584b7b"
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=3bf50002aefd002f49e7bb854063f7e7 \
+                    file://src/gnome-desktop-testing-runner.c;endline=19;md5=ab86a2e00ab9cbb94f008d785004b181"
+
+DEPENDS = "glib-2.0"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[journald] = "--with-systemd-journal,--without-systemd-journal,systemd,systemd"