Patchwork [[meta-oe,3/3] freerdp-extension-xpunlimited: bump SRCREV due library renaming

login
register
mail settings
Submitter Otavio Salvador
Date June 14, 2011, 4:49 p.m.
Message ID <7f3cc6bd9bc16d66b66f7fded64aff1b1f8c3820.1308070134.git.otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/5931/
State New, archived
Headers show

Comments

Otavio Salvador - June 14, 2011, 4:49 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../freerdp/freerdp-extension-xpunlimited_git.bb   |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Paul Menzel - June 15, 2011, 10 a.m.
Dear Otavio,


Am Dienstag, den 14.06.2011, 16:49 +0000 schrieb Otavio Salvador:

nitpick: I think it is due *to*.

Additionally it would be nice, if you could be more elaborate what
library was renamed. An URL would be good enough.

Additionally in my opinion it would be great if you could add a short
note what build configuration you used for testing.

> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  .../freerdp/freerdp-extension-xpunlimited_git.bb   |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
> index 4fc6928..c9721f4 100644
> --- a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
> +++ b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
> @@ -14,7 +14,7 @@ PR = "r0"
>  
>  inherit pkgconfig cmake
>  
> -SRCREV = "d27f90a0128c687ce74cc922dba8b7eeb33f0654"
> +SRCREV = "e952627ff4c116b4ce8541c91cb96bd5422c4a0d"
>  SRC_URI = "git://github.com/OSSystems/FreeRDP-Extension-XPUnlimited.git;protocol=git"
>  
>  S = "${WORKDIR}/git"


Thanks,

Paul
Otavio Salvador - June 15, 2011, 12:18 p.m.
On Wed, Jun 15, 2011 at 10:00, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> nitpick: I think it is due *to*.

AFAIK Koen has already put it on his queue.

> Additionally it would be nice, if you could be more elaborate what
> library was renamed. An URL would be good enough.

FreeRDP has not a big refactoring and thus libfreerdp has been renamed
to libfreerdp-core.

> Additionally in my opinion it would be great if you could add a short
> note what build configuration you used for testing.

I don't see this on commit messages comming to the ml; why is it need
for this case?
Koen Kooi - June 15, 2011, 12:33 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 15-06-11 14:18, Otavio Salvador wrote:
> On Wed, Jun 15, 2011 at 10:00, Paul Menzel
> <paulepanter@users.sourceforge.net> wrote:
>> nitpick: I think it is due *to*.
> 
> AFAIK Koen has already put it on his queue.

I haven't pushed it yet since there were other problems getting in the
way of build testing, so feel free to update your branch :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN+KapMkyGM64RGpERAmAHAJ4qZsIZO3n9cYB6WHiR3T2zQfAalwCeKRaT
gt47A70Zqm+eZ6l4WzOAUVI=
=hS3g
-----END PGP SIGNATURE-----
Paul Menzel - June 15, 2011, 12:37 p.m.
Am Mittwoch, den 15.06.2011, 12:18 +0000 schrieb Otavio Salvador:
> On Wed, Jun 15, 2011 at 10:00, Paul Menzel
> <paulepanter@users.sourceforge.net> wrote:
> > nitpick: I think it is due *to*.
> 
> AFAIK Koen has already put it on his queue.

But he has not pushed them yet.

> > Additionally it would be nice, if you could be more elaborate what
> > library was renamed. An URL would be good enough.
> 
> FreeRDP has not a big refactoring and thus libfreerdp has been renamed
> to libfreerdp-core.

Thank you.

> > Additionally in my opinion it would be great if you could add a short
> > note what build configuration you used for testing.
> 
> I don't see this on commit messages comming to the ml; why is it need
> for this case?

It is not required. But I had enough cases where I had (build) problems
with commits and it would have saved me time to be able to reproduce a
successful build. That is why I ask for it when I do reviews.


Thanks,

Paul
Otavio Salvador - June 15, 2011, 12:53 p.m.
On Wed, Jun 15, 2011 at 12:33, Koen Kooi <koen@dominion.thruhere.net> wrote:
> I haven't pushed it yet since there were other problems getting in the
> way of build testing, so feel free to update your branch :)

Please drop those 3 patches then. I will resend them on the end of
week or when I have more fixes. They're not urgent.

I fixed them locally already.

Patch

diff --git a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
index 4fc6928..c9721f4 100644
--- a/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
+++ b/meta-oe/recipes-support/freerdp/freerdp-extension-xpunlimited_git.bb
@@ -14,7 +14,7 @@  PR = "r0"
 
 inherit pkgconfig cmake
 
-SRCREV = "d27f90a0128c687ce74cc922dba8b7eeb33f0654"
+SRCREV = "e952627ff4c116b4ce8541c91cb96bd5422c4a0d"
 SRC_URI = "git://github.com/OSSystems/FreeRDP-Extension-XPUnlimited.git;protocol=git"
 
 S = "${WORKDIR}/git"