Patchwork oe-buildenv-internal: Add UBOOT_CONFIG to environment whitelist

login
register
mail settings
Submitter Otavio Salvador
Date Oct. 4, 2013, 10:22 p.m.
Message ID <1380925365-18427-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/59283/
State New
Headers show

Comments

Otavio Salvador - Oct. 4, 2013, 10:22 p.m.
The uboot-config class uses the UBOOT_CONFIG environment setting to
choose which U-Boot option is intended to build. It is convenient to
allow it to be set from the shell, as supported for MACHINE.

This allow, for example, to trigger a build as:

,----
| MACHINE=imx28evk UBOOT_CONFIG=nand bitbake core-image-minimal
`----

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 scripts/oe-buildenv-internal | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Purdie - Oct. 6, 2013, 8:57 a.m.
On Fri, 2013-10-04 at 19:22 -0300, Otavio Salvador wrote:
> The uboot-config class uses the UBOOT_CONFIG environment setting to
> choose which U-Boot option is intended to build. It is convenient to
> allow it to be set from the shell, as supported for MACHINE.
> 
> This allow, for example, to trigger a build as:
> 
> ,----
> | MACHINE=imx28evk UBOOT_CONFIG=nand bitbake core-image-minimal
> `----
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  scripts/oe-buildenv-internal | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

There are lots of things which we can expose from the shell, we only
really want to default to be things which are commonly changed though.
How often do people realistically change their uboot targets? I
appreciate that when working on uboot its useful but I don't think this
is a significant portion of the userbase?

Cheers,

Richard

> diff --git a/scripts/oe-buildenv-internal b/scripts/oe-buildenv-internal
> index bba6f8f..f8840c1 100755
> --- a/scripts/oe-buildenv-internal
> +++ b/scripts/oe-buildenv-internal
> @@ -106,4 +106,4 @@ export BB_ENV_EXTRAWHITE="MACHINE DISTRO TCMODE TCLIBC HTTP_PROXY http_proxy \
>  HTTPS_PROXY https_proxy FTP_PROXY ftp_proxy FTPS_PROXY ftps_proxy ALL_PROXY \
>  all_proxy NO_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK BB_SRCREV_POLICY \
>  SDKMACHINE BB_NUMBER_THREADS BB_NO_NETWORK PARALLEL_MAKE GIT_PROXY_COMMAND \
> -SOCKS5_PASSWD SOCKS5_USER SCREENDIR STAMPS_DIR"
> +SOCKS5_PASSWD SOCKS5_USER SCREENDIR STAMPS_DIR UBOOT_CONFIG"
Otavio Salvador - Oct. 6, 2013, 6:08 p.m.
On Sun, Oct 6, 2013 at 5:57 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2013-10-04 at 19:22 -0300, Otavio Salvador wrote:
>> The uboot-config class uses the UBOOT_CONFIG environment setting to
>> choose which U-Boot option is intended to build. It is convenient to
>> allow it to be set from the shell, as supported for MACHINE.
>>
>> This allow, for example, to trigger a build as:
>>
>> ,----
>> | MACHINE=imx28evk UBOOT_CONFIG=nand bitbake core-image-minimal
>> `----
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>>  scripts/oe-buildenv-internal | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> There are lots of things which we can expose from the shell, we only
> really want to default to be things which are commonly changed though.
> How often do people realistically change their uboot targets? I
> appreciate that when working on uboot its useful but I don't think this
> is a significant portion of the userbase?

Well this is hard to guess; I know this is important for me ask we
used it daily.

Besides that it is something which is very tied to the machine and it
makes sense to be to be allowed to override it from shell, as this
easy user's life in development and testing.

Patch

diff --git a/scripts/oe-buildenv-internal b/scripts/oe-buildenv-internal
index bba6f8f..f8840c1 100755
--- a/scripts/oe-buildenv-internal
+++ b/scripts/oe-buildenv-internal
@@ -106,4 +106,4 @@  export BB_ENV_EXTRAWHITE="MACHINE DISTRO TCMODE TCLIBC HTTP_PROXY http_proxy \
 HTTPS_PROXY https_proxy FTP_PROXY ftp_proxy FTPS_PROXY ftps_proxy ALL_PROXY \
 all_proxy NO_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK BB_SRCREV_POLICY \
 SDKMACHINE BB_NUMBER_THREADS BB_NO_NETWORK PARALLEL_MAKE GIT_PROXY_COMMAND \
-SOCKS5_PASSWD SOCKS5_USER SCREENDIR STAMPS_DIR"
+SOCKS5_PASSWD SOCKS5_USER SCREENDIR STAMPS_DIR UBOOT_CONFIG"