Patchwork [meta-oe] netperf: set _FILE_OFFSET_BITS to 64 to support large files

login
register
mail settings
Submitter Ting Liu
Date Sept. 26, 2013, 9:20 a.m.
Message ID <1380187231-23854-1-git-send-email-b28495@freescale.com>
Download mbox | patch
Permalink /patch/59013/
State Superseded, archived
Headers show

Comments

Ting Liu - Sept. 26, 2013, 9:20 a.m.
From: Ting Liu <b28495@freescale.com>

Without this patch, netperf2.6 can only
support files smaller than 2GB with TCP_SENDFILE item.

Signed-off-by: Ting Liu <b28495@freescale.com>
Tested-by: Jianhua Xie<jianhua.xie@freescale.com>
---
 .../recipes-support/netperf/netperf_2.6.0.bb       |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Otavio Salvador - Sept. 26, 2013, 9:35 p.m.
On Thu, Sep 26, 2013 at 6:20 AM,  <b28495@freescale.com> wrote:
> From: Ting Liu <b28495@freescale.com>
>
> Without this patch, netperf2.6 can only
> support files smaller than 2GB with TCP_SENDFILE item.
>
> Signed-off-by: Ting Liu <b28495@freescale.com>
> Tested-by: Jianhua Xie<jianhua.xie@freescale.com>

Please make it conditional as:

 ${@base_contains('DISTRO_FEATURES', 'largefile',
'D_FILE_OFFSET_BITS=64', '', d)}
Martin Jansa - Oct. 5, 2013, 11:27 a.m.
On Thu, Sep 26, 2013 at 05:20:31PM +0800, b28495@freescale.com wrote:
> From: Ting Liu <b28495@freescale.com>
> 
> Without this patch, netperf2.6 can only
> support files smaller than 2GB with TCP_SENDFILE item.
> 
> Signed-off-by: Ting Liu <b28495@freescale.com>
> Tested-by: Jianhua Xie<jianhua.xie@freescale.com>
> ---
>  .../recipes-support/netperf/netperf_2.6.0.bb       |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/meta-networking/recipes-support/netperf/netperf_2.6.0.bb b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> index eda7859..1d9ba20 100644
> --- a/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> +++ b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> @@ -23,6 +23,10 @@ S = "${WORKDIR}/netperf-${PV}"
>  # cpu_set.patch plus _GNU_SOURCE makes src/netlib.c compile with CPU_ macros
>  CFLAGS_append = " -DDO_UNIX -DDO_IPV6 -D_GNU_SOURCE"
>  
> +# set the "_FILE_OFFSET_BITS" preprocessor symbol to 64 to support files 
> +# larger than 2GB
> +CFLAGS_append = " -D_FILE_OFFSET_BITS=64"
> +

http://patchwork.openembedded.org/patch/57331/
This patch is superseded, right?

Please update as Otavio requested.

>  # autotools.bbclass attends to include m4 files with path depth <= 2 by
>  # "find ${S} -maxdepth 2 -name \*.m4", so move m4 files from m4/m4.
>  do_configure_prepend() {
> -- 
> 1.7.3.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Ting Liu - Oct. 9, 2013, 8:35 a.m.
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Martin Jansa
> Sent: Saturday, October 05, 2013 7:27 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [meta-oe][PATCH] netperf: set _FILE_OFFSET_BITS to 64
> to support large files
> 
> On Thu, Sep 26, 2013 at 05:20:31PM +0800, b28495@freescale.com wrote:
> > From: Ting Liu <b28495@freescale.com>
> >
> > Without this patch, netperf2.6 can only support files smaller than 2GB
> > with TCP_SENDFILE item.
> >
> > Signed-off-by: Ting Liu <b28495@freescale.com>
> > Tested-by: Jianhua Xie<jianhua.xie@freescale.com>
> > ---
> >  .../recipes-support/netperf/netperf_2.6.0.bb       |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> > b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> > index eda7859..1d9ba20 100644
> > --- a/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> > +++ b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
> > @@ -23,6 +23,10 @@ S = "${WORKDIR}/netperf-${PV}"
> >  # cpu_set.patch plus _GNU_SOURCE makes src/netlib.c compile with CPU_
> > macros  CFLAGS_append = " -DDO_UNIX -DDO_IPV6 -D_GNU_SOURCE"
> >
> > +# set the "_FILE_OFFSET_BITS" preprocessor symbol to 64 to support
> > +files # larger than 2GB CFLAGS_append = " -D_FILE_OFFSET_BITS=64"
> > +
> 
> http://patchwork.openembedded.org/patch/57331/
> This patch is superseded, right?

Yes, it is superseded.

> 
> Please update as Otavio requested.

I have sent the v2 patch. Thanks for your review.

> 
> >  # autotools.bbclass attends to include m4 files with path depth <= 2
> > by  # "find ${S} -maxdepth 2 -name \*.m4", so move m4 files from m4/m4.
> >  do_configure_prepend() {
> > --
> > 1.7.3.4
> >
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> 
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Patch

diff --git a/meta-networking/recipes-support/netperf/netperf_2.6.0.bb b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
index eda7859..1d9ba20 100644
--- a/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
+++ b/meta-networking/recipes-support/netperf/netperf_2.6.0.bb
@@ -23,6 +23,10 @@  S = "${WORKDIR}/netperf-${PV}"
 # cpu_set.patch plus _GNU_SOURCE makes src/netlib.c compile with CPU_ macros
 CFLAGS_append = " -DDO_UNIX -DDO_IPV6 -D_GNU_SOURCE"
 
+# set the "_FILE_OFFSET_BITS" preprocessor symbol to 64 to support files 
+# larger than 2GB
+CFLAGS_append = " -D_FILE_OFFSET_BITS=64"
+
 # autotools.bbclass attends to include m4 files with path depth <= 2 by
 # "find ${S} -maxdepth 2 -name \*.m4", so move m4 files from m4/m4.
 do_configure_prepend() {