Patchwork [meta-oe,2/2] opencv: adding libeigen dependency

login
register
mail settings
Submitter Lukas Bulwahn
Date Sept. 24, 2013, 2:12 p.m.
Message ID <1380031928-29350-2-git-send-email-lukas.bulwahn@oss.bmw-carit.de>
Download mbox | patch
Permalink /patch/58673/
State Accepted, archived
Commit d6577d80ec37d335d4909e113ca9f8e077e19742
Headers show

Comments

Lukas Bulwahn - Sept. 24, 2013, 2:12 p.m.
In the opencv's CMakeLists.txt under Optional 3rd party components,
the option "WITH_EIGEN" is by default ON. Hence, this commit adds
the libeigen dependency to opencv.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
---
 meta-oe/recipes-support/opencv/opencv_2.4.3.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Khem Raj - Sept. 24, 2013, 4:09 p.m.
Lukas

Thanks for patch. while you are at it. Can you convert this to be a PACKAGECONFIG as well ?


On Sep 24, 2013, at 7:12 AM, Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de> wrote:

> In the opencv's CMakeLists.txt under Optional 3rd party components,
> the option "WITH_EIGEN" is by default ON. Hence, this commit adds
> the libeigen dependency to opencv.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de>
> ---
> meta-oe/recipes-support/opencv/opencv_2.4.3.bb |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-oe/recipes-support/opencv/opencv_2.4.3.bb b/meta-oe/recipes-support/opencv/opencv_2.4.3.bb
> index 39b608a..21a4f06 100644
> --- a/meta-oe/recipes-support/opencv/opencv_2.4.3.bb
> +++ b/meta-oe/recipes-support/opencv/opencv_2.4.3.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://include/opencv2/opencv.hpp;endline=41;md5=6d690d8488a
> 
> ARM_INSTRUCTION_SET = "arm"
> 
> -DEPENDS = "python-numpy v4l-utils libav gtk+ libtool swig swig-native python jpeg bzip2 zlib libpng tiff glib-2.0"
> +DEPENDS = "python-numpy v4l-utils libav gtk+ libtool swig swig-native python jpeg bzip2 zlib libpng tiff glib-2.0 libeigen"




> 
> SRC_URI = "${SOURCEFORGE_MIRROR}/opencvlibrary/opencv-unix/${PV}/OpenCV-${PV}.tar.bz2 \
>            file://opencv-fix-pkgconfig-generation.patch \
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Lukas Bulwahn - Sept. 27, 2013, 9:40 a.m.
On 09/24/2013 06:09 PM, Khem Raj wrote:
> Lukas
>
> Thanks for patch. while you are at it. Can you convert this to be a PACKAGECONFIG as well ?
>
>
Hi Khem,

I have just created a patch for this to be a PACKAGECONFIG. Now, I only 
have to test and review them. Expect the revised patches next week.

Lukas

Patch

diff --git a/meta-oe/recipes-support/opencv/opencv_2.4.3.bb b/meta-oe/recipes-support/opencv/opencv_2.4.3.bb
index 39b608a..21a4f06 100644
--- a/meta-oe/recipes-support/opencv/opencv_2.4.3.bb
+++ b/meta-oe/recipes-support/opencv/opencv_2.4.3.bb
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://include/opencv2/opencv.hpp;endline=41;md5=6d690d8488a
 
 ARM_INSTRUCTION_SET = "arm"
 
-DEPENDS = "python-numpy v4l-utils libav gtk+ libtool swig swig-native python jpeg bzip2 zlib libpng tiff glib-2.0"
+DEPENDS = "python-numpy v4l-utils libav gtk+ libtool swig swig-native python jpeg bzip2 zlib libpng tiff glib-2.0 libeigen"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/opencvlibrary/opencv-unix/${PV}/OpenCV-${PV}.tar.bz2 \
            file://opencv-fix-pkgconfig-generation.patch \