Patchwork [PATCH/RFC] autotools: handle dependency on intltool-native

login
register
mail settings
Submitter Eric BENARD
Date Sept. 23, 2013, 8:06 a.m.
Message ID <1379923619-27142-1-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/58521/
State New
Headers show

Comments

Eric BENARD - Sept. 23, 2013, 8:06 a.m.
autotools' class can use intltoolize but has no dependency on it
which can leads to :
/test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found

This patch fix this problem by adding the dependency on
intltool-native which can be tricky as it triggers
circular dependencies very easily.

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 meta/classes/autotools.bbclass | 1 +
 1 file changed, 1 insertion(+)
Richard Purdie - Sept. 23, 2013, 11:24 a.m.
On Mon, 2013-09-23 at 10:06 +0200, Eric Bénard wrote:
> autotools' class can use intltoolize but has no dependency on it
> which can leads to :
> /test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found
> 
> This patch fix this problem by adding the dependency on
> intltool-native which can be tricky as it triggers
> circular dependencies very easily.
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>  meta/classes/autotools.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> index 883eb06..eb988cb 100644
> --- a/meta/classes/autotools.bbclass
> +++ b/meta/classes/autotools.bbclass
> @@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
>                          and not bb.data.inherits_class('cross', d) \
>                          and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
>              deps += 'libtool-cross '
> +            deps += 'intltool-native '
>  
>      return deps + 'gnu-config-native '

Its expected that recipes using that add to DEPENDS. Please lets not add
in the dependency for everyone since it isn't actually used in that many
places. Its small details like this which end up causing significant
performance issues :/.

Cheers,

Richard
Eric BENARD - Sept. 23, 2013, 11:53 a.m.
Le Mon, 23 Sep 2013 12:24:17 +0100,
Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :

> On Mon, 2013-09-23 at 10:06 +0200, Eric Bénard wrote:
> > autotools' class can use intltoolize but has no dependency on it
> > which can leads to :
> > /test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found
> > 
> > This patch fix this problem by adding the dependency on
> > intltool-native which can be tricky as it triggers
> > circular dependencies very easily.
> > 
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > ---
> >  meta/classes/autotools.bbclass | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> > index 883eb06..eb988cb 100644
> > --- a/meta/classes/autotools.bbclass
> > +++ b/meta/classes/autotools.bbclass
> > @@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
> >                          and not bb.data.inherits_class('cross', d) \
> >                          and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
> >              deps += 'libtool-cross '
> > +            deps += 'intltool-native '
> >  
> >      return deps + 'gnu-config-native '
> 
> Its expected that recipes using that add to DEPENDS. Please lets not add
> in the dependency for everyone since it isn't actually used in that many
> places. Its small details like this which end up causing significant
> performance issues :/.
> 
OK agreed. Would you accept a patch to add this in comment in
autotools.bbclass so that this gets documented somewhere ?

Eric
Richard Purdie - Sept. 23, 2013, 2:34 p.m.
On Mon, 2013-09-23 at 13:53 +0200, Eric Bénard wrote:
> Le Mon, 23 Sep 2013 12:24:17 +0100,
> Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :
> 
> > On Mon, 2013-09-23 at 10:06 +0200, Eric Bénard wrote:
> > > autotools' class can use intltoolize but has no dependency on it
> > > which can leads to :
> > > /test/setup-scripts/build/tmp-defaultsetup-eglibc-eglibc/work/cortexa9hf-vfp-neon-oe-linux-gnueabi/gnokii/0.6.31-r0/temp/run.do_configure.7559: line 179: intltoolize: command not found
> > > 
> > > This patch fix this problem by adding the dependency on
> > > intltool-native which can be tricky as it triggers
> > > circular dependencies very easily.
> > > 
> > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > ---
> > >  meta/classes/autotools.bbclass | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
> > > index 883eb06..eb988cb 100644
> > > --- a/meta/classes/autotools.bbclass
> > > +++ b/meta/classes/autotools.bbclass
> > > @@ -16,6 +16,7 @@ def autotools_dep_prepend(d):
> > >                          and not bb.data.inherits_class('cross', d) \
> > >                          and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
> > >              deps += 'libtool-cross '
> > > +            deps += 'intltool-native '
> > >  
> > >      return deps + 'gnu-config-native '
> > 
> > Its expected that recipes using that add to DEPENDS. Please lets not add
> > in the dependency for everyone since it isn't actually used in that many
> > places. Its small details like this which end up causing significant
> > performance issues :/.
> > 
> OK agreed. Would you accept a patch to add this in comment in
> autotools.bbclass so that this gets documented somewhere ?

Yes.

Cheers,

Richard

Patch

diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index 883eb06..eb988cb 100644
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -16,6 +16,7 @@  def autotools_dep_prepend(d):
                         and not bb.data.inherits_class('cross', d) \
                         and not d.getVar('INHIBIT_DEFAULT_DEPS', True):
             deps += 'libtool-cross '
+            deps += 'intltool-native '
 
     return deps + 'gnu-config-native '