Patchwork connman: Upgrade to v1.18

login
register
mail settings
Submitter Shakeel, Muhammad
Date Sept. 19, 2013, 12:52 p.m.
Message ID <1379595133-5812-1-git-send-email-muhammad_shakeel@mentor.com>
Download mbox | patch
Permalink /patch/58367/
State New
Headers show

Comments

Shakeel, Muhammad - Sept. 19, 2013, 12:52 p.m.
From: Muhammad Shakeel <muhammad_shakeel@mentor.com>

-This release contains a few important bugfixes in addition
to a few new features.
-Also remove some obsolete configurations from EXTRA_OECONF

Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
---
 meta/recipes-connectivity/connman/connman.inc     |    2 --
 meta/recipes-connectivity/connman/connman_1.17.bb |   14 --------------
 meta/recipes-connectivity/connman/connman_1.18.bb |   14 ++++++++++++++
 3 files changed, 14 insertions(+), 16 deletions(-)
Richard Purdie - Sept. 19, 2013, 1:09 p.m.
On Thu, 2013-09-19 at 17:52 +0500, Shakeel, Muhammad wrote:
> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> 
> -This release contains a few important bugfixes in addition
> to a few new features.

So it fixes some old bugs and potentially adds new ones? I can't make a
good risk assessment on that information, sorry. Are you asking for this
in 1.5 or 1.6?

Cheers,

Richard
Shakeel, Muhammad - Sept. 19, 2013, 1:19 p.m.
On 09/19/2013 06:09 PM, Richard Purdie wrote:
> On Thu, 2013-09-19 at 17:52 +0500, Shakeel, Muhammad wrote:
>> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>>
>> -This release contains a few important bugfixes in addition
>> to a few new features.
> So it fixes some old bugs and potentially adds new ones? I can't make a
> good risk assessment on that information, sorry. Are you asking for this
> in 1.5 or 1.6?
>
I was having issues running connman 1.17 on my platform. Connman 1.18 
worked for me.
If it can go in 1.5, it will be great. Otherwise it should definitely go 
in 1.6.

Best Regards,
Shakeel
Jukka Rissanen - Sept. 19, 2013, 1:41 p.m.
On 19.09.2013 16:19, Muhammad Shakeel wrote:
> On 09/19/2013 06:09 PM, Richard Purdie wrote:
>> On Thu, 2013-09-19 at 17:52 +0500, Shakeel, Muhammad wrote:
>>> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>>>
>>> -This release contains a few important bugfixes in addition
>>> to a few new features.
>> So it fixes some old bugs and potentially adds new ones? I can't make a
>> good risk assessment on that information, sorry. Are you asking for this
>> in 1.5 or 1.6?
>>
> I was having issues running connman 1.17 on my platform. Connman 1.18
> worked for me.
> If it can go in 1.5, it will be great. Otherwise it should definitely go
> in 1.6.

ConnMan 1.18 release notes can be found here
https://connman.net/blogs/patrik/2013/connman-118

I would recommend taking it. Biggest issue fixed in 1.18 was the 
iptables support which did not work in ARM based devices.


This patch could perhaps split to two pieces, first one removing 
obsolete options and second one updating the version.


Cheers,
Jukka
Ross Burton - Sept. 19, 2013, 1:45 p.m.
On 19 September 2013 14:41, Jukka Rissanen
<jukka.rissanen@linux.intel.com> wrote:
> ConnMan 1.18 release notes can be found here
> https://connman.net/blogs/patrik/2013/connman-118

<standard moan that connman doesn't do stable point releases here>

Ross
Shakeel, Muhammad - Sept. 20, 2013, 1:10 p.m.
On 09/19/2013 06:41 PM, Jukka Rissanen wrote:
>
> I would recommend taking it. Biggest issue fixed in 1.18 was the 
> iptables support which did not work in ARM based devices.
>
>
> This patch could perhaps split to two pieces, first one removing 
> obsolete options and second one updating the version.
>
Ok, I will resend this after splitting it into two commits.

Thanks,

Patch

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index 37ce3ec..12f3edd 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -21,14 +21,12 @@  EXTRA_OECONF += "\
     ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
     ac_cv_path_PPPD=${sbindir}/pppd \
     --enable-debug \
-    --enable-threads \
     --enable-loopback \
     --enable-ethernet \
     --enable-tools \
     --enable-test \
     --disable-polkit \
     --enable-client \
-    --enable-fake \
     ${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemdunitdir=${systemd_unitdir}/system/', '--with-systemdunitdir=', d)} \
 "
 
diff --git a/meta/recipes-connectivity/connman/connman_1.17.bb b/meta/recipes-connectivity/connman/connman_1.17.bb
deleted file mode 100644
index 461157f..0000000
--- a/meta/recipes-connectivity/connman/connman_1.17.bb
+++ /dev/null
@@ -1,14 +0,0 @@ 
-require connman.inc
-
-SRC_URI  = "${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
-            file://0001-plugin.h-Change-visibility-to-default-for-debug-symb.patch \
-            file://add_xuser_dbus_permission.patch \
-            file://connman \
-            "
-
-SRC_URI[md5sum] = "dd4a13f789de1b69fcddf0cf613f2d5b"
-SRC_URI[sha256sum] = "d31aa2e7dc9fa817c93aba973995b63506a8c83f55afe507028f09b580ef0b00"
-
-PR = "${INC_PR}.0"
-
-RRECOMMENDS_${PN} = "connman-conf"
diff --git a/meta/recipes-connectivity/connman/connman_1.18.bb b/meta/recipes-connectivity/connman/connman_1.18.bb
new file mode 100644
index 0000000..44a4a07
--- /dev/null
+++ b/meta/recipes-connectivity/connman/connman_1.18.bb
@@ -0,0 +1,14 @@ 
+require connman.inc
+
+SRC_URI  = "${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
+            file://0001-plugin.h-Change-visibility-to-default-for-debug-symb.patch \
+            file://add_xuser_dbus_permission.patch \
+            file://connman \
+            "
+
+SRC_URI[md5sum] = "7578ec8f0422d34f5a4ba51b605fe576"
+SRC_URI[sha256sum] = "56c2ca7842be2100b6b59367845d5beec125f231af6ea505604992e0c5a69992"
+
+PR = "${INC_PR}.0"
+
+RRECOMMENDS_${PN} = "connman-conf"