Patchwork [bitbake-devel] hob: populate "Save image" dialog when saving changes to a custom image recipe If my build starts from a YP standard image recipe, the 'Save image recipe' dialog should be empty.

login
register
mail settings
Submitter Cristiana Voicu
Date Sept. 17, 2013, 10:48 a.m.
Message ID <1379414901-28041-1-git-send-email-cristiana.voicu@intel.com>
Download mbox | patch
Permalink /patch/58245/
State New
Headers show

Comments

Cristiana Voicu - Sept. 17, 2013, 10:48 a.m.
If my build starts from a custom image recipe, the 'Save image recipe'
dialog should populate the 'Name' and 'Description' fields with the values
set for the custom image recipe.

[YOCTO #5004]
Signed-off-by: Cristiana Voicu <cristiana.voicu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |    8 ++++++++
 1 file changed, 8 insertions(+)

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
index ca33e08..b5d9660 100755
--- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
+++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py
@@ -635,6 +635,14 @@  class ImageDetailsPage (HobPage):
         images_dir = topdir + "/recipes/images/"
         self.builder.ensure_dir(images_dir)
 
+        self.name_field_template = self.builder.image_configuration_page.custom_image_selected
+        if self.name_field_template:
+            image_path = self.builder.recipe_model.pn_path[self.name_field_template]
+            image_iter = self.builder.recipe_model.get_iter(image_path)
+            self.description_field_template = self.builder.recipe_model.get_value(image_iter, self.builder.recipe_model.COL_DESC)
+        else:
+            self.name_field_template = ""
+
         dialog = SaveImageDialog(images_dir, self.name_field_template, self.description_field_template,
                  "Save image recipe", self.builder, gtk.DIALOG_MODAL | gtk.DIALOG_DESTROY_WITH_PARENT)
         response = dialog.run()