Patchwork [1/1] python-smartpm: truncate the filename to meet NAME_MAX

login
register
mail settings
Submitter Robert Yang
Date Sept. 17, 2013, 2:35 a.m.
Message ID <115a322c3e8d0998cb24ade3ce11ca0a2b0b211c.1379384999.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/58219/
State Accepted
Commit 37cb3e3aa4dc6fa63e5c6538dac6301d363f433c
Headers show

Comments

Robert Yang - Sept. 17, 2013, 2:35 a.m.
There is a "File name too long" error when len(TMPDIR) = 410, this is
because the function getLocalPath() converts the filepath into the
filename, so there would be the error when len(filename)
> NAME_MAX, truncate the filename to meet NAME_MAX will fix the problem.

[YOCTO #5201]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 .../python-smartpm/smart-filename-NAME_MAX.patch   |   35 ++++++++++++++++++++
 .../python/python-smartpm_1.4.1.bb                 |    1 +
 2 files changed, 36 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python-smartpm/smart-filename-NAME_MAX.patch

Patch

diff --git a/meta/recipes-devtools/python/python-smartpm/smart-filename-NAME_MAX.patch b/meta/recipes-devtools/python/python-smartpm/smart-filename-NAME_MAX.patch
new file mode 100644
index 0000000..22794a7
--- /dev/null
+++ b/meta/recipes-devtools/python/python-smartpm/smart-filename-NAME_MAX.patch
@@ -0,0 +1,35 @@ 
+From a17998b6be3319ae476a64f366737bc267a53a8a Mon Sep 17 00:00:00 2001
+From: Robert Yang <liezhi.yang@windriver.com>
+Date: Mon, 16 Sep 2013 05:54:13 -0400
+Subject: [PATCH] fetcher.py: truncate the filename to meet NAME_MAX
+
+The function getLocalPath() converts the filepath into the filename,
+there would be a "File name too long" error when len(filename) >
+NAME_MAX, truncate it to meet NAME_MAX will fix the problem.
+
+Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
+---
+ smart/fetcher.py |    8 ++++++++
+ 1 file changed, 8 insertions(+)
+
+diff --git a/smart/fetcher.py b/smart/fetcher.py
+--- a/smart/fetcher.py
++++ b/smart/fetcher.py
+@@ -139,6 +139,14 @@ class Fetcher(object):
+             filename = os.path.basename(path)
+         if self._localpathprefix:
+             filename = self._localpathprefix+filename
++        # pathconf requires the path existed
++        if not os.path.exists(self._localdir):
++            os.makedirs(self._localdir)
++        name_max = os.pathconf(self._localdir, 'PC_NAME_MAX')
++        # The length of the filename should be less than NAME_MAX
++        if len(filename) > name_max:
++            iface.debug(_("Truncate %s to %s") % (filename, filename[-name_max:]))
++            filename = filename[-name_max:]
+         return os.path.join(self._localdir, filename)
+ 
+     def setForceCopy(self, value):
+-- 
+1.7.10.4
+
diff --git a/meta/recipes-devtools/python/python-smartpm_1.4.1.bb b/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
index f406d69..f349469 100644
--- a/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
+++ b/meta/recipes-devtools/python/python-smartpm_1.4.1.bb
@@ -31,6 +31,7 @@  SRC_URI = "\
           file://smart-flag-exclude-packages.patch \
           file://smart-config-ignore-all-recommends.patch \
           file://smart-attempt.patch \
+          file://smart-filename-NAME_MAX.patch \
           "
 
 SRC_URI[md5sum] = "573ef32ba177a6b3c4bf7ef04873fcb6"