Patchwork [bitbake-devel,11/16] data_smart: Cache the fact a variable accesses another even if its unset

login
register
mail settings
Submitter Richard Purdie
Date Sept. 16, 2013, 9:53 p.m.
Message ID <1379368413-9808-11-git-send-email-richard.purdie@linuxfoundation.org>
Download mbox | patch
Permalink /patch/58201/
State Accepted
Commit b05b748b2153c941b95cd36fb22aaafc4dbf3791
Headers show

Comments

Richard Purdie - Sept. 16, 2013, 9:53 p.m.
If a variable references another but it isn't set at present, the
reference wasn't stored. It really should be marked as a reference
and the higher level dependency code can handle as appropriate.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 lib/bb/data_smart.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/lib/bb/data_smart.py b/lib/bb/data_smart.py
index 054b5cb..79bf331 100644
--- a/lib/bb/data_smart.py
+++ b/lib/bb/data_smart.py
@@ -100,8 +100,8 @@  class VariableParse:
                 self.execs |= varparse.execs
                 return varparse.value
             var = self.d.getVar(key, True)
+            self.references.add(key)
             if var is not None:
-                self.references.add(key)
                 return var
             else:
                 return match.group()