Patchwork Checksum for barebox

login
register
mail settings
Submitter Fabio Estevam
Date Sept. 16, 2013, 8:15 p.m.
Message ID <CAOMZO5CFb4oEU3zoLbeWrTExdykgaMTb_DeFzO43gP6LnRHYHw@mail.gmail.com>
Download mbox | patch
Permalink /patch/58179/
State Not Applicable
Delegated to: Otavio Salvador
Headers show

Comments

Fabio Estevam - Sept. 16, 2013, 8:15 p.m.
Hi Eric,

On Mon, Sep 16, 2013 at 4:35 PM, Eric Bénard <eric@eukrea.com> wrote:

> add COMPATIBLE_MACHINE = "the_machine_supported_by_the_recipe"
> as it was done in 2012.02.0

Like this?


Thanks,

Fabio Estevam
Eric BENARD - Sept. 16, 2013, 8:34 p.m.
Hi Fabio,

Le Mon, 16 Sep 2013 17:15:01 -0300,
Fabio Estevam <festevam@gmail.com> a écrit :
> On Mon, Sep 16, 2013 at 4:35 PM, Eric Bénard <eric@eukrea.com> wrote:
> 
> > add COMPATIBLE_MACHINE = "the_machine_supported_by_the_recipe"
> > as it was done in 2012.02.0
> 
> Like this?
> 
> --- a/recipes-bsp/barebox/barebox_2013.08.0.bb
> +++ b/recipes-bsp/barebox/barebox_2013.08.0.bb
> @@ -6,3 +6,5 @@ SRC_URI = "http://barebox.org/download/${PN}-${PV}.tar.bz2 \
>  SRC_URI[md5sum] = "a61b97a2fedebc808d4b182c2ca18a0c"
>  SRC_URI[sha256sum] = "d9e46dd3c68b04ab4cbc37135dc34907dbebef393da4b3e54abb203c2
> 
> +COMPATIBLE_MACHINE = "imx53qsb"
> +
> 
no because imx53qsb is no more supported (yet) so the message will
still appear when building for imx53qsb.

If you add COMPATIBLE_MACHINE = "Invalid!"
that will remove the message and people using bbappend can override
COMPATIBLE_MACHINE_theirmachine = "theirmachine" in their bbappend.

BTW, I've started again working on bringing back barebox to
meta-fsl-arm for i.MX28, 53 and 6 but that won't make it for this
release.

Eric
Fabio Estevam - Sept. 16, 2013, 9:47 p.m.
Hi Eric,

On Mon, Sep 16, 2013 at 5:34 PM, Eric Bénard <eric@eukrea.com> wrote:

> no because imx53qsb is no more supported (yet) so the message will
> still appear when building for imx53qsb.
>
> If you add COMPATIBLE_MACHINE = "Invalid!"

Ok, understood.

Will submit a patch for this tomorrow.

Thanks,

Fabio Estevam
Alexandre Belloni - Sept. 17, 2013, 7:30 a.m.
Hi,

On 16/09/2013 23:47, Fabio Estevam wrote:
> Hi Eric,
>
> On Mon, Sep 16, 2013 at 5:34 PM, Eric Bénard <eric@eukrea.com> wrote:
>
>> no because imx53qsb is no more supported (yet) so the message will
>> still appear when building for imx53qsb.
>>
>> If you add COMPATIBLE_MACHINE = "Invalid!"
> Ok, understood.
>
> Will submit a patch for this tomorrow.

While you are at it, could you fix that one too ?

WARNING: Unable to get checksum for linux-imx SRC_URI entry defconfig:
file could not be found

Thanks!
Eric BENARD - Sept. 17, 2013, 8:44 a.m.
Hi Alexandre,

Le Tue, 17 Sep 2013 09:30:06 +0200,
Alexandre Belloni <alexandre.belloni@free-electrons.com> a écrit :
> On 16/09/2013 23:47, Fabio Estevam wrote:
> > On Mon, Sep 16, 2013 at 5:34 PM, Eric Bénard <eric@eukrea.com> wrote:
> >> no because imx53qsb is no more supported (yet) so the message will
> >> still appear when building for imx53qsb.
> >>
> >> If you add COMPATIBLE_MACHINE = "Invalid!"
> > Ok, understood.
> >
> > Will submit a patch for this tomorrow.
> 
> While you are at it, could you fix that one too ?
> 
> WARNING: Unable to get checksum for linux-imx SRC_URI entry defconfig:
> file could not be found
> 
that seems to be caused by your machine being an mx28 (so
linux-imx_2.6.35 is compatible with your machine) but not using
linux-imx so that can't be fixed in meta-fsl-arm.

Eric
Otavio Salvador - Sept. 17, 2013, 1:32 p.m.
On Mon, Sep 16, 2013 at 5:34 PM, Eric Bénard <eric@eukrea.com> wrote:
> Hi Fabio,
>
> Le Mon, 16 Sep 2013 17:15:01 -0300,
> Fabio Estevam <festevam@gmail.com> a écrit :
>> On Mon, Sep 16, 2013 at 4:35 PM, Eric Bénard <eric@eukrea.com> wrote:
>>
>> > add COMPATIBLE_MACHINE = "the_machine_supported_by_the_recipe"
>> > as it was done in 2012.02.0
>>
>> Like this?
>>
>> --- a/recipes-bsp/barebox/barebox_2013.08.0.bb
>> +++ b/recipes-bsp/barebox/barebox_2013.08.0.bb
>> @@ -6,3 +6,5 @@ SRC_URI = "http://barebox.org/download/${PN}-${PV}.tar.bz2 \
>>  SRC_URI[md5sum] = "a61b97a2fedebc808d4b182c2ca18a0c"
>>  SRC_URI[sha256sum] = "d9e46dd3c68b04ab4cbc37135dc34907dbebef393da4b3e54abb203c2
>>
>> +COMPATIBLE_MACHINE = "imx53qsb"
>> +
>>
> no because imx53qsb is no more supported (yet) so the message will
> still appear when building for imx53qsb.
>
> If you add COMPATIBLE_MACHINE = "Invalid!"
> that will remove the message and people using bbappend can override
> COMPATIBLE_MACHINE_theirmachine = "theirmachine" in their bbappend.

Agreed.

> BTW, I've started again working on bringing back barebox to
> meta-fsl-arm for i.MX28, 53 and 6 but that won't make it for this
> release.

If you can get it done I think we could get it merged; this is safe
enough to get merged.
Eric BENARD - Sept. 17, 2013, 1:34 p.m.
Hi Otavio,

Le Tue, 17 Sep 2013 10:32:56 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :
> > BTW, I've started again working on bringing back barebox to
> > meta-fsl-arm for i.MX28, 53 and 6 but that won't make it for this
> > release.
> 
> If you can get it done I think we could get it merged; this is safe
> enough to get merged.
> 
then I'll try to accelerate and to send patches by next week ;-)

Eric

Patch

--- a/recipes-bsp/barebox/barebox_2013.08.0.bb
+++ b/recipes-bsp/barebox/barebox_2013.08.0.bb
@@ -6,3 +6,5 @@  SRC_URI = "http://barebox.org/download/${PN}-${PV}.tar.bz2 \
 SRC_URI[md5sum] = "a61b97a2fedebc808d4b182c2ca18a0c"
 SRC_URI[sha256sum] = "d9e46dd3c68b04ab4cbc37135dc34907dbebef393da4b3e54abb203c2

+COMPATIBLE_MACHINE = "imx53qsb"
+