| Submitter | Khem Raj |
|---|---|
| Date | June 14, 2011, 5:25 a.m. |
| Message ID | <1308029130-29774-1-git-send-email-raj.khem@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/5815/ |
| State | New, archived |
| Headers | show |
Comments
Op 14 jun 2011, om 07:25 heeft Khem Raj het volgende geschreven: > PACKAGE_ARCH is set to BASE_PACKAGE_ARCH so we do not > need to define it here since we already define BASE_PACKAGE_ARCH > > Additionally set FEED_ARCH to 'allarch' That would break all existing feeds and feed-configs, which I don't think is acceptable.
On Mon, 2011-06-13 at 22:25 -0700, Khem Raj wrote: > PACKAGE_ARCH is set to BASE_PACKAGE_ARCH so we do not > need to define it here since we already define BASE_PACKAGE_ARCH > > Additionally set FEED_ARCH to 'allarch' some distros e.g. > angstrom sets FEED_ARCH like > > FEED_ARCH ?= "${BASE_PACKAGE_ARCH}" Um? Surely if FEED_ARCH is defined in terms of B_P_A then just setting the latter variable ought to be enough. Why do you need to set both? > and 'all' doesnt go well for FEED_ARCH as it ends up with > parsing error for x86 machines. That sounds a bit odd as well. I wouldn't have expected any value of FEED_ARCH to result in parsing errors. What actually goes wrong? p. > > This might be a latent bug in bitbake but allarch.bbclass > excavated it and we burry it in the same class. > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/classes/allarch.bbclass | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/meta/classes/allarch.bbclass b/meta/classes/allarch.bbclass > index e3ac392..971cb92 100644 > --- a/meta/classes/allarch.bbclass > +++ b/meta/classes/allarch.bbclass > @@ -2,9 +2,8 @@ > # This class is used for architecture independent recipes/data files (usally scripts) > # > > -BASE_PACKAGE_ARCH = "all" > -PACKAGE_ARCH = "all" > - > +BASE_PACKAGE_ARCH = "allarch" > +FEED_ARCH = "allarch" > # No need for virtual/libc or a cross compiler > INHIBIT_DEFAULT_DEPS = "1" >
Patch
diff --git a/meta/classes/allarch.bbclass b/meta/classes/allarch.bbclass index e3ac392..971cb92 100644 --- a/meta/classes/allarch.bbclass +++ b/meta/classes/allarch.bbclass @@ -2,9 +2,8 @@ # This class is used for architecture independent recipes/data files (usally scripts) # -BASE_PACKAGE_ARCH = "all" -PACKAGE_ARCH = "all" - +BASE_PACKAGE_ARCH = "allarch" +FEED_ARCH = "allarch" # No need for virtual/libc or a cross compiler INHIBIT_DEFAULT_DEPS = "1"
PACKAGE_ARCH is set to BASE_PACKAGE_ARCH so we do not need to define it here since we already define BASE_PACKAGE_ARCH Additionally set FEED_ARCH to 'allarch' some distros e.g. angstrom sets FEED_ARCH like FEED_ARCH ?= "${BASE_PACKAGE_ARCH}" and 'all' doesnt go well for FEED_ARCH as it ends up with parsing error for x86 machines. This might be a latent bug in bitbake but allarch.bbclass excavated it and we burry it in the same class. Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/classes/allarch.bbclass | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)