Patchwork ti-dsplink: Fixed location of toolchain

login
register
mail settings
Submitter Joel A Fernandes
Date June 14, 2011, 3:55 a.m.
Message ID <4DF6DBCE.7010404@gmail.com>
Download mbox | patch
Permalink /patch/5813/
State New, archived
Headers show

Comments

Joel A Fernandes - June 14, 2011, 3:55 a.m.
ti-dsplink: Fixed location of toolchain to build ti-dsplink.

Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
---
 recipes/ti/ti-dsplink.inc |   34 +++++++++++++++++-----------------
 1 files changed, 17 insertions(+), 17 deletions(-)
Denys Dmytriyenko - June 14, 2011, 5:51 a.m.
On Mon, Jun 13, 2011 at 10:55:58PM -0500, Joel A Fernandes wrote:
> ti-dsplink: Fixed location of toolchain to build ti-dsplink.
> 
> Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>

Have you tested this with an external toolchain?
Koen Kooi - June 14, 2011, 7:36 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 14-06-11 05:55, Joel A Fernandes wrote:
> ti-dsplink: Fixed location of toolchain to build ti-dsplink.

It sadly really needs an absolute path to the tools :(

> 
> Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
> ---
>  recipes/ti/ti-dsplink.inc |   34 +++++++++++++++++-----------------
>  1 files changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/recipes/ti/ti-dsplink.inc b/recipes/ti/ti-dsplink.inc
> index c48ec41..bbdc35a 100644
> --- a/recipes/ti/ti-dsplink.inc
> +++ b/recipes/ti/ti-dsplink.inc
> @@ -94,23 +94,23 @@ do_compile() {
>      # Build the gpp user space library
>      cd ${DSPLINK}/gpp/src/api && make \
>        CROSS_COMPILE="${TARGET_PREFIX}" \
> -      CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
> -      AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
> -      LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \
> -      COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
> -      ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
> +      CC="${CC}" \
> +      AR="${AR}" \
> +      LD="${LD}" \
> +      COMPILER="${CC}" \
> +      ARCHIVER="${AR}" \
>        KERNEL_DIR="${STAGING_KERNEL_DIR}" \
>        all
>  
>      # Build the gpp kernel space (debug and release)
>      cd ${DSPLINK}/gpp/src && make \
> -      OBJDUMP="${TARGET_PREFIX}objdump" \
> +      OBJDUMP="${OBJDUMP}" \
>        CROSS_COMPILE="${TARGET_PREFIX}" \
> -      CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
> -      AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
> -      LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \
> -      COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
> -      ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
> +      CC="${CC}" \
> +      AR="${AR}" \
> +      LD="${LD}" \
> +      COMPILER="${CC}" \
> +      ARCHIVER="${AR}" \
>        KERNEL_DIR="${STAGING_KERNEL_DIR}" \
>        BASE_BUILDOS="${STAGING_KERNEL_DIR}" \
>        all
> @@ -122,12 +122,12 @@ do_compile() {
>        OSINC_PLATFORM="${TOOLCHAIN_PATH}/lib/gcc/${TARGET_SYS}/$(${TARGET_PREFIX}gcc -dumpversion)/include" \
>        OSINC_TARGET="${BASE_TOOLCHAIN}/target/usr/include" \
>        CROSS_COMPILE="${TARGET_PREFIX}" \
> -      CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
> -      LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
> -      AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
> -      COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
> -      LINKER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
> -      ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
> +      CC="${CC}" \
> +      AR="${AR}" \
> +      LD="${LD}" \
> +      COMPILER="${CC}" \
> +      ARCHIVER="${AR}" \
> +      LINKER="${CC}" \
>        KERNEL_DIR="${STAGING_KERNEL_DIR}" \
>        all

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN9w96MkyGM64RGpERAkk+AJ9kAE91Op6450wG1xySGpAa3drFXQCfSNcO
F1rBpao1N5wwWAlNk6kwiqU=
=x1pA
-----END PGP SIGNATURE-----
Denys Dmytriyenko - June 14, 2011, 3:38 p.m.
On Tue, Jun 14, 2011 at 09:36:26AM +0200, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 14-06-11 05:55, Joel A Fernandes wrote:
> > ti-dsplink: Fixed location of toolchain to build ti-dsplink.
> 
> It sadly really needs an absolute path to the tools :(

So, what was this patch trying to fix anyway? Is there something broken?
Koen Kooi - June 14, 2011, 3:47 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 14-06-11 17:38, Denys Dmytriyenko wrote:
> On Tue, Jun 14, 2011 at 09:36:26AM +0200, Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 14-06-11 05:55, Joel A Fernandes wrote:
>>> ti-dsplink: Fixed location of toolchain to build ti-dsplink.
>>
>> It sadly really needs an absolute path to the tools :(
> 
> So, what was this patch trying to fix anyway? Is there something broken?

Using an external toolchain without your import magic and then
overriding TOOLCHAINPATH in local.conf is broken. You might call it
broken by design :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN94J7MkyGM64RGpERAufjAJ0byRdnVm9SmVJ0Hlqsyv+BJv75uwCggF42
qeHxFXcjNMNr11nIr+Knmio=
=mZHT
-----END PGP SIGNATURE-----
Denys Dmytriyenko - June 14, 2011, 7:31 p.m.
On Tue, Jun 14, 2011 at 05:47:07PM +0200, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 14-06-11 17:38, Denys Dmytriyenko wrote:
> > On Tue, Jun 14, 2011 at 09:36:26AM +0200, Koen Kooi wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> On 14-06-11 05:55, Joel A Fernandes wrote:
> >>> ti-dsplink: Fixed location of toolchain to build ti-dsplink.
> >>
> >> It sadly really needs an absolute path to the tools :(
> > 
> > So, what was this patch trying to fix anyway? Is there something broken?
> 
> Using an external toolchain without your import magic and then
> overriding TOOLCHAINPATH in local.conf is broken. You might call it
> broken by design :)

As you know, the design is hindered by requirements, so ease up! :)

As of the "import magic" - there is nothing magical about it, it just sets up 
TOOLCHAIN_PATH and TOOLCHAIN_SYSPATH automatically. Otherwise you'd have to 
set at least TOOLCHAIN_PATH manually and it works. So, I still don't see what 
exactly is broken and needs to be fixed.

BTW, the requirements for absolute toolchain path come from dsplink and not 
the external toolchain, AFAICR...
Koen Kooi - June 14, 2011, 7:38 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 14-06-11 21:31, Denys Dmytriyenko wrote:
> On Tue, Jun 14, 2011 at 05:47:07PM +0200, Koen Kooi wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 14-06-11 17:38, Denys Dmytriyenko wrote:
>>> On Tue, Jun 14, 2011 at 09:36:26AM +0200, Koen Kooi wrote:
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA1
>>>>
>>>> On 14-06-11 05:55, Joel A Fernandes wrote:
>>>>> ti-dsplink: Fixed location of toolchain to build ti-dsplink.
>>>>
>>>> It sadly really needs an absolute path to the tools :(
>>>
>>> So, what was this patch trying to fix anyway? Is there something broken?
>>
>> Using an external toolchain without your import magic and then
>> overriding TOOLCHAINPATH in local.conf is broken. You might call it
>> broken by design :)
> 
> As you know, the design is hindered by requirements, so ease up! :)
> 
> As of the "import magic" - there is nothing magical about it, it just sets up 
> TOOLCHAIN_PATH and TOOLCHAIN_SYSPATH automatically. Otherwise you'd have to 
> set at least TOOLCHAIN_PATH manually and it works. So, I still don't see what 
> exactly is broken and needs to be fixed.

Joel setup his tree the wrong way

> BTW, the requirements for absolute toolchain path come from dsplink and not 
> the external toolchain, AFAICR...

dsplink and others, yes.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFN97jDMkyGM64RGpERAimXAKC70bo3sUyDf+/jzJux/n8mXRurYgCgqsEt
RT2PAYT1EIeptDARW/MoEcE=
=Yfp9
-----END PGP SIGNATURE-----

Patch

diff --git a/recipes/ti/ti-dsplink.inc b/recipes/ti/ti-dsplink.inc
index c48ec41..bbdc35a 100644
--- a/recipes/ti/ti-dsplink.inc
+++ b/recipes/ti/ti-dsplink.inc
@@ -94,23 +94,23 @@  do_compile() {
     # Build the gpp user space library
     cd ${DSPLINK}/gpp/src/api && make \
       CROSS_COMPILE="${TARGET_PREFIX}" \
-      CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
-      AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
-      LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \
-      COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
-      ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
+      CC="${CC}" \
+      AR="${AR}" \
+      LD="${LD}" \
+      COMPILER="${CC}" \
+      ARCHIVER="${AR}" \
       KERNEL_DIR="${STAGING_KERNEL_DIR}" \
       all
 
     # Build the gpp kernel space (debug and release)
     cd ${DSPLINK}/gpp/src && make \
-      OBJDUMP="${TARGET_PREFIX}objdump" \
+      OBJDUMP="${OBJDUMP}" \
       CROSS_COMPILE="${TARGET_PREFIX}" \
-      CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
-      AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
-      LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ld" \
-      COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
-      ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
+      CC="${CC}" \
+      AR="${AR}" \
+      LD="${LD}" \
+      COMPILER="${CC}" \
+      ARCHIVER="${AR}" \
       KERNEL_DIR="${STAGING_KERNEL_DIR}" \
       BASE_BUILDOS="${STAGING_KERNEL_DIR}" \
       all
@@ -122,12 +122,12 @@  do_compile() {
       OSINC_PLATFORM="${TOOLCHAIN_PATH}/lib/gcc/${TARGET_SYS}/$(${TARGET_PREFIX}gcc -dumpversion)/include" \
       OSINC_TARGET="${BASE_TOOLCHAIN}/target/usr/include" \
       CROSS_COMPILE="${TARGET_PREFIX}" \
-      CC="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
-      LD="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
-      AR="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
-      COMPILER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
-      LINKER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}gcc" \
-      ARCHIVER="${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX}ar" \
+      CC="${CC}" \
+      AR="${AR}" \
+      LD="${LD}" \
+      COMPILER="${CC}" \
+      ARCHIVER="${AR}" \
+      LINKER="${CC}" \
       KERNEL_DIR="${STAGING_KERNEL_DIR}" \
       all