Patchwork [1/2] transfig-native: remove, nothing depends on it

login
register
mail settings
Submitter Ross Burton
Date Sept. 16, 2013, 8:26 a.m.
Message ID <1379319989-9475-1-git-send-email-ross.burton@intel.com>
Download mbox | patch
Permalink /patch/58091/
State Accepted
Commit 9470f687d938e2b6427e75354c74d44b86263bec
Headers show

Comments

Ross Burton - Sept. 16, 2013, 8:26 a.m.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 .../transfig/transfig-native_3.2.5d.bb             |   39 --------------------
 .../packagegroups/packagegroup-toolset-native.bb   |    1 -
 2 files changed, 40 deletions(-)
 delete mode 100644 meta/recipes-devtools/transfig/transfig-native_3.2.5d.bb
Robert Yang - Sept. 16, 2013, 8:58 a.m.
Hi Ross,

Is there a specify reason that we need to remove it ? transfig
provides fig2dev which is used for building the documentation,
for example, gstreamer and libtheora may use fig2dev.

// Robert

On 09/16/2013 04:26 PM, Ross Burton wrote:
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   .../transfig/transfig-native_3.2.5d.bb             |   39 --------------------
>   .../packagegroups/packagegroup-toolset-native.bb   |    1 -
>   2 files changed, 40 deletions(-)
>   delete mode 100644 meta/recipes-devtools/transfig/transfig-native_3.2.5d.bb
>
> diff --git a/meta/recipes-devtools/transfig/transfig-native_3.2.5d.bb b/meta/recipes-devtools/transfig/transfig-native_3.2.5d.bb
> deleted file mode 100644
> index c20a243..0000000
> --- a/meta/recipes-devtools/transfig/transfig-native_3.2.5d.bb
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -SUMMARY = "Utilities for converting XFig figure files"
> -DESCRIPTION = "This package contains utilities (mainly fig2dev) to \
> -handle XFig (Facility for Interactive Generation of figures) files."
> -HOMEPAGE = "http://www-epb.lbl.gov/xfig/"
> -SECTION = "console/utils"
> -LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://fig2dev/fig2dev.c;endline=16;md5=6bab01e017409cf9ab21d3e953b793f7"
> -PR = "r1"
> -
> -DEPENDS = "imake-native xorg-cf-files-native zlib-native jpeg-native libpng-native libxpm-native"
> -
> -SRC_URI = "${SOURCEFORGE_MIRROR}/mcj/transfig.${PV}.tar.gz"
> -
> -SRC_URI[md5sum] = "f9eac7f265668ecbfda6aaf7581989ad"
> -SRC_URI[sha256sum] = "ae81214177fb05f91f6e43b0b42633b6e0024570cbc6591a3858e12100ce8aaa"
> -
> -S = "${WORKDIR}/transfig.${PV}"
> -
> -EXTRA_OEMAKE = "-I${S}"
> -
> -inherit native
> -
> -do_configure() {
> -	xmkmf
> -	make Makefiles
> -
> -	# Fix hardcoded references to host build locations
> -	sed -i -e "s|SYSTEMUSRLIBDIR = /usr/lib64|SYSTEMUSRLIBDIR = ${libdir}|g" fig2dev/Makefile
> -	sed -i -e "s|SYSTEMUSRINCDIR = /usr/include|SYSTEMUSRINCDIR = ${includedir}|g" fig2dev/Makefile
> -	sed -i -e "s|XPMINC = -I/usr/include/X11|XPMINC = -I${includedir}/X11|g" fig2dev/Makefile
> -	sed -i -e "s|/usr/lib64|/usr/lib|g" fig2dev/Makefile || true
> -	sed -i -e "s|/usr/lib64|/usr/lib|g" fig2dev/dev/Makefile || true
> -	sed -i -e "s|/usr/local/lib|${libdir}|g" fig2dev/Makefile
> -	sed -i -e "s|/usr/local/lib|${libdir}|g" fig2dev/dev/Makefile
> -}
> -
> -do_install() {
> -	oe_runmake install DESTDIR=${D}
> -}
> diff --git a/meta/recipes-gnome/packagegroups/packagegroup-toolset-native.bb b/meta/recipes-gnome/packagegroups/packagegroup-toolset-native.bb
> index 82ee820..934b1be 100644
> --- a/meta/recipes-gnome/packagegroups/packagegroup-toolset-native.bb
> +++ b/meta/recipes-gnome/packagegroups/packagegroup-toolset-native.bb
> @@ -213,7 +213,6 @@ DEPENDS = "\
>       tcl-native \
>       texinfo-native \
>       tiff-native \
> -    transfig-native \
>       tzcode-native \
>       u-boot-mkimage-native \
>       unfs-server-native \
>
Ross Burton - Sept. 16, 2013, 9:15 a.m.
On 16 September 2013 09:58, Robert Yang <liezhi.yang@windriver.com> wrote:
> Is there a specify reason that we need to remove it ? transfig
> provides fig2dev which is used for building the documentation,
> for example, gstreamer and libtheora may use fig2dev.

Considering nothing depends on it, clearly not in stock oe-core.
Presumably you have some patches to enable the documentation builds
and add the missing dependencies?

Ross
Ross Burton - Sept. 16, 2013, 9:30 a.m.
On 16 September 2013 10:15, Burton, Ross <ross.burton@intel.com> wrote:
> On 16 September 2013 09:58, Robert Yang <liezhi.yang@windriver.com> wrote:
>> Is there a specify reason that we need to remove it ? transfig
>> provides fig2dev which is used for building the documentation,
>> for example, gstreamer and libtheora may use fig2dev.
>
> Considering nothing depends on it, clearly not in stock oe-core.
> Presumably you have some patches to enable the documentation builds
> and add the missing dependencies?

It also appears that GStreamer (at least gstreamer itself, HEAD of
master and 0.10) doesn't actually use fig files for the documentation,
just PNG.

If we're talking about a large number of packages then I'd agree, but
if we're saying that oe-core should have imake and transfig-native so
that if you patch libtheora to build documentation it has diagrams,
then I'm not sure that's a suitable trade-off.

Ross
Robert Yang - Sept. 16, 2013, 10:12 a.m.
On 09/16/2013 05:30 PM, Burton, Ross wrote:
> On 16 September 2013 10:15, Burton, Ross <ross.burton@intel.com> wrote:
>> On 16 September 2013 09:58, Robert Yang <liezhi.yang@windriver.com> wrote:
>>> Is there a specify reason that we need to remove it ? transfig
>>> provides fig2dev which is used for building the documentation,
>>> for example, gstreamer and libtheora may use fig2dev.
>>
>> Considering nothing depends on it, clearly not in stock oe-core.
>> Presumably you have some patches to enable the documentation builds
>> and add the missing dependencies?
>
> It also appears that GStreamer (at least gstreamer itself, HEAD of
> master and 0.10) doesn't actually use fig files for the documentation,
> just PNG.
>
> If we're talking about a large number of packages then I'd agree, but
> if we're saying that oe-core should have imake and transfig-native so
> that if you patch libtheora to build documentation it has diagrams,
> then I'm not sure that's a suitable trade-off.
>

No, I don't have anything depend on transfig-native, I just worried about
that many packages use it, I did a grep in a world build directory just now
, didn't find any more packages use it.

// Robert

> Ross
>
>
Khem Raj - Sept. 16, 2013, 5:04 p.m.
On Sep 16, 2013, at 2:30 AM, "Burton, Ross" <ross.burton@intel.com> wrote:

> On 16 September 2013 10:15, Burton, Ross <ross.burton@intel.com> wrote:
>> On 16 September 2013 09:58, Robert Yang <liezhi.yang@windriver.com> wrote:
>>> Is there a specify reason that we need to remove it ? transfig
>>> provides fig2dev which is used for building the documentation,
>>> for example, gstreamer and libtheora may use fig2dev.
>> 
>> Considering nothing depends on it, clearly not in stock oe-core.
>> Presumably you have some patches to enable the documentation builds
>> and add the missing dependencies?
> 
> It also appears that GStreamer (at least gstreamer itself, HEAD of
> master and 0.10) doesn't actually use fig files for the documentation,
> just PNG.
> 
> If we're talking about a large number of packages then I'd agree, but
> if we're saying that oe-core should have imake and transfig-native so
> that if you patch libtheora to build documentation it has diagrams,
> then I'm not sure that's a suitable trade-off.

agreed.

> 
> Ross
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/transfig/transfig-native_3.2.5d.bb b/meta/recipes-devtools/transfig/transfig-native_3.2.5d.bb
deleted file mode 100644
index c20a243..0000000
--- a/meta/recipes-devtools/transfig/transfig-native_3.2.5d.bb
+++ /dev/null
@@ -1,39 +0,0 @@ 
-SUMMARY = "Utilities for converting XFig figure files"
-DESCRIPTION = "This package contains utilities (mainly fig2dev) to \
-handle XFig (Facility for Interactive Generation of figures) files."
-HOMEPAGE = "http://www-epb.lbl.gov/xfig/"
-SECTION = "console/utils"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://fig2dev/fig2dev.c;endline=16;md5=6bab01e017409cf9ab21d3e953b793f7"
-PR = "r1"
-
-DEPENDS = "imake-native xorg-cf-files-native zlib-native jpeg-native libpng-native libxpm-native"
-
-SRC_URI = "${SOURCEFORGE_MIRROR}/mcj/transfig.${PV}.tar.gz"
-
-SRC_URI[md5sum] = "f9eac7f265668ecbfda6aaf7581989ad"
-SRC_URI[sha256sum] = "ae81214177fb05f91f6e43b0b42633b6e0024570cbc6591a3858e12100ce8aaa"
-
-S = "${WORKDIR}/transfig.${PV}"
-
-EXTRA_OEMAKE = "-I${S}"
-
-inherit native
-
-do_configure() {
-	xmkmf
-	make Makefiles
-
-	# Fix hardcoded references to host build locations
-	sed -i -e "s|SYSTEMUSRLIBDIR = /usr/lib64|SYSTEMUSRLIBDIR = ${libdir}|g" fig2dev/Makefile
-	sed -i -e "s|SYSTEMUSRINCDIR = /usr/include|SYSTEMUSRINCDIR = ${includedir}|g" fig2dev/Makefile
-	sed -i -e "s|XPMINC = -I/usr/include/X11|XPMINC = -I${includedir}/X11|g" fig2dev/Makefile 
-	sed -i -e "s|/usr/lib64|/usr/lib|g" fig2dev/Makefile || true
-	sed -i -e "s|/usr/lib64|/usr/lib|g" fig2dev/dev/Makefile || true
-	sed -i -e "s|/usr/local/lib|${libdir}|g" fig2dev/Makefile
-	sed -i -e "s|/usr/local/lib|${libdir}|g" fig2dev/dev/Makefile
-}
-
-do_install() {
-	oe_runmake install DESTDIR=${D}
-}
diff --git a/meta/recipes-gnome/packagegroups/packagegroup-toolset-native.bb b/meta/recipes-gnome/packagegroups/packagegroup-toolset-native.bb
index 82ee820..934b1be 100644
--- a/meta/recipes-gnome/packagegroups/packagegroup-toolset-native.bb
+++ b/meta/recipes-gnome/packagegroups/packagegroup-toolset-native.bb
@@ -213,7 +213,6 @@  DEPENDS = "\
     tcl-native \
     texinfo-native \
     tiff-native \
-    transfig-native \
     tzcode-native \
     u-boot-mkimage-native \
     unfs-server-native \