Patchwork enjoy: add alsa and autodetect gst modules. Without autodetect, enjoy segfaults. Without alsa, no sound is played

login
register
mail settings
Submitter Pau Espin Pedrol
Date June 13, 2011, 5:52 p.m.
Message ID <1307987531-2625-1-git-send-email-pespin.shar@gmail.com>
Download mbox | patch
Permalink /patch/5801/
State New, archived
Headers show

Comments

Pau Espin Pedrol - June 13, 2011, 5:52 p.m.
---
 recipes/e17/enjoy_svn.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Paul Menzel - June 13, 2011, 6:10 p.m.
Dear Pau,


thank you for your contribution.

Am Montag, den 13.06.2011, 19:52 +0200 schrieb Pau Espin Pedrol:

The commit summary is a bit long. Please add a blank line in between and
add your Signed-off-by line according to the commit policy [1].

Please also paste the important parts of the segfault into the commit
message.

What system did you use for testing?

> ---
>  recipes/e17/enjoy_svn.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/e17/enjoy_svn.bb b/recipes/e17/enjoy_svn.bb
> index eab81b4..d709eb7 100644
> --- a/recipes/e17/enjoy_svn.bb
> +++ b/recipes/e17/enjoy_svn.bb
> @@ -3,7 +3,7 @@ LICENSE = "LGPLv3"
>  DEPENDS = "evas ecore edje elementary emotion lightmediascanner"
>  SRCREV = "${EFL_SRCREV}"
>  PV = "0.0+svnr${SRCPV}"
> -PR = "r4"
> +PR = "r5"
>  
>  DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}"
>  
> @@ -13,7 +13,7 @@ DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', '
>  #4th needed for flac playback
>  #5th needed binary to create db
>  RDEPENDS += "\
> -	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  \
> +	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  gst-plugin-alsa gst-plugin-autodetect \
>  	${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad gst-plugin-id3demux', d)} \
>  	gst-plugin-ogg gst-plugin-ivorbisdec \
>  	gst-plugin-flac \

Otherwise this looks good. Please resend as “v2” [2].


Thanks,

Paul


[1] http://openembedded.org/index.php/Commit_Policy
[2] http://openembedded.org/index.php/How_to_submit_a_patch_to_OpenEmbedded
Pau Espin Pedrol - June 13, 2011, 6:44 p.m.
Hi, thanks for reviewing it ;)

2011/6/13 Paul Menzel <paulepanter@users.sourceforge.net>

> Please also paste the important parts of the segfault into the commit
> message.
>

I don't have the segfault right now because I've using buil enjoy with this
patch for few days since now. Basically it seems that emotion is using
autodetect gst pipe element, which in turn is using alsa.

I think it was this file/line in emotion:
emotion_gstreamer_pipeline.c:   sink =
gst_element_factory_make("autoaudiosink", "audiosink");

I'm using SHR distro.

I'll send new patch version now.
Nicolas Aguirre - June 13, 2011, 7:16 p.m.
2011/6/13 Pau Espin Pedrol <pespin.shar@gmail.com>:
> Hi, thanks for reviewing it ;)
>
> 2011/6/13 Paul Menzel <paulepanter@users.sourceforge.net>
>
>> Please also paste the important parts of the segfault into the commit
>> message.
>>
>
> I don't have the segfault right now because I've using buil enjoy with this
> patch for few days since now. Basically it seems that emotion is using
> autodetect gst pipe element, which in turn is using alsa.
>
> I think it was this file/line in emotion:
> emotion_gstreamer_pipeline.c:   sink =
> gst_element_factory_make("autoaudiosink", "audiosink");
>
> I'm using SHR distro.
>
> I'll send new patch version now.
>
> --
> Pau Espin Pedrol
> mail/jabber: pespin.shar@gmail.com
> http://blog.espeweb.net
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

If you think there is a problem in emotion, we could fix it upstream ?
Pau Espin Pedrol - June 13, 2011, 7:19 p.m.
Well I wouldn't say it's a problem itself.. it's just how emotion works...
it uses that gstreamer module so it's a needed dep in order to run ;)
Paul Menzel - June 13, 2011, 8:14 p.m.
Am Montag, den 13.06.2011, 21:19 +0200 schrieb Pau Espin Pedrol:
> Well I wouldn't say it's a problem itself.. it's just how emotion works...
> it uses that gstreamer module so it's a needed dep in order to run ;)

But maybe it should fail gracefully and not segfault.


Thanks,

Paul
Pau Espin Pedrol - June 13, 2011, 9:16 p.m.
2011/6/13 Paul Menzel <paulepanter@users.sourceforge.net>

> But maybe it should fail gracefully and not segfault.


For sure, but imo this has nothing to do with this patch. I'm just adding
needed deps for the app to do its work as expected :)
Paul Menzel - June 13, 2011, 9:48 p.m.
Am Montag, den 13.06.2011, 23:16 +0200 schrieb Pau Espin Pedrol:
> 2011/6/13 Paul Menzel <paulepanter@users.sourceforge.net>
> 
> > But maybe it should fail gracefully and not segfault.
>
> For sure, but imo this has nothing to do with this patch. I'm just adding needed deps for the app to do its work as expected :)

Of course.

To improve Enjoy it would be perfect to report that problem to the
upstream developers. This would be the perfect solution for this
problem.


Thanks,

Paul
Pau Espin Pedrol - June 13, 2011, 10:08 p.m.
2011/6/13 Paul Menzel <paulepanter@users.sourceforge.net>

> Am Montag, den 13.06.2011, 23:16 +0200 schrieb Pau Espin Pedrol:
> > 2011/6/13 Paul Menzel <paulepanter@users.sourceforge.net>
> >
> > > But maybe it should fail gracefully and not segfault.
> >
> > For sure, but imo this has nothing to do with this patch. I'm just adding
> needed deps for the app to do its work as expected :)
>
> Of course.
>
> To improve Enjoy it would be perfect to report that problem to the
> upstream developers. This would be the perfect solution for this
> problem.
>
>
> Thanks,
>
> Paul
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>
I might find time to write and send a patch for that to emotion guys :)
Paul Menzel - June 13, 2011, 10:49 p.m.
Am Dienstag, den 14.06.2011, 00:08 +0200 schrieb Pau Espin Pedrol:
> 2011/6/13 Paul Menzel <paulepanter@users.sourceforge.net>
> 
> > Am Montag, den 13.06.2011, 23:16 +0200 schrieb Pau Espin Pedrol:
> > > 2011/6/13 Paul Menzel <paulepanter@users.sourceforge.net>
> > >
> > > > But maybe it should fail gracefully and not segfault.
> > >
> > > For sure, but imo this has nothing to do with this patch. I'm just adding
> > needed deps for the app to do its work as expected :)
> >
> > Of course.
> >
> > To improve Enjoy it would be perfect to report that problem to the
> > upstream developers. This would be the perfect solution for this
> > problem.

> I might find time to write and send a patch for that to emotion guys :)

Awesome! A report would be fine too. Maybe a developer already tackled
that or they have different ideas.


Thanks,

Paul

Patch

diff --git a/recipes/e17/enjoy_svn.bb b/recipes/e17/enjoy_svn.bb
index eab81b4..d709eb7 100644
--- a/recipes/e17/enjoy_svn.bb
+++ b/recipes/e17/enjoy_svn.bb
@@ -3,7 +3,7 @@  LICENSE = "LGPLv3"
 DEPENDS = "evas ecore edje elementary emotion lightmediascanner"
 SRCREV = "${EFL_SRCREV}"
 PV = "0.0+svnr${SRCPV}"
-PR = "r4"
+PR = "r5"
 
 DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly', d)}"
 
@@ -13,7 +13,7 @@  DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', '
 #4th needed for flac playback
 #5th needed binary to create db
 RDEPENDS += "\
-	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  \
+	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  gst-plugin-alsa gst-plugin-autodetect \
 	${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad gst-plugin-id3demux', d)} \
 	gst-plugin-ogg gst-plugin-ivorbisdec \
 	gst-plugin-flac \