Patchwork [meta-oe,PATCHv5] libsoc: new recipe

login
register
mail settings
Submitter ml@communistcode.co.uk
Date Sept. 13, 2013, 10:15 p.m.
Message ID <1379110532-29457-1-git-send-email-ml@communistcode.co.uk>
Download mbox | patch
Permalink /patch/58005/
State Accepted, archived
Commit e4697c8da3230d9d5fba9ce1890cdbb43ab9e5c1
Headers show

Comments

ml@communistcode.co.uk - Sept. 13, 2013, 10:15 p.m.
From: Jack Mitchell <jack@embed.me.uk>

Signed-off-by: Jack Mitchell <jack@embed.me.uk>
---
 v4 -> v5
 - Moved RDEPENDS to below do_install

 v3 -> v4
 - Added libgcc in RDEPENDS

 v2 -> v3
 - Removed DEPENDS on libgcc
 - Removed autogen.sh pre-configure as was unneeded

 v1 -> v2
 -added signed-off-by

 meta-oe/recipes-support/libsoc/libsoc_0.3.bb | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 meta-oe/recipes-support/libsoc/libsoc_0.3.bb
Otavio Salvador - Sept. 13, 2013, 10:22 p.m.
On Fri, Sep 13, 2013 at 7:15 PM, Jack Mitchell <ml@communistcode.co.uk> wrote:
> From: Jack Mitchell <jack@embed.me.uk>
>
> Signed-off-by: Jack Mitchell <jack@embed.me.uk>
...

The recipe is clean now ... but ...

> --- /dev/null
> +++ b/meta-oe/recipes-support/libsoc/libsoc_0.3.bb
> @@ -0,0 +1,14 @@
> +SUMMARY = "libsoc is a C library for interfacing with common SoC peripherals through generic kernel interfaces"
> +HOMEPAGE = "https://github.com/jackmitch/libsoc"
> +
> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5"
> +
> +inherit autotools
> +
> +SRCREV = "0764ee52b590d5ccb4bd4698f0011496b536ed70"
> +SRC_URI = "git://github.com/jackmitch/libsoc.git"
> +
> +S = "${WORKDIR}/git"
> +
> +RDEPENDS_${PN} = "libgcc"

I am a little concerned /why/ this is need. Your code seems quite
simple and I don't understand why this special need. Did you try to
install and use it without this RDEPENDS ? It should work just fine.
ml@communistcode.co.uk - Sept. 14, 2013, 8:37 a.m.
On 09/13/13 23:22, Otavio Salvador wrote:
> On Fri, Sep 13, 2013 at 7:15 PM, Jack Mitchell <ml@communistcode.co.uk> wrote:
>> From: Jack Mitchell <jack@embed.me.uk>
>>
>> Signed-off-by: Jack Mitchell <jack@embed.me.uk>
> ...
>
> The recipe is clean now ... but ...
>
>> --- /dev/null
>> +++ b/meta-oe/recipes-support/libsoc/libsoc_0.3.bb
>> @@ -0,0 +1,14 @@
>> +SUMMARY = "libsoc is a C library for interfacing with common SoC peripherals through generic kernel interfaces"
>> +HOMEPAGE = "https://github.com/jackmitch/libsoc"
>> +
>> +LICENSE = "LGPLv2.1"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5"
>> +
>> +inherit autotools
>> +
>> +SRCREV = "0764ee52b590d5ccb4bd4698f0011496b536ed70"
>> +SRC_URI = "git://github.com/jackmitch/libsoc.git"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +RDEPENDS_${PN} = "libgcc"
> I am a little concerned /why/ this is need. Your code seems quite
> simple and I don't understand why this special need. Did you try to
> install and use it without this RDEPENDS ? It should work just fine.
>

There seems to be a bug with the eglibc recipe as noted in a previous 
discussion [1] where pthreads requires libgcc.so to be available but it 
isn't pulled in as a requirement. Now, I believe this goes largly 
unnoticed as there are very few functions which actually require the 
libgcc.so lib, but it happens that one of the functions I use 
(pthread_cancel), does require it, so I run into this bug and as such 
have to depened on RDEPENDS = "libgcc" in order to ensure it is in the 
rootfs.

In the next version of the library I think I am going to see if I can 
work round using pthread_cancel in favour of a less awkward function.

Cheers,
Jack.

[1] http://comments.gmane.org/gmane.comp.handhelds.openembedded.core/37086
Otavio Salvador - Sept. 14, 2013, 2:15 p.m.
On Sat, Sep 14, 2013 at 5:37 AM, Jack Mitchell <ml@communistcode.co.uk> wrote:
> On 09/13/13 23:22, Otavio Salvador wrote:
>>
>> On Fri, Sep 13, 2013 at 7:15 PM, Jack Mitchell <ml@communistcode.co.uk>
>> wrote:
>>>
>>> From: Jack Mitchell <jack@embed.me.uk>
>>>
>>> Signed-off-by: Jack Mitchell <jack@embed.me.uk>
>>
>> ...
>>
>> The recipe is clean now ... but ...
>>
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-support/libsoc/libsoc_0.3.bb
>>> @@ -0,0 +1,14 @@
>>> +SUMMARY = "libsoc is a C library for interfacing with common SoC
>>> peripherals through generic kernel interfaces"
>>> +HOMEPAGE = "https://github.com/jackmitch/libsoc"
>>> +
>>> +LICENSE = "LGPLv2.1"
>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5"
>>> +
>>> +inherit autotools
>>> +
>>> +SRCREV = "0764ee52b590d5ccb4bd4698f0011496b536ed70"
>>> +SRC_URI = "git://github.com/jackmitch/libsoc.git"
>>> +
>>> +S = "${WORKDIR}/git"
>>> +
>>> +RDEPENDS_${PN} = "libgcc"
>>
>> I am a little concerned /why/ this is need. Your code seems quite
>> simple and I don't understand why this special need. Did you try to
>> install and use it without this RDEPENDS ? It should work just fine.
>>
>
> There seems to be a bug with the eglibc recipe as noted in a previous
> discussion [1] where pthreads requires libgcc.so to be available but it
> isn't pulled in as a requirement. Now, I believe this goes largly unnoticed
> as there are very few functions which actually require the libgcc.so lib,
> but it happens that one of the functions I use (pthread_cancel), does
> require it, so I run into this bug and as such have to depened on RDEPENDS =
> "libgcc" in order to ensure it is in the rootfs.
>
> In the next version of the library I think I am going to see if I can work
> round using pthread_cancel in favour of a less awkward function.
>
> Cheers,
> Jack.
>
> [1] http://comments.gmane.org/gmane.comp.handhelds.openembedded.core/37086
>

Acked-by: Otavio Salvador <otavio@ossystems.com.br>
ml@communistcode.co.uk - Sept. 19, 2013, 8:39 a.m.
On 09/13/13 23:15, Jack Mitchell wrote:
> From: Jack Mitchell <jack@embed.me.uk>
>
> Signed-off-by: Jack Mitchell <jack@embed.me.uk>
> ---
>   v4 -> v5
>   - Moved RDEPENDS to below do_install
>
>   v3 -> v4
>   - Added libgcc in RDEPENDS
>
>   v2 -> v3
>   - Removed DEPENDS on libgcc
>   - Removed autogen.sh pre-configure as was unneeded
>
>   v1 -> v2
>   -added signed-off-by
>
>   meta-oe/recipes-support/libsoc/libsoc_0.3.bb | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>   create mode 100644 meta-oe/recipes-support/libsoc/libsoc_0.3.bb
>
> diff --git a/meta-oe/recipes-support/libsoc/libsoc_0.3.bb b/meta-oe/recipes-support/libsoc/libsoc_0.3.bb
> new file mode 100644
> index 0000000..1bf2782
> --- /dev/null
> +++ b/meta-oe/recipes-support/libsoc/libsoc_0.3.bb
> @@ -0,0 +1,14 @@
> +SUMMARY = "libsoc is a C library for interfacing with common SoC peripherals through generic kernel interfaces"
> +HOMEPAGE = "https://github.com/jackmitch/libsoc"
> +
> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5"
> +
> +inherit autotools
> +
> +SRCREV = "0764ee52b590d5ccb4bd4698f0011496b536ed70"
> +SRC_URI = "git://github.com/jackmitch/libsoc.git"
> +
> +S = "${WORKDIR}/git"
> +
> +RDEPENDS_${PN} = "libgcc"

While Koen is away would someone mind pulling this in if there are no 
more comments?

Cheers,
Jack
Martin Jansa - Sept. 19, 2013, 12:11 p.m.
On Fri, Sep 13, 2013 at 11:15:32PM +0100, Jack Mitchell wrote:
> From: Jack Mitchell <jack@embed.me.uk>
> 
> Signed-off-by: Jack Mitchell <jack@embed.me.uk>
> ---
>  v4 -> v5
>  - Moved RDEPENDS to below do_install
> 
>  v3 -> v4
>  - Added libgcc in RDEPENDS
> 
>  v2 -> v3
>  - Removed DEPENDS on libgcc
>  - Removed autogen.sh pre-configure as was unneeded
> 
>  v1 -> v2
>  -added signed-off-by

Merged, thanks

> 
>  meta-oe/recipes-support/libsoc/libsoc_0.3.bb | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 meta-oe/recipes-support/libsoc/libsoc_0.3.bb
> 
> diff --git a/meta-oe/recipes-support/libsoc/libsoc_0.3.bb b/meta-oe/recipes-support/libsoc/libsoc_0.3.bb
> new file mode 100644
> index 0000000..1bf2782
> --- /dev/null
> +++ b/meta-oe/recipes-support/libsoc/libsoc_0.3.bb
> @@ -0,0 +1,14 @@
> +SUMMARY = "libsoc is a C library for interfacing with common SoC peripherals through generic kernel interfaces"
> +HOMEPAGE = "https://github.com/jackmitch/libsoc"
> +
> +LICENSE = "LGPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5"
> +
> +inherit autotools
> +
> +SRCREV = "0764ee52b590d5ccb4bd4698f0011496b536ed70"
> +SRC_URI = "git://github.com/jackmitch/libsoc.git"
> +
> +S = "${WORKDIR}/git"
> +
> +RDEPENDS_${PN} = "libgcc"
> -- 
> 1.8.4
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-support/libsoc/libsoc_0.3.bb b/meta-oe/recipes-support/libsoc/libsoc_0.3.bb
new file mode 100644
index 0000000..1bf2782
--- /dev/null
+++ b/meta-oe/recipes-support/libsoc/libsoc_0.3.bb
@@ -0,0 +1,14 @@ 
+SUMMARY = "libsoc is a C library for interfacing with common SoC peripherals through generic kernel interfaces"
+HOMEPAGE = "https://github.com/jackmitch/libsoc"
+
+LICENSE = "LGPLv2.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=e0bfebea12a718922225ba987b2126a5"
+
+inherit autotools
+
+SRCREV = "0764ee52b590d5ccb4bd4698f0011496b536ed70"
+SRC_URI = "git://github.com/jackmitch/libsoc.git"
+
+S = "${WORKDIR}/git"
+
+RDEPENDS_${PN} = "libgcc"