Patchwork [4/4] ti-pru-sw-examples: fix package run-time dependencies

login
register
mail settings
Submitter Melissa Watkins
Date Dec. 13, 2010, 1:20 p.m.
Message ID <1292246420-5969-1-git-send-email-m-watkins@ti.com>
Download mbox | patch
Permalink /patch/58/
State Accepted
Headers show

Comments

Melissa Watkins - Dec. 13, 2010, 1:20 p.m.
* This package depends on the ti-pru-sw-edma-driver and
  kernel-module-uio-pru modules at run-tim.  Added these packages
  to the RDEPENDS.
* Bump PR
* Update SRC_REV
* Update COMPATIBLE_MACHINE

Signed-off-by: Melissa Watkins <m-watkins@ti.com>
Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
---
 recipes/ti/ti-pru-sw-examples_1.00.00.bb |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)
 mode change 100755 => 100644 recipes/ti/ti-pru-sw-examples_1.00.00.bb
Paul Menzel - Dec. 13, 2010, 6:43 p.m.
Am Montag, den 13.12.2010, 07:20 -0600 schrieb Melissa Watkins:
> * This package depends on the ti-pru-sw-edma-driver and
>   kernel-module-uio-pru modules at run-tim.  Added these packages

tim*e*

>   to the RDEPENDS.
> * Bump PR
> * Update SRC_REV

SRCREV

> * Update COMPATIBLE_MACHINE

In all your four patches you update `SRCREV` and `COMPATIBLE_MACHINE`.
Could you please factor that out into separate patches. (At least next
time.)

I do not know anything about this program, but why is
`COMPATIBLE_MACHINE` changed? Was it incorrectly set from the beginning
or did something change upstream.

> Signed-off-by: Melissa Watkins <m-watkins@ti.com>
> Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
>
> ---
>  recipes/ti/ti-pru-sw-examples_1.00.00.bb |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
>  mode change 100755 => 100644 recipes/ti/ti-pru-sw-examples_1.00.00.bb
> 
> diff --git a/recipes/ti/ti-pru-sw-examples_1.00.00.bb b/recipes/ti/ti-pru-sw-examples_1.00.00.bb
> old mode 100755
> new mode 100644
> index a9239f8..02c3376
> --- a/recipes/ti/ti-pru-sw-examples_1.00.00.bb
> +++ b/recipes/ti/ti-pru-sw-examples_1.00.00.bb
> @@ -1,14 +1,15 @@
>  DESCRIPTION = "PRU sw example applications"
>  HOMEPAGE = "https://gforge.ti.com/gf/project/pru_sw/"
>  LICENSE = "BSD"
> -DEPENDS = "ti-pru-sw-app-loader ti-pru-sw-edma-library"
> -PR = "r0+svnr${SRCPV}"
> +DEPENDS += "ti-pru-sw-app-loader ti-pru-sw-edma-library"
> +RDEPENDS += "ti-pru-sw-edma-driver kernel-module-uio-pru"
> +PR = "r1+svnr${SRCPV}"
>  
> -COMPATIBLE_MACHINE = "omapl138|am180x-evm"
> +COMPATIBLE_MACHINE = "omapl138"
>  
>  SRC_URI = "svn://gforge.ti.com/svn/pru_sw/;module=trunk;proto=https;user=anonymous;pswd=''"
>  
> -SRCREV = "18"
> +SRCREV = "20"
>  S = "${WORKDIR}/trunk"
>  
>  do_compile () {


Thanks,

Paul
chase maupin - Dec. 13, 2010, 9:30 p.m.
> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Paul Menzel
> Sent: Monday, December 13, 2010 12:44 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: Re: [oe] [PATCH 4/4] ti-pru-sw-examples: fix package run-time
> dependencies
> 
> Am Montag, den 13.12.2010, 07:20 -0600 schrieb Melissa Watkins:
> > * This package depends on the ti-pru-sw-edma-driver and
> >   kernel-module-uio-pru modules at run-tim.  Added these packages
> 
> tim*e*
> 
> >   to the RDEPENDS.
> > * Bump PR
> > * Update SRC_REV
> 
> SRCREV
> 
> > * Update COMPATIBLE_MACHINE
> 
> In all your four patches you update `SRCREV` and `COMPATIBLE_MACHINE`.
> Could you please factor that out into separate patches. (At least next
> time.)
> 
> I do not know anything about this program, but why is
> `COMPATIBLE_MACHINE` changed? Was it incorrectly set from the beginning
> or did something change upstream.

COMPATIBLE_MACHINE was being defined for omapl138 (the SOC_FAMILY) and am180x-evm (which is a member of that SOC_FAMILY).  Therefore the use of am180x-evm was redundant.

> 
> > Signed-off-by: Melissa Watkins <m-watkins@ti.com>
> > Signed-off-by: Chase Maupin <Chase.Maupin@ti.com>
> >
> > ---
> >  recipes/ti/ti-pru-sw-examples_1.00.00.bb |    9 +++++----
> >  1 files changed, 5 insertions(+), 4 deletions(-)
> >  mode change 100755 => 100644 recipes/ti/ti-pru-sw-examples_1.00.00.bb
> >
> > diff --git a/recipes/ti/ti-pru-sw-examples_1.00.00.bb b/recipes/ti/ti-
> pru-sw-examples_1.00.00.bb
> > old mode 100755
> > new mode 100644
> > index a9239f8..02c3376
> > --- a/recipes/ti/ti-pru-sw-examples_1.00.00.bb
> > +++ b/recipes/ti/ti-pru-sw-examples_1.00.00.bb
> > @@ -1,14 +1,15 @@
> >  DESCRIPTION = "PRU sw example applications"
> >  HOMEPAGE = "https://gforge.ti.com/gf/project/pru_sw/"
> >  LICENSE = "BSD"
> > -DEPENDS = "ti-pru-sw-app-loader ti-pru-sw-edma-library"
> > -PR = "r0+svnr${SRCPV}"
> > +DEPENDS += "ti-pru-sw-app-loader ti-pru-sw-edma-library"
> > +RDEPENDS += "ti-pru-sw-edma-driver kernel-module-uio-pru"
> > +PR = "r1+svnr${SRCPV}"
> >
> > -COMPATIBLE_MACHINE = "omapl138|am180x-evm"
> > +COMPATIBLE_MACHINE = "omapl138"
> >
> >  SRC_URI =
> "svn://gforge.ti.com/svn/pru_sw/;module=trunk;proto=https;user=anonymous;p
> swd=''"
> >
> > -SRCREV = "18"
> > +SRCREV = "20"
> >  S = "${WORKDIR}/trunk"
> >
> >  do_compile () {
> 
> 
> Thanks,
> 
> Paul

Patch

diff --git a/recipes/ti/ti-pru-sw-examples_1.00.00.bb b/recipes/ti/ti-pru-sw-examples_1.00.00.bb
old mode 100755
new mode 100644
index a9239f8..02c3376
--- a/recipes/ti/ti-pru-sw-examples_1.00.00.bb
+++ b/recipes/ti/ti-pru-sw-examples_1.00.00.bb
@@ -1,14 +1,15 @@ 
 DESCRIPTION = "PRU sw example applications"
 HOMEPAGE = "https://gforge.ti.com/gf/project/pru_sw/"
 LICENSE = "BSD"
-DEPENDS = "ti-pru-sw-app-loader ti-pru-sw-edma-library"
-PR = "r0+svnr${SRCPV}"
+DEPENDS += "ti-pru-sw-app-loader ti-pru-sw-edma-library"
+RDEPENDS += "ti-pru-sw-edma-driver kernel-module-uio-pru"
+PR = "r1+svnr${SRCPV}"
 
-COMPATIBLE_MACHINE = "omapl138|am180x-evm"
+COMPATIBLE_MACHINE = "omapl138"
 
 SRC_URI = "svn://gforge.ti.com/svn/pru_sw/;module=trunk;proto=https;user=anonymous;pswd=''"
 
-SRCREV = "18"
+SRCREV = "20"
 S = "${WORKDIR}/trunk"
 
 do_compile () {