Patchwork [1/5] meta-environment: change package name to include MACHINE

login
register
mail settings
Submitter Laurentiu Palcu
Date Sept. 10, 2013, 3:10 p.m.
Message ID <fd6e252155ed3646c0e474647c214f4dc2fb7136.1378824959.git.laurentiu.palcu@intel.com>
Download mbox | patch
Permalink /patch/57763/
State Accepted
Commit 09a2b158818e2ec3c3e3b53b6d14fd3527c32c99
Headers show

Comments

Laurentiu Palcu - Sept. 10, 2013, 3:10 p.m.
Currently, the package name contains just the TRANSLATED_TARGET_ARCH.
When compiling the toolchain for two machines, belonging to the same
architecture (for example: qemuarm and beagleboard), this package gets
overwritten and adt-installer repo will contain just one
meta-environment package... This leads to situations like installing the
toolchain for qemuarm and end up with meta-environment package with
beagleboard cpu options.

[YOCTO #4783]

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
 meta/recipes-core/meta/meta-environment.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - Sept. 10, 2013, 6:44 p.m.
On Tue, Sep 10, 2013 at 06:10:46PM +0300, Laurentiu Palcu wrote:
> Currently, the package name contains just the TRANSLATED_TARGET_ARCH.
> When compiling the toolchain for two machines, belonging to the same
> architecture (for example: qemuarm and beagleboard), this package gets
> overwritten and adt-installer repo will contain just one
> meta-environment package... This leads to situations like installing the
> toolchain for qemuarm and end up with meta-environment package with
> beagleboard cpu options.
> 
> [YOCTO #4783]
> 
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> ---
>  meta/recipes-core/meta/meta-environment.bb |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/meta/meta-environment.bb b/meta/recipes-core/meta/meta-environment.bb
> index 9731300..3a71a9b 100644
> --- a/meta/recipes-core/meta/meta-environment.bb
> +++ b/meta/recipes-core/meta/meta-environment.bb
> @@ -37,7 +37,7 @@ do_install() {
>      install -m 0644 -t ${D}/${SDKPATH} ${SDK_OUTPUT}/${SDKPATH}/*
>  }
>  
> -PN = "meta-environment-${TRANSLATED_TARGET_ARCH}"
> +PN = "meta-environment-${MACHINE}"

You should probably change PACKAGE_ARCH as well.

>  PACKAGES = "${PN}"
>  FILES_${PN}= " \
>      ${SDKPATH}/* \
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Richard Purdie - Sept. 10, 2013, 9:52 p.m.
On Tue, 2013-09-10 at 20:44 +0200, Martin Jansa wrote:
> On Tue, Sep 10, 2013 at 06:10:46PM +0300, Laurentiu Palcu wrote:
> > Currently, the package name contains just the TRANSLATED_TARGET_ARCH.
> > When compiling the toolchain for two machines, belonging to the same
> > architecture (for example: qemuarm and beagleboard), this package gets
> > overwritten and adt-installer repo will contain just one
> > meta-environment package... This leads to situations like installing the
> > toolchain for qemuarm and end up with meta-environment package with
> > beagleboard cpu options.
> > 
> > [YOCTO #4783]
> > 
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> > ---
> >  meta/recipes-core/meta/meta-environment.bb |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-core/meta/meta-environment.bb b/meta/recipes-core/meta/meta-environment.bb
> > index 9731300..3a71a9b 100644
> > --- a/meta/recipes-core/meta/meta-environment.bb
> > +++ b/meta/recipes-core/meta/meta-environment.bb
> > @@ -37,7 +37,7 @@ do_install() {
> >      install -m 0644 -t ${D}/${SDKPATH} ${SDK_OUTPUT}/${SDKPATH}/*
> >  }
> >  
> > -PN = "meta-environment-${TRANSLATED_TARGET_ARCH}"
> > +PN = "meta-environment-${MACHINE}"
> 
> You should probably change PACKAGE_ARCH as well.

No, this isn't the correct thing to do in this case. The PN itself is
machine specific so the multiple packages can coexist in one nativesdk
arch.

Cheers,

Richard

Patch

diff --git a/meta/recipes-core/meta/meta-environment.bb b/meta/recipes-core/meta/meta-environment.bb
index 9731300..3a71a9b 100644
--- a/meta/recipes-core/meta/meta-environment.bb
+++ b/meta/recipes-core/meta/meta-environment.bb
@@ -37,7 +37,7 @@  do_install() {
     install -m 0644 -t ${D}/${SDKPATH} ${SDK_OUTPUT}/${SDKPATH}/*
 }
 
-PN = "meta-environment-${TRANSLATED_TARGET_ARCH}"
+PN = "meta-environment-${MACHINE}"
 PACKAGES = "${PN}"
 FILES_${PN}= " \
     ${SDKPATH}/* \