Patchwork [v2] libcroco: disable Bsymbolic if it is not supported on some hosts

login
register
mail settings
Submitter Ting Liu
Date Sept. 10, 2013, 10:02 a.m.
Message ID <1378807330-15606-1-git-send-email-b28495@freescale.com>
Download mbox | patch
Permalink /patch/57743/
State New
Headers show

Comments

Ting Liu - Sept. 10, 2013, 10:02 a.m.
From: Ting Liu <b28495@freescale.com>

When trying to build on my Centos 5.5 machine, got below error:
| checking for gtkdoc-mkpdf... no
| checking whether to build gtk-doc documentation... no
| checking for CROCO... yes
| checking if gcc supports "-Wl,-Bsymbolic-functions" flag...
| configure: error: -Bsymbolic requested but not supported by ld. Use --disable-Bsymbolic to disable
| Configure failed. The contents of all config.log files follows to aid debugging
|
| configure: exit 1
| ERROR: oe_runconf failed

Set --enable_Bsymbolic=auto to disable it when it is not suppported.

Signed-off-by: Ting Liu <b28495@freescale.com>
---
 meta/recipes-support/libcroco/libcroco_0.6.8.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Alexandru Palalau - Sept. 10, 2013, 3:58 p.m.
On 9/10/2013 1:02 PM, b28495@freescale.com wrote:
> From: Ting Liu <b28495@freescale.com>
>
> When trying to build on my Centos 5.5 machine, got below error:
> | checking for gtkdoc-mkpdf... no
> | checking whether to build gtk-doc documentation... no
> | checking for CROCO... yes
> | checking if gcc supports "-Wl,-Bsymbolic-functions" flag...
> | configure: error: -Bsymbolic requested but not supported by ld. Use --disable-Bsymbolic to disable
> | Configure failed. The contents of all config.log files follows to aid debugging
> |
> | configure: exit 1
> | ERROR: oe_runconf failed
>
> Set --enable_Bsymbolic=auto to disable it when it is not suppported.
>
> Signed-off-by: Ting Liu <b28495@freescale.com>
> ---
>   meta/recipes-support/libcroco/libcroco_0.6.8.bb |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-support/libcroco/libcroco_0.6.8.bb b/meta/recipes-support/libcroco/libcroco_0.6.8.bb
> index 3c5dc9a..fe1a42d 100644
> --- a/meta/recipes-support/libcroco/libcroco_0.6.8.bb
> +++ b/meta/recipes-support/libcroco/libcroco_0.6.8.bb
> @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605 \
>   SECTION = "x11/utils"
>   DEPENDS = "glib-2.0 libxml2 zlib"
>   BBCLASSEXTEND = "native"
> -
> +EXTRA_OECONF += "--enable_Bsymbolic=auto"

I think that the correct parameter would be --enalbe-Bsymbolic (no 
underscore as Ross already mentioned)

>   PR = "r1"
>
>   inherit autotools pkgconfig gnomebase
>

Best,
Ross Burton - Sept. 10, 2013, 4:09 p.m.
On 10 September 2013 16:58, Alexandru Palalau
<alexandrux.palalau@linux.intel.com> wrote:
>> +EXTRA_OECONF += "--enable_Bsymbolic=auto"
>
> I think that the correct parameter would be --enalbe-Bsymbolic (no
> underscore as Ross already mentioned)

The ironyometer is at 11 now thanks to even more typos!  This patch is doomed.

https://git.gnome.org/browse/libcroco/tree/configure.in?id=0.6.8#n101

The option is "--enable-Bsymbolic=auto". :)

Ross

Patch

diff --git a/meta/recipes-support/libcroco/libcroco_0.6.8.bb b/meta/recipes-support/libcroco/libcroco_0.6.8.bb
index 3c5dc9a..fe1a42d 100644
--- a/meta/recipes-support/libcroco/libcroco_0.6.8.bb
+++ b/meta/recipes-support/libcroco/libcroco_0.6.8.bb
@@ -10,7 +10,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605 \
 SECTION = "x11/utils"
 DEPENDS = "glib-2.0 libxml2 zlib"
 BBCLASSEXTEND = "native"
-
+EXTRA_OECONF += "--enable_Bsymbolic=auto"
 PR = "r1"
 
 inherit autotools pkgconfig gnomebase