Patchwork sanity.bbclass: add xz to SANITY_REQUIRED_UTILITIES

login
register
mail settings
Submitter Jeff Polk
Date Sept. 9, 2013, 4:29 p.m.
Message ID <1378744154-6489-1-git-send-email-jeff.polk@windriver.com>
Download mbox | patch
Permalink /patch/57681/
State New
Headers show

Comments

Jeff Polk - Sept. 9, 2013, 4:29 p.m.
xz is commonly available and is now used by some recipes
It's reasonable to expect it to be present so error immediately
if it's not.

Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
---
 meta/classes/sanity.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Richard Purdie - Sept. 9, 2013, 10:20 p.m.
On Mon, 2013-09-09 at 11:29 -0500, Jeff Polk wrote:
> xz is commonly available and is now used by some recipes
> It's reasonable to expect it to be present so error immediately
> if it's not.
> 
> Signed-off-by: Jeff Polk <jeff.polk@windriver.com>
> ---
>  meta/classes/sanity.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Is it in all the base distros we use as standard or do we need update
the quickstart? Shouldn't we also be adding it to ASSUME_PROVIDED?

I think there is a different bug which may sometimes lead to build
failures due to the dependency on it not being generated correctly.

Cheers,

Richard

> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index a49b405..26038cb 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -2,7 +2,7 @@
>  # Sanity check the users setup for common misconfigurations
>  #
>  
> -SANITY_REQUIRED_UTILITIES ?= "patch diffstat makeinfo git bzip2 tar gzip gawk chrpath wget cpio"
> +SANITY_REQUIRED_UTILITIES ?= "patch diffstat makeinfo git bzip2 tar gzip gawk chrpath wget cpio xz"
>  
>  def bblayers_conf_file(d):
>      return os.path.join(d.getVar('TOPDIR', True), 'conf/bblayers.conf')

Patch

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index a49b405..26038cb 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -2,7 +2,7 @@ 
 # Sanity check the users setup for common misconfigurations
 #
 
-SANITY_REQUIRED_UTILITIES ?= "patch diffstat makeinfo git bzip2 tar gzip gawk chrpath wget cpio"
+SANITY_REQUIRED_UTILITIES ?= "patch diffstat makeinfo git bzip2 tar gzip gawk chrpath wget cpio xz"
 
 def bblayers_conf_file(d):
     return os.path.join(d.getVar('TOPDIR', True), 'conf/bblayers.conf')