Patchwork [meta-networking,1/1] fping: add recipe

login
register
mail settings
Submitter Fathi Boudra
Date Sept. 6, 2013, 2 p.m.
Message ID <1378476045-17681-1-git-send-email-fathi.boudra@linaro.org>
Download mbox | patch
Permalink /patch/57551/
State Superseded
Headers show

Comments

Fathi Boudra - Sept. 6, 2013, 2 p.m.
Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
---
 meta-networking/recipes-support/fping/fping_3.5.bb | 25 ++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 meta-networking/recipes-support/fping/fping_3.5.bb
Koen Kooi - Sept. 6, 2013, 7:10 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 06-09-13 16:00, Fathi Boudra schreef:
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> --- 
> meta-networking/recipes-support/fping/fping_3.5.bb | 25
> ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode
> 100644 meta-networking/recipes-support/fping/fping_3.5.bb
> 
> diff --git a/meta-networking/recipes-support/fping/fping_3.5.bb
> b/meta-networking/recipes-support/fping/fping_3.5.bb new file mode
> 100644 index 0000000..de41797 --- /dev/null +++
> b/meta-networking/recipes-support/fping/fping_3.5.bb @@ -0,0 +1,25 @@ 
> +SUMMARY = "sends ICMP ECHO_REQUEST packets to network hosts" 
> +DESCRIPTION = "fping is a ping like program which uses the Internet
> Control \ +Message Protocol (ICMP) echo request to determine if a target
> host is \ +responding. fping differs from ping in that you can specify
> any number of \ +targets on the command line, or specify a file
> containing the lists of \ +targets to ping.  Instead of sending to one
> target until it times out or \ +replies, fping will send out a ping
> packet and move on to the next target \ +in a round-robin fashion." 
> +HOMEPAGE = "http://www.fping.org/" +SECTION = "console/tools" +LICENSE =
> "BSD" +LIC_FILES_CHKSUM =
> "file://COPYING;md5=09d77789fe32be35acde9637a5ee39b1" +PR = "r0"

Drop the PR but, it's the default

> + +SRC_URI = "http://www.fping.org/dist/fping-${PV}.tar.gz" 
> +SRC_URI[md5sum] = "2e17cb655aa4eb59b5a4a38a89e746ed" +SRC_URI[sha256sum]
> = "09b8960e235341bae6000085d38106357eae656a79e0119bd27e816c9003656a" + +S
> = "${WORKDIR}/fping-${PV}" + +inherit autotools + +EXTRA_OECONF =
> "--enable-ipv4 --enable-ipv6"

That should probably be using PACKAGECONFIG for ipv6

> + +COMPATIBLE_HOST = "(i.86|x86_64|arm|aarch64).*-linux"

What breaks on powerpc and mips?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFSKii1MkyGM64RGpERAs1+AJwMTAC9o0rwoWGF55P9slUU1sqbaQCfa8MZ
C7SlRH3oOn6+Sh/YxSiSrWA=
=wkli
-----END PGP SIGNATURE-----
Fathi Boudra - Sept. 6, 2013, 9:32 p.m.
On 6 September 2013 22:10, Koen Kooi <koen@dominion.thruhere.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 06-09-13 16:00, Fathi Boudra schreef:
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org> ---
>> meta-networking/recipes-support/fping/fping_3.5.bb | 25
>> ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode
>> 100644 meta-networking/recipes-support/fping/fping_3.5.bb
>>
>> diff --git a/meta-networking/recipes-support/fping/fping_3.5.bb
>> b/meta-networking/recipes-support/fping/fping_3.5.bb new file mode
>> 100644 index 0000000..de41797 --- /dev/null +++
>> b/meta-networking/recipes-support/fping/fping_3.5.bb @@ -0,0 +1,25 @@
>> +SUMMARY = "sends ICMP ECHO_REQUEST packets to network hosts"
>> +DESCRIPTION = "fping is a ping like program which uses the Internet
>> Control \ +Message Protocol (ICMP) echo request to determine if a target
>> host is \ +responding. fping differs from ping in that you can specify
>> any number of \ +targets on the command line, or specify a file
>> containing the lists of \ +targets to ping.  Instead of sending to one
>> target until it times out or \ +replies, fping will send out a ping
>> packet and move on to the next target \ +in a round-robin fashion."
>> +HOMEPAGE = "http://www.fping.org/" +SECTION = "console/tools" +LICENSE =
>> "BSD" +LIC_FILES_CHKSUM =
>> "file://COPYING;md5=09d77789fe32be35acde9637a5ee39b1" +PR = "r0"
>
> Drop the PR but, it's the default

ack

>> + +SRC_URI = "http://www.fping.org/dist/fping-${PV}.tar.gz"
>> +SRC_URI[md5sum] = "2e17cb655aa4eb59b5a4a38a89e746ed" +SRC_URI[sha256sum]
>> = "09b8960e235341bae6000085d38106357eae656a79e0119bd27e816c9003656a" + +S
>> = "${WORKDIR}/fping-${PV}" + +inherit autotools + +EXTRA_OECONF =
>> "--enable-ipv4 --enable-ipv6"
>
> That should probably be using PACKAGECONFIG for ipv6

ack

>> + +COMPATIBLE_HOST = "(i.86|x86_64|arm|aarch64).*-linux"
>
> What breaks on powerpc and mips?

nothing. it can be dropped.

Thanks for the review, I'm preparing V2.

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFSKii1MkyGM64RGpERAs1+AJwMTAC9o0rwoWGF55P9slUU1sqbaQCfa8MZ
> C7SlRH3oOn6+Sh/YxSiSrWA=
> =wkli
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-networking/recipes-support/fping/fping_3.5.bb b/meta-networking/recipes-support/fping/fping_3.5.bb
new file mode 100644
index 0000000..de41797
--- /dev/null
+++ b/meta-networking/recipes-support/fping/fping_3.5.bb
@@ -0,0 +1,25 @@ 
+SUMMARY = "sends ICMP ECHO_REQUEST packets to network hosts"
+DESCRIPTION = "fping is a ping like program which uses the Internet Control \
+Message Protocol (ICMP) echo request to determine if a target host is \
+responding. fping differs from ping in that you can specify any number of \
+targets on the command line, or specify a file containing the lists of \
+targets to ping.  Instead of sending to one target until it times out or \
+replies, fping will send out a ping packet and move on to the next target \
+in a round-robin fashion."
+HOMEPAGE = "http://www.fping.org/"
+SECTION = "console/tools"
+LICENSE = "BSD"
+LIC_FILES_CHKSUM = "file://COPYING;md5=09d77789fe32be35acde9637a5ee39b1"
+PR = "r0"
+
+SRC_URI = "http://www.fping.org/dist/fping-${PV}.tar.gz"
+SRC_URI[md5sum] = "2e17cb655aa4eb59b5a4a38a89e746ed"
+SRC_URI[sha256sum] = "09b8960e235341bae6000085d38106357eae656a79e0119bd27e816c9003656a"
+
+S = "${WORKDIR}/fping-${PV}"
+
+inherit autotools
+
+EXTRA_OECONF = "--enable-ipv4 --enable-ipv6"
+
+COMPATIBLE_HOST = "(i.86|x86_64|arm|aarch64).*-linux"