Patchwork devshell: Don't corrupt the fakeroot variables

login
register
mail settings
Submitter Richard Purdie
Date Sept. 5, 2013, 3:17 p.m.
Message ID <1378394247.32427.75.camel@ted>
Download mbox | patch
Permalink /patch/57481/
State Accepted
Commit 5963d24ec5be437717c5ce6ecac291d2e3263a35
Headers show

Comments

Richard Purdie - Sept. 5, 2013, 3:17 p.m.
The devshell anonymous python fragment overwrites variables in the
datastore with their expanded versions. If this runs before the code
in allarch.bbclass which changes TARGET_OS, we can end up with different
directories in the fakeroot environment variables, some expanded with
the original TARGET_OS value.

The devshell code only needs to run before the task itself so we change
to trigger it to run at task execution time only using a flag.

[YOCTO #4795]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

Patch

diff --git a/meta/classes/devshell.bbclass b/meta/classes/devshell.bbclass
index a780118..92edb9e 100644
--- a/meta/classes/devshell.bbclass
+++ b/meta/classes/devshell.bbclass
@@ -3,6 +3,15 @@  inherit terminal
 DEVSHELL = "${SHELL}"
 
 python do_devshell () {
+    if d.getVarFlag("do_devshell", "manualfakeroot"):
+       d.prependVar("DEVSHELL", "pseudo ")
+       fakeenv = d.getVar("FAKEROOTENV", True).split()
+       for f in fakeenv:
+            k = f.split("=")
+            d.setVar(k[0], k[1])           
+            d.appendVar("OE_TERMINAL_EXPORTS", " " + k[0])
+       d.delVarFlag("do_devshell", "fakeroot")
+
     oe_terminal(d.getVar('DEVSHELL', True), 'OpenEmbedded Developer Shell', d)
 }
 
@@ -17,11 +26,8 @@  do_devshell[nostamp] = "1"
 # manually
 python () {
     if d.getVarFlag("do_devshell", "fakeroot"):
-       d.prependVar("DEVSHELL", "pseudo ")
-       fakeenv = d.getVar("FAKEROOTENV", True).split()
-       for f in fakeenv:
-            k = f.split("=")
-            d.setVar(k[0], k[1])           
-            d.appendVar("OE_TERMINAL_EXPORTS", " " + k[0])
+       # We need to signal our code that we want fakeroot however we
+       # can't manipulate the environment and variables here yet (see YOCTO #4795)
+       d.setVarFlag("do_devshell", "manualfakeroot", "1")
        d.delVarFlag("do_devshell", "fakeroot")
 }